From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by sourceware.org (Postfix) with ESMTPS id 8E609385801A for ; Tue, 23 Feb 2021 06:35:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8E609385801A Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11N6Q4jr017022; Tue, 23 Feb 2021 06:35:27 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 36tsuqx45b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Feb 2021 06:35:27 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11N6Oa7A192739; Tue, 23 Feb 2021 06:35:26 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by aserp3020.oracle.com with ESMTP id 36ucaxy01u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Feb 2021 06:35:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K56IwGA1K4jp0vR68fCLFJ/CGDhg5MXfN9C/g7H3pncMTTzw/evw/ODG6yocA0UgqwPkqeZTG/gUnJc971URKa80TWPtHwh/kzBW2iXuqQ42RL6qb6s3ZjcBHxLFZOGmPeI+xsUOok2EZrSn7ZxjWXMK/UBZkrWdf/RnyoxDNyia2I0NqLTW2mQb4zax5BWnE9fydJlQzWYVLJTCXIVx17FMfqNDBbcW8SaCBIu+STEyFOrAMRzjHi0ILtidjij3xkud7AmsAgLbQsNxNpLGHmmqT6IVkbYXhmGf+jEAZyiCkrZnbfBciFrbICG/n9Jrh7HdY0WQPgNCRLXmkS/YDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAZZ1l+6IqaBqzx3hebnhLIAWLoYMDcus/Bgnx06USk=; b=XB0cqhI6Vph2UTRRnzBKCKrV6RiuouVwMDte/ONABcc+IOG1b1U3AKRTjtMTH9zbCiNk/OqUgdgUs0ZthmhP7JIoEwfyJPQ+Y41yxQeV0z6hy+NjeM42ECPGIjBui62F2GLQt76QoNVKjdiJGrbNru2yM5N8QIUjMbhmMGV4MING6v0RIrnT7tJXfO0K2tVeOP1CP3ssL+rSueK6mIC4TifcPhLprA7XQesyetBQ27ABwSVmec1yvWibRkV5RC0lnFqMSusA4MfN+5L9ui2BRRuJrIWTjuUUTbAbQXrQMhCcv9DwS7kqffDMyBDk8gjwCP+hgm10KiWfDJKszRpNcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from CH0PR10MB4937.namprd10.prod.outlook.com (2603:10b6:610:c5::24) by CH0PR10MB5322.namprd10.prod.outlook.com (2603:10b6:610:c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.30; Tue, 23 Feb 2021 06:35:24 +0000 Received: from CH0PR10MB4937.namprd10.prod.outlook.com ([fe80::39c4:a3c7:209b:99a7]) by CH0PR10MB4937.namprd10.prod.outlook.com ([fe80::39c4:a3c7:209b:99a7%7]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 06:35:24 +0000 Subject: Re: Re: [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435) To: Simon Marchi , Tom Tromey , Simon Marchi via Gdb-patches References: <20210221155630.3026942-1-simon.marchi@polymtl.ca> <87a6rxku96.fsf@tromey.com> <179bcb0e-9b47-fac8-6a1a-21311efd8212@oracle.com> <2f83e650-8ce1-4730-e815-6036e71eac9b@polymtl.ca> From: Libor Bukata Message-ID: Date: Tue, 23 Feb 2021 07:35:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <2f83e650-8ce1-4730-e815-6036e71eac9b@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [188.75.191.143] X-ClientProxiedBy: ZR0P278CA0057.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::8) To CH0PR10MB4937.namprd10.prod.outlook.com (2603:10b6:610:c5::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.2] (188.75.191.143) by ZR0P278CA0057.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Tue, 23 Feb 2021 06:35:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3af6f938-d9cf-4125-10cd-08d8d7c53316 X-MS-TrafficTypeDiagnostic: CH0PR10MB5322: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: unAH/mN1B8+c6pLWnEsiKAE8aDzTn9bHHsZFvPN1+ukFbjzdAfxwyfeEvOqZj7xf1TUakKpPIlUkuRBQ+Lq9pQDMoh6XUGbMWJijeUazC5rFnCnsWvtshokOZN10mwKvHRLt7t8TE0tK+ugmH3d/tGQWZERuRtBZ6Ny4Yl2EqRCDw3Q1RQOpoQhq0mQD3AuncJ7ELMyv/oX1+YVaFFPxJQT4zxzzLUzbiHI5Z151EhlXTvUNbKU5US+BxAYCUEY3WDetfD77OknXcfDTSoXXICjg+d9Hc8n2OsGb/55ZSOV7agpojddcn+DDgsEKqbq1w7RX8VKjLmtFj66bBDb24arHad7Yxc2GkmpRbplSvO0a20s/NBT0uE8gzYfuuejUs0TMO6aiMEo+Vk9VOJysimmBMmY0GIBqG3PFZKnXldDszs3KoIy0Klq8pL5xztGpe0X5VZBmRyZJN5ZBHlG0Nn55LaFDTznv9UAOcIi820YMKRJ5oLXSCq44b/UWIAyxzXjJrJvd+1YzOkTGtyyakh2HsZjUIrFZvXesKsd+zOUEg/CWdRiIFtI2ZItvj5FGpOQE2LSpaOfAIXkUhi4vJyEpPptyNnKUZ3z5YDush1I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR10MB4937.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39860400002)(366004)(346002)(376002)(136003)(53546011)(66476007)(16576012)(5660300002)(36756003)(2906002)(16526019)(31686004)(4744005)(86362001)(83380400001)(8936002)(8676002)(66946007)(26005)(316002)(6486002)(478600001)(66556008)(44832011)(31696002)(2616005)(186003)(110136005)(956004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NWxEUGpRc0QyTDhUOVNmYUNML2VScSs5ZlFzZmorNWZPQktRT0svZHFZYWFl?= =?utf-8?B?NkZGSEdwWkRCOHp3QXNqWFJaeXJYdWkyVUcyMng5bUh0T2lpZ1dlcVJhSUwr?= =?utf-8?B?Q2hTQ0dlZVE1MkQ1ZVI0TUtseU5hTEZTSHNWdjRPUkREcHRXN1Nab2xHS1V5?= =?utf-8?B?MjNWTW9rbWU0ZEtEQXhGaWUyUkRHU0piUFNSRDhzZ0hWVk0reTg1TEhZZytG?= =?utf-8?B?U1RJYlo0WklKSzg4R2lTR0ZWZjV3QlV0WHdVS3lBbnZ5UHNXam1DQk0vT2pE?= =?utf-8?B?Q1c1UkxtZE5JZmEwYVRROUNsdVRYbk4xQVMvdjhob3ZtUUJTaUhKSndUc1FH?= =?utf-8?B?NitjdTNCUnVRTmxvQlprSHVIUUc5bUtwWG9leXN4V1NrRVFtTnQ5QXRHdCtJ?= =?utf-8?B?S2hnVGJVZStNb2FaZW5yb0N2anpEdGprWm4zQmtCK0szUENwWWZhNThIVzJy?= =?utf-8?B?c3lIa2puWVZaY1dsbDNWekl1SFNGaEpiTkJrWHNWdlJ3WXgxcjA3cWtoL08y?= =?utf-8?B?TzdGMUdwTy9rczAyTk1COW50aWV6NjlLZlV4QkJZV3dtdk5mRW8xQnFuVnFk?= =?utf-8?B?WnFkT0hLZERCZXpXOXphdDlka2FLbW5hT0ZRM01TSlI1Zy8zOGI1U1ZLb2Nh?= =?utf-8?B?R3NWMlh2L2haUm5GT0NrTEYyd2pKOURVYm1PUEJCaU03VWs4MVhZWGczRTRl?= =?utf-8?B?Rnd5c3hjRHV2SUJvUkVSWDBGbVNhd0RvaU15OXVtV0QrZGZsLzZEdEIxeVMv?= =?utf-8?B?YjFKYlZ2VGpYSzVhOXB6cWF6MG9ZN2p2K0VualdtdUdyN2JLRGlERUJVa2lG?= =?utf-8?B?Tm9MZE5Lc0p0eUJpKytvRGtSSTFDdVEvTkZ2eHVzeUpwaXdQclNCcVh1RkhI?= =?utf-8?B?NWd4a2dzM1BheFNEdFZZSGN1SU9XM2w0MFkwclZERUJkUTBpbHRrcmcxY2M3?= =?utf-8?B?RitCeW0zU3Y2WC9vRHZTa2JOaE5EMUREc1gwUzRsMjV4b1g5eWhpejdCOEx4?= =?utf-8?B?WU5TUE1GSWN4Q0kyZCtUaW04RWl5VzBza0JCVGFUUWJUczZVMDFCRi90enN3?= =?utf-8?B?ckFJcGhlSXlORjdHT3JDNW5DNnBrR1ZLQ2F4djhYbmVSVnR2M3Y1bmFEV25X?= =?utf-8?B?Q1o2QWdmSm9QWlYxKzJSd2MyaFhBbVNUalJxVnl4SkNqelZpVWc0YXJVcEFB?= =?utf-8?B?Q1M0clRNU2JYSGw0Qm9wbE9HS3V2ZU9wNkpOSXhLTldScnd6TkZyMkJQeEhh?= =?utf-8?B?RnluamVya2pNSG1kVFFJRnZhL1JSMm9RRFlXRncxVnE1QXd0dzdjTm9Xd2pM?= =?utf-8?B?cUxSaVhtOXFPWWJzeDMwdG5zV1hJT2p5Z21UQmdLUmVuMHdtdGtVZTY3ckpk?= =?utf-8?B?UGhFVi9wbGVHNEV4Z2FqN3Z2dFJwT3pQaEFuM3IwdzNQWS9FVkdndi9zRWJH?= =?utf-8?B?eDNRN2V2TVJnUjlaTGI5RjBCWTljZFY3bWZyTDQ1eHBBOGtUeTR3SENUaEho?= =?utf-8?B?SnlvN3pzUVh3WFNSS0poZ0FxelBHNXBuNWRPNFVmVzhybnMwdjhydnJUYVBp?= =?utf-8?B?c1lkL29JRHVqQ242RC9CVnRLbklpNGl3dkNhVE1Dd0R4dE9GN1NkSjM2cFBT?= =?utf-8?B?KzdsZzcxTlZJNi9oejQvTG54NFl0N29mZlNZazVONko4dUxKbENxYzZIbk1h?= =?utf-8?B?SDZ3MUtGZDF1VUw1VWwwZVUvYWVLYmJBc1NsUWx5cFFtckRWTXRlVlc0QS9Y?= =?utf-8?Q?ZuXhtP1gBQXRZ7fi3Xoq73l92YNaIRTq9lUQuBH?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3af6f938-d9cf-4125-10cd-08d8d7c53316 X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4937.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 06:35:24.0913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rF4WBaCWRedQ1FaYZAvvaz9TYWtoz9UYg9NNXopk0Z3xwo/slSHex8FuVk3T4HFMXRKO/jcR/8a0uL5OSQGUxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5322 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9903 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102230055 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9903 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 malwarescore=0 clxscore=1015 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102230055 X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 06:35:41 -0000 Thank you for the integration. Unit tests did not reveal any new regressions on Solaris. Libor On 2/22/21 5:51 PM, Simon Marchi wrote: > On 2021-02-22 6:03 a.m., Libor Bukata wrote:> Many thanks to Simon for the patch. >> I confirm that it fixes the attach crash on Solaris x86/sparc. >> The testsuite did not reveal any new regressions on Fedora Linux. >> Regarding Solaris, the tests require much more time, >> so, I will let you know when I have results. >> >> AFAIK, the code changes look good. > Thanks, I pushed the series to the master branch, and patch 1 to > gdb-10-branch. Please let me know if you find unexpected regressions on > Solaris (although hopefully, you'll see some tests going from FAIL to > PASS). > > Simon