From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30052.outbound.protection.outlook.com [40.107.3.52]) by sourceware.org (Postfix) with ESMTPS id 74A4538485A5 for ; Wed, 1 Jun 2022 10:00:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74A4538485A5 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NY0RIpYD1xcYTeaJpohrnR1mGZKwXj3NtgAIwM7q3dszR/yKr9fbkiKVjo3zvAKWMr7eY1VnvKiWhr8kSbTDAvhKontkXThnoQaFI0amP/9c0smbfzhTW9puDESOfRQoDnFJ9C02JHCnF6183rG9q0XTl+ieBy1LpO/cCLmtz6Ta5uPxzikqoF6+oqSid7Gh5nZ7N5kHFVSe9K4rK8/OjCkNCkEFPql75qvFLjN0RJUxvSy3+GDgXtQKFhsM/WWuWXWPWtTELvLwfujrLSvoDizvEi4X8c9wMLXuTbdUVVD8ZQCYws8HX98IJfLBCF747i/RfO7W4xopOY0IVtfuuA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a66XGfsE0CXevaIbluQ0ggT9EPRBXUI5LEbHwOn2jjM=; b=gvkK2EqLK/lquG6154Wjq/oZlO9P1U8KVJ8wzl6yysLjxPhoSBdMlULt3rf6hQSN2UZxr7829VaKAhfn98dyYOesz8FpthIZNHtyD3N3qsyon+u2x2iq0S0mTFtPfFfgHCQ7WwMeCL/WctDAyr19qp9ZVH7xuRw4U4ua1uI1gmVnm69TUQ3gOBVJHttet6/NemP+DYs220bsXY8Vv+C4Y394Pw+eVCbK+txVtiiF/MrAW/Y2swyXGcLCFstn6WI6hCQlAwXWqipQSiB5mVlkRl97TBXfPPnjbXMzrbk1yup4xlELWsdkkNU+nNNksgYpoGFX1QMAnO17INVYtTjefg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR04CA0110.eurprd04.prod.outlook.com (2603:10a6:20b:531::12) by DB9PR08MB6473.eurprd08.prod.outlook.com (2603:10a6:10:257::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 1 Jun 2022 10:00:03 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:531:cafe::aa) by AS9PR04CA0110.outlook.office365.com (2603:10a6:20b:531::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Wed, 1 Jun 2022 10:00:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Wed, 1 Jun 2022 10:00:03 +0000 Received: ("Tessian outbound 5b5a41c043d3:v120"); Wed, 01 Jun 2022 10:00:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 84c76dadafcf6389 X-CR-MTA-TID: 64aa7808 Received: from e65f1cf3d52c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A2322F46-9A80-48D9-85AF-3A2A18CBF3A2.1; Wed, 01 Jun 2022 09:59:55 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e65f1cf3d52c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Jun 2022 09:59:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B6mREThOP6yxeCHMzWh//75XWYwvu5WFzfiUxDBHkE2D76C3s7IhXDn3BI9cLzPAdZc3vJTnbLV1VzeYa13om2SBYmGgNN+VhSQkZbW0NAaAI7AKSvrV7XEp3byCwuxkIU4kxWnvL20KxqOAu3YcJz0m8zBiV39aYFFrfvLW5GmALIV1rlpChfCJ5pLomLhkXTUj+8D0F2AgXzXgA2PvCYHwxGWwoPqgIw8wTQd1kZRWjPrvY7xmbqi4S1AJT7fSjoTNYGzCtJzjTnbY6SML0HPCl7IsRGStQqIUrISwjlOh2eD17Q7j0FBhNnoLSsJQiWc1R4Ig9SFGcWDyMvf3HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a66XGfsE0CXevaIbluQ0ggT9EPRBXUI5LEbHwOn2jjM=; b=BUx7Wz4N9hF9WKGNXbrpoE/RkB/kKppNgJXj5PmEbSeJrToshCvcs4Ydv495xyOAedMF+fhWkdcgIo+iUyv7+r6uqXb7EUMlVQAy/iFrVmZvlwx+6OBfOgf/5qWBgPi3Yldo3MypOJ3iGP/y1lro4iTK5WH8ZZs/5PLXiEF2dGVOdB0djir2cC0VBa0GlGpzFX04GIbOzrGHSUnYKDKM997KNTIDeg1hQqBSGBEOcAfIIcf/wbkZDCKnCyhQvtSnm2EPTzJoLOswBpdo0h1pnUhweLSRXpWcfHzdRGOVJUUfmI/mZ8TYxxrWbB0rmepJYLgw2v3o10MtOw3ZxtB5jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB9PR08MB6937.eurprd08.prod.outlook.com (2603:10a6:10:26e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 1 Jun 2022 09:59:45 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::9545:ff73:df89:3e50]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::9545:ff73:df89:3e50%7]) with mapi id 15.20.5314.013; Wed, 1 Jun 2022 09:59:45 +0000 Message-ID: Date: Wed, 1 Jun 2022 10:59:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gdb/arm: Add support for FPU registers in prologue unwinder Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220531133336.GC13232@gnbcxd0114.gnb.st.com> From: Luis Machado In-Reply-To: <20220531133336.GC13232@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0132.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::13) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 19429703-ebba-4ef0-99cf-08da43b57f6b X-MS-TrafficTypeDiagnostic: DB9PR08MB6937:EE_|AM5EUR03FT005:EE_|DB9PR08MB6473:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cpgPwqUYBRF8oD1AOID5KPh2Z7B8M6nK1KmTXQh6UV56j4h6Di53XksKmxmqgNz7GRhhfMey0h4CLv9qcrlGlS5IHQkJM24TiX5/2c4w9DGiIdgKrmSHDKAER4WBd47UkvTWotxNUwTPKf/ay1gLlcsXHvBZ/rNMlmo6YNnjhRLXMYXhANhuBeVsAhy/5tJ3jxw/FQENK0fIInvPpmeFGC2YKI8OzvxCweBdqw9xV/SUIdDzyiohckU8tNW6cbmjP6Td/Wd9vRM/2RP8hpB0Y6FYItK+dTU+8j6rLwLhd64OFv8Q6gYGl/LsxNCSd+XAzlpFA0/qLi7SnOOfOhyFo6Yi10k6DLpbp36ZBHy5+o50tzoIwotjF1j0/YJkkDBQkAW5G1WxbHJk07h4+Br5X9iLAQ4jgLWp1XVH9yKL4NHnNONlRkc9RRJGCR9vE3659Xsipka4XrYPzOVrNQYPmCkqPk4M1VbN3vI7cMBgCkose4KcYQ4BEjlXDfs683opamO7KO8JhprNrjSD3s8aiG3+mSUg5IKky08gjE/QkOvHpoNsedwWNIkHMj+ZLirQJpChBl2DLcr/yImqdKgP7AvZh8R12UCscK3M+56WiDfqfweT9ebpkbgPZfmDxoBJdeaPGTooNGbceEMVaEPpCOE+62Qx3NVm8k/E+jVlG6YZYaTaQMJoNHzNz71AyXTkWhqY18/gTPKiRfp6fLcXBd8AK9V5BATTQFFkklW50qs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(31686004)(86362001)(4744005)(316002)(83380400001)(186003)(31696002)(26005)(2616005)(6506007)(6512007)(53546011)(2906002)(38100700002)(36756003)(6486002)(66476007)(8936002)(66556008)(66946007)(8676002)(4326008)(508600001)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6937 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4d152590-fd87-4d88-6ce5-08da43b57490 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EpGQpt4FuUN8bS9mcWT5Ii8mynUT1fYX8gUHdiZNNCnBmk9IdZqAXTERVKedy0+NOzlgXtUWmIZhBZ4aCDd6MhGnmRSVfqcmvF8AOnOBYa4iFjaPavLslBF4QgGJeAjs5pgtWY2vL+S9M/qerg0KzYcuGam/mpvV0YrPl6yDAVi7Vnu3gbH+u6LGaDeoLkYdkvKqr+i9s1uVRdXeLPzF6InmDiT5YdmDG0+ve3ltJXkqeKumKRFZ2eY/zwGGUK3saGULfS0JDoypGr884+bQitkoRmal22jH06xWwyWGotP0yEpZWWIb7echtozdnYVolKR6mdATlC8D11mJa/5EiZj35c73dfYcXBUj+BH9RhGxnEiw/TYOjbbF3jUy4kOUROtpuBco9zl0weJLuPJRa5BMmUEPhhnsS4mwrwlIXHJSJNmoS2HU/9rS0U78im9O75OLwb7fkISTjVZL0188pGDb+K1cb4Sxh3IjauI8gLEuB1qF7d6hiDFg58eGAk3B1CKngvlsxy5Ng2MGnh9u/voRcsspNpT7hL5Nrz4zT3PaTRf0BoXwIXdGpIdWTx9BG+Dc5fIDvQ/gCs6mCfBRMegwPJ/CxVgIzVbgeV74oUb8OCWdzdNluUlQSbON8tnt634LI8qoKk7irVb7rv1Kv7GD+R2ygWY/Xa9aCU2dBaQihEZyTPFK74HW0ZIozgX4EmfLGaV8OLmO7R0cvIDiUw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(4744005)(6506007)(2616005)(44832011)(53546011)(356005)(36860700001)(81166007)(31686004)(36756003)(47076005)(82310400005)(336012)(2906002)(83380400001)(186003)(316002)(86362001)(8676002)(508600001)(8936002)(6486002)(31696002)(4326008)(5660300002)(70206006)(70586007)(6512007)(26005)(40460700003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 10:00:03.1621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19429703-ebba-4ef0-99cf-08da43b57f6b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6473 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 10:00:08 -0000 On 5/31/22 14:33, Yvan Roux wrote: > Hi, > > The prologue unwinder had support for FPU registers, but only to > calculate the correct offset on the stack, the values were not saved. > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 49664093f00..0f204ac6a9f 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -1437,7 +1437,7 @@ thumb_analyze_prologue (struct gdbarch *gdbarch, > cache->framesize = -regs[ARM_SP_REGNUM].k; > } > > - for (i = 0; i < 16; i++) > + for (i = 0; i < gdbarch_num_regs (gdbarch); i++) > if (stack.find_reg (gdbarch, i, &offset)) > cache->saved_regs[i].set_addr (offset); > Thanks, this is OK.