From: Michael Weghorn <m.weghorn@posteo.de>
To: Christian Biesinger <cbiesinger@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: [PATCH v2 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases
Date: Thu, 30 Apr 2020 08:02:14 +0200 [thread overview]
Message-ID: <a07cee89-df65-8abb-5da9-84907071f8f9@posteo.de> (raw)
In-Reply-To: <CAPTJ0XF+fBUNOR9v7Va2rOLb-m9SQ0m-YS+mK_ySy6XQdfKHDA@mail.gmail.com>
On 29/04/2020 17.25, Christian Biesinger wrote:
>> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
>> index 8f7482347c..7ad931f9b4 100644
>> --- a/gdb/infcmd.c
>> +++ b/gdb/infcmd.c
>> @@ -151,12 +151,11 @@ get_inferior_args (void)
>> {
>> if (current_inferior ()->argc != 0)
>> {
>> - char *n;
>> + std::string n;
>
> While changing this, I would just move the declaration to the line
> where it is first used.
>
Done now. A new version of the patch follows. (I haven't updated the
other patches of the series, since those remain unchanged.)
---
Allow construct_inferior_arguments to handle zero args
and have it return a std::string, similar to how
stringify_argv in gdbsupport/common-utils does.
Also, add a const qualifier for the second parameter,
since it is only read, not written to.
The intention is to replace some existing uses of
stringify_argv by construct_inferior_arguments
in a subsequent step, since construct_inferior_arguments
properly handles special characters, while stringify_argv
doesn't.
2020-04-29 Michael Weghorn <m.weghorn@posteo.de>
* common-inferior.cc, common-inferior.h (construct_inferior_arguments):
Adapt to handle zero args and return a std::string.
Adapt call site.
---
gdb/infcmd.c | 7 ++-----
gdbsupport/common-inferior.cc | 19 +++++++++++--------
gdbsupport/common-inferior.h | 2 +-
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 8f7482347c..3ac64b3164 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -151,12 +151,9 @@ get_inferior_args (void)
{
if (current_inferior ()->argc != 0)
{
- char *n;
-
- n = construct_inferior_arguments (current_inferior ()->argc,
+ std::string n = construct_inferior_arguments (current_inferior ()->argc,
current_inferior ()->argv);
- set_inferior_args (n);
- xfree (n);
+ set_inferior_args (n.c_str());
}
if (current_inferior ()->args == NULL)
diff --git a/gdbsupport/common-inferior.cc b/gdbsupport/common-inferior.cc
index 71b9a11e02..3f117d5ef0 100644
--- a/gdbsupport/common-inferior.cc
+++ b/gdbsupport/common-inferior.cc
@@ -28,15 +28,15 @@ bool startup_with_shell = true;
/* Compute command-line string given argument vector. This does the
same shell processing as fork_inferior. */
-char *
-construct_inferior_arguments (int argc, char **argv)
+std::string
+construct_inferior_arguments (int argc, char * const *argv)
{
- char *result;
+ gdb_assert (argc >= 0);
+ if (argc == 0 || argv[0] == NULL) {
+ return "";
+ }
- /* ARGC should always be at least 1, but we double check this
- here. This is also needed to silence -Werror-stringop
- warnings. */
- gdb_assert (argc > 0);
+ char *result;
if (startup_with_shell)
{
@@ -145,5 +145,8 @@ construct_inferior_arguments (int argc, char **argv)
}
}
- return result;
+ std::string str_result(result);
+ xfree (result);
+
+ return str_result;
}
diff --git a/gdbsupport/common-inferior.h b/gdbsupport/common-inferior.h
index eb60c8f13b..0b11e7d6a5 100644
--- a/gdbsupport/common-inferior.h
+++ b/gdbsupport/common-inferior.h
@@ -58,6 +58,6 @@ extern void set_inferior_cwd (const char *cwd);
the target is started up with a shell. */
extern bool startup_with_shell;
-extern char *construct_inferior_arguments (int, char **);
+extern std::string construct_inferior_arguments (int, char * const *);
#endif /* COMMON_COMMON_INFERIOR_H */
--
2.26.2
next prev parent reply other threads:[~2020-04-30 6:02 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 11:16 Patches for PR 25893 "gdbserver incorrectly handles program args containing space" Michael Weghorn
2020-04-29 11:16 ` [PATCH 0/4] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-07 19:31 ` Simon Marchi
2020-05-12 15:50 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases Michael Weghorn
2020-04-29 15:25 ` Christian Biesinger
2020-04-29 15:45 ` Christian Biesinger
2020-05-07 19:29 ` Simon Marchi
2020-05-12 15:48 ` Michael Weghorn
2020-05-12 16:11 ` Simon Marchi
2020-05-12 16:24 ` Michael Weghorn
2020-04-30 6:02 ` Michael Weghorn [this message]
2020-05-07 19:49 ` [PATCH v2 " Simon Marchi
2020-05-12 15:57 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 2/4] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-07 19:54 ` Simon Marchi
2020-05-12 16:00 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 3/4] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-07 20:09 ` Simon Marchi
2020-05-07 22:09 ` Simon Marchi
2020-05-12 16:10 ` Michael Weghorn
2020-05-12 16:07 ` Michael Weghorn
2020-05-12 17:37 ` Simon Marchi
2020-05-13 1:59 ` Simon Marchi
2020-05-13 9:51 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it Michael Weghorn
2020-05-07 22:15 ` Simon Marchi
2020-05-10 15:59 ` [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Simon Marchi
2020-05-10 15:59 ` [PATCH 2/2] gdb/testsuite: add inferior arguments test Simon Marchi
2020-05-15 20:07 ` Pedro Alves
2020-05-19 17:13 ` Simon Marchi
2020-05-20 16:28 ` Michael Weghorn
2020-05-15 20:07 ` [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Pedro Alves
2020-05-10 16:09 ` [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it Simon Marchi
2020-05-11 14:33 ` Michael Weghorn
2020-05-11 15:04 ` Simon Marchi
2020-05-12 16:20 ` Michael Weghorn
2020-05-12 16:50 ` Simon Marchi
2020-05-13 9:55 ` Michael Weghorn
2020-04-29 15:27 ` Patches for PR 25893 "gdbserver incorrectly handles program args containing space" Simon Marchi
2020-04-30 6:03 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 1/6] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 2/6] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-12 17:53 ` Simon Marchi
2020-05-13 9:56 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 3/6] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 4/6] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-12 18:34 ` Simon Marchi
2020-05-13 9:56 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 5/6] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-13 0:52 ` Simon Marchi
2020-05-13 0:54 ` Simon Marchi
2020-05-13 9:58 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 6/6] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-13 0:52 ` Simon Marchi
2020-05-13 9:47 ` [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 2/9] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 3/9] gdbsupport: Let construct_inferior_arguments take gdb::array_view param Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 4/9] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 5/9] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 6/9] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 7/9] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board Michael Weghorn
2020-05-15 17:29 ` Tom de Vries
2020-05-19 17:11 ` Simon Marchi
2020-05-19 17:22 ` Simon Marchi
2020-05-19 18:46 ` Tom de Vries
2020-05-25 15:14 ` Simon Marchi
2020-05-13 9:47 ` [PATCH v4 9/9] gdb/testsuite: add inferior arguments test Michael Weghorn
2020-05-13 14:39 ` [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport Simon Marchi
2020-05-13 15:01 ` Michael Weghorn
2020-05-13 15:05 ` Simon Marchi
2020-05-20 16:37 ` Michael Weghorn
2020-05-20 16:40 ` Simon Marchi
2020-05-20 16:21 ` [PATCH v5 " Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 2/9] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 3/9] gdbsupport: Let construct_inferior_arguments take gdb::array_view param Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 4/9] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 5/9] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 6/9] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 7/9] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 9/9] gdb/testsuite: add inferior arguments test Michael Weghorn
2020-05-25 15:42 ` [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport Simon Marchi
2020-05-26 6:17 ` Michael Weghorn
2021-09-28 14:33 ` Simon Marchi
2021-09-29 5:53 ` Michael Weghorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07cee89-df65-8abb-5da9-84907071f8f9@posteo.de \
--to=m.weghorn@posteo.de \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).