From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 04/12] Fix a couple vStopped pending ack bugs
Date: Wed, 3 Feb 2021 01:25:15 +0000 [thread overview]
Message-ID: <a08b6946-2098-23e0-eb12-8318cf940b00@palves.net> (raw)
In-Reply-To: <fae327d2-d43f-66b2-426a-96d5f44fb774@polymtl.ca>
On 13/01/21 05:29, Simon Marchi wrote:
> On 2021-01-12 8:15 p.m., Pedro Alves wrote:
> Just to be sure I understand does that sum it up?
>
> 1. GDBserver sends stop notification about thread X, the remote target
> receives it and stores it
> 2. At the same time, GDB detaches thread X's inferior
> 3. The remote target discards the received stop notification
> 4. GDBserver waits forever for the ack
Yup. Thanks for that summary. I've borrowed it and put it in the commit log.
> Since the first item in the list has a special status (it is the in
> flight one), perhaps having a separate field in notif_server for it
> would make things clearer.
>
> I mean having an additional
>
> notif_event *in_flight;
>
> field in there. When sending a notification, it gets dequeu-ed from
> the queue and put there.
It's likely yes, though I'd prefer that was done separately, as it has
risk of messing up something else.
>
> Either way, this LGTM.
Thanks. I've merged it.
next prev parent reply other threads:[~2021-02-03 1:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 1:15 [PATCH 00/12] Fix detach + displaced-step regression + N bugs more Pedro Alves
2021-01-13 1:15 ` [PATCH 01/12] Fix attaching in non-stop mode Pedro Alves
2021-01-13 3:11 ` Simon Marchi
2021-02-03 1:21 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 02/12] Fix "target extended-remote" + "maint set target-non-stop" + "attach" Pedro Alves
2021-01-13 5:01 ` Simon Marchi
2021-01-13 1:15 ` [PATCH 03/12] Testcase for attaching in non-stop mode Pedro Alves
2021-01-13 5:09 ` Simon Marchi
2021-02-03 1:23 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 04/12] Fix a couple vStopped pending ack bugs Pedro Alves
2021-01-13 5:29 ` Simon Marchi
2021-02-03 1:25 ` Pedro Alves [this message]
2021-01-13 1:15 ` [PATCH 05/12] gdbserver: spurious SIGTRAP w/ detach while step-over in progress Pedro Alves
2021-01-13 6:00 ` Simon Marchi
2021-02-03 1:26 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 06/12] Factor out after-stop event handling code from stop_all_threads Pedro Alves
2021-01-13 6:06 ` Simon Marchi
2021-02-03 1:26 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 07/12] prepare_for_detach: don't release scoped_restore at the end Pedro Alves
2021-01-13 6:08 ` Simon Marchi
2021-02-03 1:27 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 08/12] prepare_for_detach and ongoing displaced stepping Pedro Alves
2021-01-13 6:23 ` Simon Marchi
2021-01-13 1:15 ` [PATCH 09/12] detach and breakpoint removal Pedro Alves
2021-01-13 6:32 ` Simon Marchi
2021-02-03 1:28 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 10/12] detach with in-line step over in progress Pedro Alves
2021-01-13 6:39 ` Simon Marchi
2021-01-13 1:15 ` [PATCH 11/12] detach in all-stop with threads running Pedro Alves
2021-01-13 6:55 ` Simon Marchi
2021-02-03 1:31 ` Pedro Alves
2021-07-12 15:36 ` Jonah Graham
2021-07-12 19:36 ` Pedro Alves
2021-01-13 1:15 ` [PATCH 12/12] Testcase for detaching while stepping over breakpoint Pedro Alves
2021-01-13 7:05 ` Simon Marchi
2021-02-03 1:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a08b6946-2098-23e0-eb12-8318cf940b00@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).