From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WBB2=3S=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 6E58D3857C4F
	for <gdb-patches@sourceware.org>; Fri, 18 Nov 2022 14:46:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6E58D3857C4F
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 5210C229E5;
	Fri, 18 Nov 2022 14:46:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1668782794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Wjv1fFJFpXAhrNeVPKjfQsBzfYk9FZDdfeYrTqtOSdo=;
	b=kjPeI4LdMqnHgyguOIguvmDE13pQzhbPXz0vbP8BcBkNw86pV3r5CrUiL2Ekzn+ToxfWdz
	uEVzxEZve+4QFXqzNflNxaWZfUOBNjapoR5LL57AJkN9QGu88fKzjtnw2h+22zz9qNMESx
	+ZseBvILKsW68VkX5in+t7JOSvSvmJg=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1668782794;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Wjv1fFJFpXAhrNeVPKjfQsBzfYk9FZDdfeYrTqtOSdo=;
	b=ScWobUQMozmb33sZcnoWKxQI+yvqeI0+T/RvTOkRP7H7lAzwWjeXp4wxfVGPKfQ/mbrZqG
	+hqtDcQ0aw5DTCCA==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F02AD1345B;
	Fri, 18 Nov 2022 14:46:33 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id XgDbNsmad2PwUgAAMHmgww
	(envelope-from <tdevries@suse.de>); Fri, 18 Nov 2022 14:46:33 +0000
Message-ID: <a08df8bd-e6b7-f6c7-cf46-a5cf04c0c607@suse.de>
Date: Fri, 18 Nov 2022 15:46:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp
Content-Language: en-US
To: Carl Love <cel@us.ibm.com>,
 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
 Will Schmidt <will_schmidt@vnet.ibm.com>
References: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 11/16/22 23:11, Carl Love via Gdb-patches wrote:
> -if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
> +set additional_flags ""
> +
> +if {[have_fvar_tracking]} {
> +    set additional_flags "additional_flags= -fvar-tracking"
> +}
> +
> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile [list debug $additional_flags]]} {
>       return -1
>   }
>   

AFAIU, needing -fvar-tracking is specific to powerpc, so we should limit 
it's impact to that target.

And it's a gcc compiler flag, so perhaps we should limit it's impact to 
that as well.

And if we indeed need it but it's not available, we should skip the test 
(or xfail the failing bit), because we cannot expect it to succeed.

So how about something like this:
...
set flags {}

lappend flags debug

if { [istarget powerpc*-*-*] && [is_c_compiler_gcc] } {
     if { [have_fvar_tracking] } {
         lappend flags -fvar-tracking
     } else {
         unsupported "gcc used, -fvar-tracking needed"
         return -1
     }
}

if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} {
        return -1
}
...

Thanks,
- Tom