Re: [PATCH] gdb: fix frame passed to gdbarch_value_to_register in value_assign

[Simon Marchi <simark@simark.ca>]

On 1/11/24 12:24, Tom de Vries wrote:
> On 1/11/24 17:51, Simon Marchi wrote:
>> Commit 78f2fd84e83 ("gdb: remove VALUE_REGNUM, add value::regnum")
>> introduced an unexpected change in value_assign.  It replaced
>> `get_prev_frame_always (next_frame)` with `next_frame`in the call to
>> gdbarch_value_to_register.
>>
>> This is the result of a merge error, since I previously had a patch to
>> change gdbarch_value_to_register to take the next frame, and later
>> decided to drop it.  Revert that change.
>>
>> Add a test based on the DWARF assembler to expose the problem and test
>> the fix.  I also tested on ppc64le to make sure the problem reported in
>> PR 31231 was fixed.
>>
> 
> I applied the patch on x86_64, ran the test-case, observed the internal error, rebuild gdb, and observed it pass.
> 
> Only one nit, I get:
> ...
> DUPLICATE: gdb.dwarf2/assign-variable-value-to-register.exp: p foo

Ah thanks, missed it.

> ...
> 
> Tested-by: Tom de Vries <tdevries@suse.de>

Thanks, will push with the duplicate test name fixed.

Simon