From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 363CD3858C62 for ; Fri, 8 Dec 2023 12:09:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 363CD3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 363CD3858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702037341; cv=none; b=SD8PRHH15V4l2BgiuKQidp1Z0enKsxNpFmQKjSDSjJN7YAAnGjS+v8rOUJtH7Uo7MnTBaqP1ntZsTdwhRO4W7qsvyx529MSoMRnT/0fgNmZuFKWm/lb7aVUGHYbFeUDyvmrNYjS7IbVwDxBclmt5KR8VjfWyybMju9Yk2jsWfbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702037341; c=relaxed/simple; bh=zykDqE5iyLtsNoN+z5DpSyx6lNdrZ/21WnrlcOsDnDA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=OXz+UwBXGv/AWgtlDmw7XDXohVqwnmv88vLmQEZGcDV4AG+Ew+VwFoUwL35rvudDJiUddobOrGxZi/LGLnRW2DzwFbczUh7yMBPoRSYfS0Au0HSQaV+qLQjwMpFfZEfJEV03OEfVQSC32ZjqXB4iCO5JILYPiygF4bIUsMxkZ2w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 32D371F393 for ; Fri, 8 Dec 2023 12:08:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702037339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bdeaoeXlkf2VjXQC51WuSnT8nsnh1Zc8hKN0/3OXsE=; b=tGd4PhZjCuu/y8y5VkqUtkYpd/0bBQvFKXPS8QrHACxSixTrIr5McpwbPiBKXQ4opDkg4y yFNQGODMG3V0YQd3Kbhsb0yf06vN6Yl/j/JhLnZ2WJpp7oLAiWacNpPAQlQ2yIYliEx388 lez8PmCIZnhDXa7u4sAbmMvFQw5vU+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702037339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bdeaoeXlkf2VjXQC51WuSnT8nsnh1Zc8hKN0/3OXsE=; b=5tka0lTlR48vDZfLsCp900uVqyocWkOdRzLveePbuzdyc69RrZ5iQBeuDVQwRhlOra51aI /sjjbUG4Nr7o2tAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702037339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bdeaoeXlkf2VjXQC51WuSnT8nsnh1Zc8hKN0/3OXsE=; b=tGd4PhZjCuu/y8y5VkqUtkYpd/0bBQvFKXPS8QrHACxSixTrIr5McpwbPiBKXQ4opDkg4y yFNQGODMG3V0YQd3Kbhsb0yf06vN6Yl/j/JhLnZ2WJpp7oLAiWacNpPAQlQ2yIYliEx388 lez8PmCIZnhDXa7u4sAbmMvFQw5vU+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702037339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bdeaoeXlkf2VjXQC51WuSnT8nsnh1Zc8hKN0/3OXsE=; b=5tka0lTlR48vDZfLsCp900uVqyocWkOdRzLveePbuzdyc69RrZ5iQBeuDVQwRhlOra51aI /sjjbUG4Nr7o2tAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2204312FF7 for ; Fri, 8 Dec 2023 12:08:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ilcGB1sHc2XGQgAAD6G6ig (envelope-from ) for ; Fri, 08 Dec 2023 12:08:59 +0000 Message-ID: Date: Fri, 8 Dec 2023 13:09:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] [gdb/symtab] Keep track of processed DIEs in shard To: gdb-patches@sourceware.org References: <20231002125051.29911-1-tdevries@suse.de> <20231002125051.29911-10-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: <20231002125051.29911-10-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spam-Score: -3.10 Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -4.10 X-Spamd-Result: default: False [-4.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.81)[99.19%]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Flag: NO X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/2/23 14:50, Tom de Vries via Gdb-patches wrote: > while (info_ptr < end_ptr) > { > sect_offset this_die = (sect_offset) (info_ptr - reader->buffer); > + > + { > + CORE_ADDR end_prev_die > + = form_addr (this_die - 1, reader->cu->per_cu->is_dwz, > + reader->cu->per_cu->is_debug_types); > + set_parent_valid (start_cu, end_prev_die); > + } > + This turned out to cause a performance degradation of 30%, and to be unnecessary, so I dropped this bit. Thanks, - Tom