From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2076.outbound.protection.outlook.com [40.107.103.76]) by sourceware.org (Postfix) with ESMTPS id 6A9FD3858418 for ; Mon, 23 Oct 2023 13:14:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A9FD3858418 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A9FD3858418 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=40.107.103.76 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698066872; cv=fail; b=c1pGSvE0vEwWgv+c0QhlEeqV95+C1wVO0XqafINOe4M+qzglwUNx0CDez141tsfTJseQbdbFv4WE6l/O8LoydMvVZcdF6JxhK6/lkDksE9Da5byoFGnuVcZJLBT5/NKOS9W9Cl87ECcbKx1dkP+uc1ntDTUztMPz4p7UBHuyttQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698066872; c=relaxed/simple; bh=qA22Nltj7wumkm1x8jrWKbEzsLiZJAjS1qJ9XOHUhjY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=AzHntpJffzQL5IQQkNIL4eExOZUF6fRIzgXYjt5DOohUaBBzETSR/mno6eVNhiMw+1la5cpB4int+DE38to5nKk0MCZVBIUNlNLBNnW9XhmNMWvSUV8aMau1USX4Z61LfxMSHUNWSAfLo+Fg+vx2nsKXy7Hp7zBGN1irju7OWuU= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ssNVCHIUBVAh9n32Xaf5dD8av2suqBhINPyIG3TZFsc=; b=MHX9d1eXbxJP6bGpoF4prYwzmS4EI7zAcTXOFKuHdsXnbz8c58jUAUXtGgUmKb6/rXfFOjoAgrB04pzB4YNbSNTbraIG+KQDRcoy/SH7usyAEo44W9jskijZ6YK6MHB2PH1EqbukrqRBzJUcDqnF+rRYilrHqLPvftQGonV0DPw= Received: from AS9PR05CA0052.eurprd05.prod.outlook.com (2603:10a6:20b:489::10) by PA4PR08MB5917.eurprd08.prod.outlook.com (2603:10a6:102:f1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Mon, 23 Oct 2023 13:14:28 +0000 Received: from AMS0EPF0000019D.eurprd05.prod.outlook.com (2603:10a6:20b:489:cafe::de) by AS9PR05CA0052.outlook.office365.com (2603:10a6:20b:489::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 13:14:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF0000019D.mail.protection.outlook.com (10.167.16.249) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 13:14:28 +0000 Received: ("Tessian outbound d9a8e74be042:v215"); Mon, 23 Oct 2023 13:14:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1ee53dcc16d7c62d X-CR-MTA-TID: 64aa7808 Received: from e0f733de0f84.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7DF3934D-E180-4A6B-BB40-B2A45D40D2B8.1; Mon, 23 Oct 2023 13:14:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e0f733de0f84.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Oct 2023 13:14:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gr8aVrEjN0Wj8EGb92nfwnt/LXVm9x0AZr3GadSSp8JqJBBOsl8TUUM1nEeGcPCysm1205tLP8jijscr7rmQG0KLy528GNxRSDRzKzqdJn+tHaMY7UzELVWHgO5VH6I/3uGmvh60whjsFI8lgUsHItklVRGsC6q76/0w4gy8DkX9/Kr1jGYDQC7Sg9SKv1mrsmhMgzU/pbKXOi5AwPTB7cjhGNkOYAjia/4OsEV9PerQZSgT1XjkSYL1YJJAQ0B6mEgYYeAm7Kv28RsknvR1sueRWsf6bA60RzfbQ+yGDd1Ebvhpi3FkDFMi4o4QfZDSd8FyogDlmZUCjEL6c+GdeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ssNVCHIUBVAh9n32Xaf5dD8av2suqBhINPyIG3TZFsc=; b=PbmjE/vFdXmmvWOn7/tuT3mhRUFydtBNRRTTr9imvOqUea4l+n0KTO2FCvHNPKWJgJ8GMAhbt7ktBhinPXKvJ4GO8RHBB0Dkyh4hKapdAdVQOAm3gkgW4nKwts7bBPh+bzLYXkypMg8vy3UmJb8L6n3AyFjhov7D5VhOr4jPzOTZT9dISKBhciNm1KOYN7t8oIYa6T+/6sMdWQ4jHfg1WP1j1zbSJo9WI+s2X19jv8WKTR/FOeBm0eo7r890R7m/hVhB2ApO5r3QwVJjg5de1KHrPb3KM9jjHy24QsM3hOuVdhm34mRVJz96Noj1w7xPxguX4kpIAI3he58bjjNVVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ssNVCHIUBVAh9n32Xaf5dD8av2suqBhINPyIG3TZFsc=; b=MHX9d1eXbxJP6bGpoF4prYwzmS4EI7zAcTXOFKuHdsXnbz8c58jUAUXtGgUmKb6/rXfFOjoAgrB04pzB4YNbSNTbraIG+KQDRcoy/SH7usyAEo44W9jskijZ6YK6MHB2PH1EqbukrqRBzJUcDqnF+rRYilrHqLPvftQGonV0DPw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV1PR08MB7380.eurprd08.prod.outlook.com (2603:10a6:150:24::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Mon, 23 Oct 2023 13:14:15 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::3e05:d9f5:3a1c:4b2f]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::3e05:d9f5:3a1c:4b2f%5]) with mapi id 15.20.6907.025; Mon, 23 Oct 2023 13:14:15 +0000 Message-ID: Date: Mon, 23 Oct 2023 14:14:12 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] Fix calls with small integers on ARM Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> <20231020-arm-params-v1-1-19d4c89c11b6@adacore.com> From: Luis Machado In-Reply-To: <20231020-arm-params-v1-1-19d4c89c11b6@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0511.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV1PR08MB7380:EE_|AMS0EPF0000019D:EE_|PA4PR08MB5917:EE_ X-MS-Office365-Filtering-Correlation-Id: 46cb8380-ba4e-49fb-b877-08dbd3c9fca0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zN6+faw6GY/FUxT6VRyV98mbHBHpsdbsN5yIyQ/uEh97hFq/27LYO5tR1bWMlp4ZR51wjPryDaE3/iieds5hnR7DiIrGmD6fUGJqaiJmzddi33OJmvIqEYoq21Sat8YzdKRJIi1PC+oPzd5+4Mh5nxJSVdOf9ahwWl3klDUTdd4o3bGOOFF9Ky00bnmzElelRk5WcvwsKNdmvpJASbmgO925zbVaFJIwqEskS+xf9dp4WC4wlCcx1wBZcYeAJ7BgSs8Qim6VfbxTWLStR/JhF8K04U4lDm8n2l8G5xczoB5hLra4R+7Pl0eu29K5WpV+UVOFOzq5Yybq0wf5ONUE3wVUqSLMqs3wxbUtDo1s53Q0HkOYQw21BwJqSGS4jbYai8vVUERzLocyJH1hkaTkonOXfjTsmG8EikihLeAxhgfV3LTV6sgKqRckRJcYj5R+7KkijpMj4JncdWNEkm5ewe8kz+m9cmj1HKkpbc/YoMVSm3iD+X2pQssbZpBUwNLuySPMtrxNLxzIDngiI2o9/YuOR2HTyUHBa1sPTl2pCrBi1ZqCDxWgdVCi0cShRtn7sODpgftjs1HMtqUIj4BiXuP5+8H/r9aNMY05qbTfZo12keWQJpgViRr81mWzALY3KvcnkoSgKaEx3fNkUHJVnw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(136003)(366004)(396003)(39860400002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(31686004)(26005)(38100700002)(2906002)(41300700001)(44832011)(31696002)(5660300002)(86362001)(36756003)(8676002)(8936002)(6666004)(478600001)(6506007)(316002)(66476007)(66946007)(2616005)(66556008)(83380400001)(6486002)(53546011)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7380 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF0000019D.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2e1ea033-6a45-4e29-ef0d-08dbd3c9f416 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VmPEqS/wkvxHeLfXOaITNh4v2djQO74VYwQ7m1r3wjNL6MQ9sQuVbfRwGWQeXgh6mbkZTHLKmFiFsEgHRfMe6Pe0uy++faasKTpxSV67ePxDoq/H7tY68kQwp+VeKTplHHr5wdWz039EJ4+fd2MwAXcRI91TX/fJQbO2PZoLXG7VGE9/dsJj6kKStU0o8KFA1CxKwDaeGtjiqQYpIAztYZOLF3W0l/Fvaj0OElfcQ339gYcqMNJfH6E6crGI4qMjpV5lr6X9f0MwkBb5N+Lsp144gI4oAKPM3UwOrnoBrp4JvhOAiPA7+436CYorducYfZJdmJXdVbiW09UsY+6hoT8BN8oourvTa11N2d7D8AD71yDvK/x2o9EqooLreeTBXdIlNzCGA8UWYHseK/0xptR7gjC0WjhGPYBUcfdGTpVosxiCsX816Y6mV8rJIn/VXQ9RnMZdvRExVwP319aHSKWM36m+FFoEp97rvZkhSowOhfZJL83tDsESj7CvEBNzbh46dwOPt1qQr8Zmth7Ym6V6tCK2LiFUVrYj8z9oApZlA9BuxSeqQ7AYNQpN6eMfrEFZGxeVBkZZ4c0vDm2UPxPd8/fsF/KvBM0fEw0mv4cuTolLbh3AWCwluCoEAbNS85FGygrfPD2Pz2LXmotJ5uaXe/00YKe3enHsPbEJU/RMuAhGYkF55bOMuEkXBoP7wHotXWzep1P80rSiB65/3pqFgoQlhCrheHvQ480FVkC+8Dolht0LhVpkW+vd9c2JyqWW2UeHibRzNPoHOjXxkQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(136003)(396003)(346002)(39860400002)(230922051799003)(186009)(82310400011)(451199024)(1800799009)(64100799003)(46966006)(36840700001)(40470700004)(31686004)(2906002)(41300700001)(36860700001)(44832011)(40460700003)(31696002)(5660300002)(86362001)(36756003)(8676002)(8936002)(2616005)(356005)(6506007)(478600001)(26005)(6666004)(82740400003)(81166007)(316002)(70206006)(70586007)(83380400001)(6486002)(53546011)(6512007)(40480700001)(336012)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 13:14:28.2867 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46cb8380-ba4e-49fb-b877-08dbd3c9fca0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF0000019D.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5917 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/23 20:15, Tom Tromey wrote: > On big-endian ARM, an inferior call with a small integer will pass the > wrong value. This patch fixes the problem. Because the code here > works using scalar values, and not just bytes, left-shifting is > unnecessary. > --- > gdb/arm-tdep.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index a0ad1fb7a82..97d7c5140d2 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -4824,9 +4824,6 @@ arm_push_dummy_call (struct gdbarch *gdbarch, struct value *function, > { > /* The argument is being passed in a general purpose > register. */ > - if (byte_order == BFD_ENDIAN_BIG) > - regval <<= (ARM_INT_REGISTER_SIZE - partial_len) * 8; > - > arm_debug_printf ("arg %d in %s = 0x%s", argnum, > gdbarch_register_name (gdbarch, argreg), > phex (regval, ARM_INT_REGISTER_SIZE)); > Do you have an example failure for the above? Is it a positve or negative integer? The code is meant to adjust padding, as small integers need to be padded/sign-extended when being put in the GPR's. This code has seen many changes over the years, and the padding/extension could've worked then. But looking at it now, it isn't really clear what the left-shifting is supposed to accomplish, as regval should be padded/sign-extended from extract_unsigned_integer.