From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AC8163858D20 for ; Thu, 3 Mar 2022 15:46:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC8163858D20 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 223Fk5nw003940 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Mar 2022 10:46:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 223Fk5nw003940 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 73C1C1F0D2; Thu, 3 Mar 2022 10:46:05 -0500 (EST) Message-ID: Date: Thu, 3 Mar 2022 10:46:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 0/2] Modify can_spawn_for_attach Content-Language: tl To: Tiezhu Yang , gdb-patches@sourceware.org References: <1645584316-5375-1-git-send-email-yangtiezhu@loongson.cn> <724bfb12-1301-1763-58b2-7a166ee9b22d@loongson.cn> <52930d69-2534-6c6d-e716-e256020bc4a2@polymtl.ca> <26ffd2e4-4aab-4367-96fb-bb8330b8eff8@polymtl.ca> <1be805f7-42a1-d8f6-e553-913ac3f1b4b2@loongson.cn> From: Simon Marchi In-Reply-To: <1be805f7-42a1-d8f6-e553-913ac3f1b4b2@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 3 Mar 2022 15:46:05 +0000 X-Spam-Status: No, score=-3031.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 15:46:20 -0000 On 2022-03-02 01:42, Tiezhu Yang wrote: > > > On 03/01/2022 10:12 PM, Simon Marchi wrote: >> >> >> On 2022-02-28 09:36, Simon Marchi via Gdb-patches wrote: >>> On 2022-02-28 01:59, Tiezhu Yang wrote: >>>> >>>> >>>> On 02/23/2022 10:45 AM, Tiezhu Yang wrote: >>>>> v5: >>>>>   -- Use "unsupported" instead of "untested" in patch #1, >>>>>      suggested by Simon Marchi, thank you. >>>>> >>>>> v4: >>>>>   -- Add patch #1 to print explicit test result for some test. >>>>>   -- Modify patch #2 suggested by Simon Marchi, thank you. >>>>> >>>>> Tiezhu Yang (2): >>>>>   gdb: testsuite: print explicit test result in can_spawn_for_attach >>>>>   gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp >>>>> >>>>>  gdb/testsuite/lib/gdb.exp | 46 +++++++++++++++++++++++++++++++++++++++------- >>>>>  1 file changed, 39 insertions(+), 7 deletions(-) >>>>> >>>> >>>> Hi, >>>> >>>> I modified the patches as you suggested. >>>> Any more comments? >>>> Can I push this patchset to the master? >>> >>> Yeah, please go ahead, thanks. >>> >>> Simon >> >> Actually, this causes the following test failures: >> >> FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt) >> >> Can you please take a look? > > OK, I will look into it. Thanks, gdb-caching-proc.exp now passes for me. I see this now though (this is on Ubuntu 20.04): attach 3431435^M A program is being debugged already. Kill it? (y or n) y^M Attaching to program: /home/smarchi/build/binutils-gdb/gdb/testsuite/outputs/gdb.base/jit-elf/jit-elf-main, process 3431435^M Reading symbols from /lib64/ld-linux-x86-64.so.2...^M Reading symbols from /usr/lib/debug//lib/x86_64-linux-gnu/ld-2.31.so...^M Unable to read JIT descriptor from remote memory^M 0x00007fafc9384334 in ?? ()^M (gdb) FAIL: gdb.base/jit-elf.exp: can spawn for attach Simon