From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id A00B63858D28 for ; Wed, 3 May 2023 23:47:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A00B63858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4QBYX53KN1z3k0p; Wed, 3 May 2023 23:47:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QBYX50P4Lz4CdD; Wed, 3 May 2023 23:47:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683157637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRxybakh23ZlMp6acf5v8QITUjCf1V5ZMX2gn+Yyixk=; b=dumXT+RCmRSMFiwTyCXDZ1x4jzgE5M5loJ/385Tc/TYttbas5gLI4jkiax+9BDvsr0Mj2u 66mWrZQIOehEDtjTxvzn+UId35cke6J5i+uKRYSviIlcB7NqoNm9FWSFJlmZKFpH/yfwO6 Ko4aOhsbcb9r855PugleoZDaVDdX9zKLUHk83TJ1304/UKl1SEUrurdEO6s9cX4JaE9uDj 4bXb/5AZCuuRqcriw9bwg4WuCff0atharLiZAae2rOpLAsvqze8R5NNXyF2IKig1wAdeFV fTrqIsnACHFMKtWgeW7/FGPsIJe9oQUJqvgiYfU6sVE+U21v3ilHOGb53OTuXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683157637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRxybakh23ZlMp6acf5v8QITUjCf1V5ZMX2gn+Yyixk=; b=kmGE9IQrEANBhCQWCBtnwIWjkUkZg/hvmOG4DtZ0xnLZDVAKroG9q005LjRyKBr26uRJTF AgY01A8hKXjbqnpoT4k2+6YlyQYH5Gg7U6hchtvo+zG2x4G2BH2J37xTQeTNphx+DbbduD QDykcmKnuqipXAY/cvUGCFRtivm5P2WLAsMCoHaO8jMjBlER2WV4FO2hz9xDSKFG4YmTkx WbqC2k81zd8p3K7k9pWxsoupc6wbgmJvPBeX3YXgzn/ZFIBApsvojcjXldp/meI0WEffG8 MKAQ+xEJkcveLoasNeCC/nbHWUEfJ8DRS3id37+k9xoV+BLyPmfObEM1auNGWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683157637; a=rsa-sha256; cv=none; b=tl58tKslnB9hmU9brwRJ1LPl2ORrX+haYsVP7RvAhW/g2+vTRJBy9r8VnTWalYyeHrQSQk BO9wvkbV4Ev2cPm8BrQGk6WQJAlElT6LK+0YjtWHJYGs35uXbJYNSpoW/JEVcnpUPyeD6W gYCQzb3VYU9syguE1vgZH54N3R7eWpSH6ylhYye8OyqxcRn3aZZ/05k87oabqUMHa8i+/C dyyAevc6V+Mw7Ktz3/UPRmup1ryUlFb61qjWKhDX+DeU2egrMwk5yCa3+0nHBqYXPN//LB dMYJOEXBl26knX/SLcYOKQDVBZihgiPhweG3Vv2kVEy3cW+TQXqRregu3iCMgQ== Received: from [IPV6:2601:648:8680:16b0:a5f2:2d0:1e3c:acb4] (unknown [IPv6:2601:648:8680:16b0:a5f2:2d0:1e3c:acb4]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QBYX44YxGzvht; Wed, 3 May 2023 23:47:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 3 May 2023 16:47:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 16/19] gdbserver: Clear upper ZMM registers in the right location. Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230427210113.45380-1-jhb@FreeBSD.org> <20230427210113.45380-17-jhb@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/3/23 10:49 AM, Simon Marchi wrote: > On 4/27/23 17:01, John Baldwin wrote: >> This was previously clearing the upper 32 bytes of ZMM0-15 rather than >> ZMM16-31. >> --- >> gdbserver/i387-fp.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdbserver/i387-fp.cc b/gdbserver/i387-fp.cc >> index e63eef60330..a122e2d860b 100644 >> --- a/gdbserver/i387-fp.cc >> +++ b/gdbserver/i387-fp.cc >> @@ -306,7 +306,7 @@ i387_cache_to_xsave (struct regcache *regcache, void *buf) >> if ((clear_bv & X86_XSTATE_ZMM)) >> { >> for (i = 0; i < num_avx512_zmmh_high_registers; i++) >> - memset (((char *) &fp->zmmh_low_space[0]) + 32 + i * 64, 0, 32); >> + memset (((char *) &fp->zmmh_high_space[0]) + 32 + i * 64, 0, 32); > > From what I understand, this is correct, so: > > Approved-By: Simon Marchi > > Unrelated to your patch, but I believe that zmmh_high_space should be > called zmm_high_space, since it doesn't contain only upper values like > zmmh_low_space does, it contains the full values for ZMM 16 through 31. Yeah, I think I do rename it to zmm_space () in patch 17. -- John Baldwin