From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Sporadic failures of selftest tests
Date: Tue, 17 Oct 2017 16:12:00 -0000 [thread overview]
Message-ID: <a12c30f1-58d0-6aec-700d-1737361344a9@redhat.com> (raw)
In-Reply-To: <30d4dc25-a59b-1196-3bc3-c8b982191ec0@redhat.com>
On 10/17/2017 04:54 PM, Pedro Alves wrote:
> Commit bf4692711232 ("Eliminate catch_errors") also did this:
>
> @@ -1145,7 +1142,15 @@ captured_main (void *data)
> change - SET_TOP_LEVEL() - has been eliminated. */
> while (1)
> {
> - catch_errors (captured_command_loop, 0, "", RETURN_MASK_ALL);
> + TRY
> + {
> + captured_command_loop ();
> + }
> + CATCH (ex, RETURN_MASK_ALL)
> + {
> + exception_print (gdb_stderr, ex);
> + }
> + END_CATCH
> }
>
> So most probably before that commit captured_command_loop
> wasn't inlined in captured main (unless LTO, maybe).
Probably the best fix would be to move away from selftest
entirely and convert them to unit tests instead.
Meanwhile, how about this as an easy fix? We could try
playing games with making functions extern, but maybe
that'd break again with LTO.
Seems to work for gdb.gdb/selftest.exp and gdb.gdb/complaints.exp
at least.
(I think we can use __attribute__ directly because
include/ansidecl.h defines it to empty on non-gcc or
older gccs.)
From: Pedro Alves <palves@redhat.com>
Date: 2017-10-17 15:04:11 +0100
prevent inlining captured_command_loop
---
gdb/main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gdb/main.c b/gdb/main.c
index beb8203..a60cd50 100644
--- a/gdb/main.c
+++ b/gdb/main.c
@@ -307,6 +307,11 @@ setup_alternate_signal_stack (void)
/* Call command_loop. */
+/* Prevent inlining this function for the benefit of gdb's selftests
+ in the testsuite. Those tests want to run GDB under GDB and stop
+ here. */
+static void captured_command_loop () __attribute__((noinline));
+
static void
captured_command_loop ()
{
next prev parent reply other threads:[~2017-10-17 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:00 Ulrich Weigand
2017-10-17 14:25 ` Pedro Alves
2017-10-17 14:34 ` Pedro Alves
2017-10-17 14:40 ` Pedro Alves
2017-10-17 14:55 ` Pedro Alves
2017-10-17 15:48 ` Ulrich Weigand
2017-10-17 15:54 ` Pedro Alves
2017-10-17 16:12 ` Pedro Alves [this message]
2017-10-20 12:51 ` Ulrich Weigand
2017-10-20 14:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a12c30f1-58d0-6aec-700d-1737361344a9@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).