Re: [PATCH 3/3] gdb/tui: cleanup includes

[Tom de Vries <tdevries@suse.de>]

On 6/9/24 16:14, Simon Marchi wrote:
> 
> 
> On 2024-06-08 06:14, Tom de Vries wrote:
>> On 6/3/24 16:57, Tom Tromey wrote:
>>>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>>>
>>> Simon> Remove includes reported as unused by clangd.  Then, add any includes
>>> Simon> necessary to get rid of errors (includes possibly relying on previous
>>> Simon> includes)..
>>>
>>> Simon> I didn't remove the includes of gdb-safe-ctypes.h, because it appears to
>>> Simon> do some some preprocessor magic, redefining standard macros.  I'm afraid
>>> Simon> that removing these includes could change the behavior unintentionally.
>>>
>>> It's never been super clear when gdb should use the libiberty stuff and
>>> when it should not.
>>>
>>> Approved-By: Tom Tromey <tom@tromey.com>
>>
>> This commit introduced a regression for me:
>> ...
>> Running /data/vries/gdb/src/gdb/testsuite/gdb.python/tui-window.exp ...
>> WARNING: timeout in accept_gdb_output
>> WARNING: timeout in accept_gdb_output
>> FAIL: gdb.python/tui-window.exp: Window was updated
>> ...
>>
>> Filed here (  https://sourceware.org/bugzilla/show_bug.cgi?id=31865 ) with gdb.log attached.
>>
>> Thanks,
>> - Tom
>>
> 
> Sorry, I messed up. See the patch here:
> 
> https://inbox.sourceware.org/gdb-patches/20240609141034.238889-1-simon.marchi@polymtl.ca/T/#u
> 
> I'm currently on leave and won't necessarily be near a computer all day, so if you think this
> patch is ok, feel free to push it on my behalf in order to fix the build as quickly as possible.
> 

Thanks for the quick fix, pushed.

- Tom