From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 3C53A3858C53 for ; Sat, 9 Dec 2023 10:01:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C53A3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C53A3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702116106; cv=none; b=PMC1b82Mw7NBbtU3TjeftDU1DP4g2FfjwigXLI95BULHtZsCUsL3z0vOs///2CfsQUDMb4O2KyQA4agm9q3i1fjHCPRkgpUaQ62Qvvr8r/QAKQrxq0Lp2G7+y8sPpFMmMX9J4Nnd/aB7RkxEuQ1Lm6SapRVr+230q1wU2q6dE8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702116106; c=relaxed/simple; bh=3E0SN5mDttFnLlCmY2Ucw7O1NNmQ0B18/5vpmgXMg6Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Y0Ab0SrTwbXFG+cR+KtsJZ6wV57E1is/FBWq0clbjwhyzyBLLlh96fujdr21vC3pgkvlK5VqvhebjkH/Y5fIUqvpcCF4ybRs3G2Uc8ab5UoPag6JM2xIGDgOf6dLIW4L3alxgnTf0DLbWFfwmGNXsuf24WXaaQy+Imyvj+OwqXo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 180DD2216B; Sat, 9 Dec 2023 10:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702116101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vL0XVhe4qjJTXXF8BlmRVXpfeiyN2RH0HYkER5fuH2k=; b=pF7N0oH635tb6ZNeUiM1+r5bqzUgfxNuDidMiZqKLAxkYD2Az+rSdMQugfbaYQSI2Em1qZ GcL3RMcyWk2tL7Paa3N06cTzeegPGLrCUEOcG6DpZG1LHYYo5Z0jDibzswKFvwlcEOOQ0+ sLZ1woysFZETSMql0eQn4aBrUlDC9hw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702116101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vL0XVhe4qjJTXXF8BlmRVXpfeiyN2RH0HYkER5fuH2k=; b=o4NHua+FZuC5ives0DryQ+8McN+SQVxYeiMt6Favip8pH9zLcQntn/Dfp76kuz8IrEkaLI FBnCq+5KdmIpYhDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702116101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vL0XVhe4qjJTXXF8BlmRVXpfeiyN2RH0HYkER5fuH2k=; b=pF7N0oH635tb6ZNeUiM1+r5bqzUgfxNuDidMiZqKLAxkYD2Az+rSdMQugfbaYQSI2Em1qZ GcL3RMcyWk2tL7Paa3N06cTzeegPGLrCUEOcG6DpZG1LHYYo5Z0jDibzswKFvwlcEOOQ0+ sLZ1woysFZETSMql0eQn4aBrUlDC9hw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702116101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vL0XVhe4qjJTXXF8BlmRVXpfeiyN2RH0HYkER5fuH2k=; b=o4NHua+FZuC5ives0DryQ+8McN+SQVxYeiMt6Favip8pH9zLcQntn/Dfp76kuz8IrEkaLI FBnCq+5KdmIpYhDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F2C8A13282; Sat, 9 Dec 2023 10:01:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LDXXOQQ7dGVTEAAAD6G6ig (envelope-from ); Sat, 09 Dec 2023 10:01:40 +0000 Content-Type: multipart/mixed; boundary="------------pVWlMWCmmWq0YZvz04mB5wG4" Message-ID: Date: Sat, 9 Dec 2023 11:01:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231126075250.31557-1-tdevries@suse.de> <87y1e4hfvv.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87y1e4hfvv.fsf@tromey.com> X-Spam-Level: ********** X-Spam-Score: 10.90 X-Spamd-Result: default: False [-14.40 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; HAS_ATTACHMENT(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; MIME_BASE64_TEXT_BOGUS(1.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MIME_BASE64_TEXT(0.10)[]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DMARC_POLICY_ALLOW(0.00)[suse.de,none]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; WHITELIST_DMARC(-7.00)[suse.de:D:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Rspamd-Server: rspamd1 X-Spam-Level: X-Rspamd-Queue-Id: 180DD2216B X-Spam-Score: -14.40 Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pF7N0oH6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o4NHua+F; spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------pVWlMWCmmWq0YZvz04mB5wG4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/8/23 16:29, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> void > Tom> tui_data_window::rerender () > Tom> { > Tom> + /* Calling check_register_value calls rerender again. We use this counter > Tom> + to prevent enless recursion. */ > Tom> + static int in_rerender; > > There's a typo, the function is check_register_values (missing an "s" in > the comment). > > However, it seems bad to need new state for this. > How about this approach? Rather than adding global state, it adds a function parameter. It's currently called toplevel, though I've also consider "active". Another solution is to split out the functionality between two functions, I didn't pursue this because I couldn't think of good names (I came up with rerender and rerender_1). Thanks, - Tom --------------pVWlMWCmmWq0YZvz04mB5wG4 Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-gdb-tui-Show-regs-when-switching-to-regs-layout.patch" Content-Disposition: attachment; filename*0="v2-0001-gdb-tui-Show-regs-when-switching-to-regs-layout.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSA5NTkwMzY0ZjlkZmZjMGZiYjI5ZjAwNjkwYmFlM2RmOGIyYzkyY2YzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFN1biwgMjYgTm92IDIwMjMgMDg6NDk6MjggKzAxMDAKU3ViamVjdDogW1BBVENI IHYyXSBbZ2RiL3R1aV0gU2hvdyByZWdzIHdoZW4gc3dpdGNoaW5nIHRvIHJlZ3MgbGF5b3V0 CgpXaGVuIHN0YXJ0aW5nIGdkYiBpbiBDTEkgbW9kZSwgcnVubmluZyB0byBtYWluIGFuZCBz d2l0Y2hpbmcgaW50byB0aGUgVFVJIHJlZ3MKbGF5b3V0OgouLi4KJCBnZGIgLXEgYS5vdXQg LWV4IHN0YXJ0IC1leCAibGF5b3V0IHJlZ3MiCi4uLgp3ZSBnZXQ6Ci4uLgorLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKwp8ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfAp8IFsgUmVnaXN0ZXIgVmFsdWVzIFVuYXZhaWxhYmxlIF0gfAp8ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfAorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tKwouLi4KCkZpeCB0aGlzIGJ5IGhhbmRsaW5nIHRoaXMgY2FzZSBpbiB0dWlfZGF0 YV93aW5kb3c6OnJlcmVuZGVyLgoKVGVzdGVkIG9uIHg4Nl82NC1saW51eC4KClBSIHR1aS8y ODYwMApCdWc6IGh0dHBzOi8vc291cmNld2FyZS5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dp P2lkPTI4NjAwCi0tLQogZ2RiL3Rlc3RzdWl0ZS9nZGIudHVpL3JlZ3MuZXhwIHwgMTAgKysr KysrLS0tLQogZ2RiL3R1aS90dWktcmVncy5jICAgICAgICAgICAgIHwgMTQgKysrKysrKysr KystLS0KIGdkYi90dWkvdHVpLXJlZ3MuaCAgICAgICAgICAgICB8ICA2ICsrKysrLQogMyBm aWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLnR1aS9yZWdzLmV4cCBiL2dkYi90ZXN0c3VpdGUv Z2RiLnR1aS9yZWdzLmV4cAppbmRleCA1MjBmNmRkYmE5Ni4uMGJlOTk2MjViOWYgMTAwNjQ0 Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnR1aS9yZWdzLmV4cAorKysgYi9nZGIvdGVzdHN1 aXRlL2dkYi50dWkvcmVncy5leHAKQEAgLTQxLDEwICs0MSwxMiBAQCBUZXJtOjpjb21tYW5k ICJsYXlvdXQgcmVncyIKIFRlcm06OmNoZWNrX2JveCAicmVnaXN0ZXIgYm94IiAwIDAgODAg OAogVGVybTo6Y2hlY2tfYm94ICJzb3VyY2UgYm94IGluIHJlZ3MgbGF5b3V0IiAwIDcgODAg OAogCi1zZXQgdGV4dCBbVGVybTo6Z2V0X2xpbmUgMV0KLSMgSnVzdCBjaGVjayBmb3IgYW55 IHJlZ2lzdGVyIHdpbmRvdyBjb250ZW50IGF0IGFsbC4KLVRlcm06OmNoZWNrX2NvbnRlbnRz ICJhbnkgcmVnaXN0ZXIgY29udGVudHMiICJcXHwuKlxbXiBcXS4qXFx8IgotCisjIFRoZSBj dXJyZW50IGZyYW1lIGlzIG1haW4sIGNoZWNrIHRoYXQgcmVnaXN0ZXJzIGFyZSBhdmFpbGFi bGUuCitzZXQgcmVfcmVnX3ZhbHNfdW5hdmFpbGFibGUgXAorICAgIFtzdHJpbmdfdG9fcmVn ZXhwIHtbIFJlZ2lzdGVyIFZhbHVlcyBVbmF2YWlsYWJsZSBdfV0KK2dkYl9hc3NlcnQgXAor ICAgIHsgIVtUZXJtOjpjaGVja19yZWdpb25fY29udGVudHNfcCAwIDAgODAgOCAkcmVfcmVn X3ZhbHNfdW5hdmFpbGFibGVdIH0gXAorICAgICJSZWdpc3RlciB2YWx1ZXMgYXZhaWxhYmxl IgogCiAjIENoZWNrIHRoYXQgd2UgY2FuIHN1Y2Nlc3NmdWxseSBjYXVzZSB0aGUgcmVnaXN0 ZXIgd2luZG93IHRvIGFwcGVhcgogIyB1c2luZyB0aGUgJ3R1aSByZWcgbmV4dCcgYW5kICd0 dWkgcmVnIHByZXYnIGNvbW1hbmRzLgpkaWZmIC0tZ2l0IGEvZ2RiL3R1aS90dWktcmVncy5j IGIvZ2RiL3R1aS90dWktcmVncy5jCmluZGV4IDRjNmVhOGFmZjBkLi5kYTJjOWEyNjk5NSAx MDA2NDQKLS0tIGEvZ2RiL3R1aS90dWktcmVncy5jCisrKyBiL2dkYi90dWkvdHVpLXJlZ3Mu YwpAQCAtMTkyLDcgKzE5Miw3IEBAIHR1aV9kYXRhX3dpbmRvdzo6c2hvd19yZWdpc3RlcnMg KGNvbnN0IHJlZ2dyb3VwICpncm91cCkKICAgICAgIG1fcmVnc19jb250ZW50LmNsZWFyICgp OwogICAgIH0KIAotICByZXJlbmRlciAoKTsKKyAgcmVyZW5kZXIgKGZhbHNlKTsKIH0KIAog CkBAIC00MTUsMTAgKzQxNSwxOCBAQCB0dWlfZGF0YV93aW5kb3c6OmVyYXNlX2RhdGFfY29u dGVudCAoY29uc3QgY2hhciAqcHJvbXB0KQogLyogU2VlIHR1aS1yZWdzLmguICAqLwogCiB2 b2lkCi10dWlfZGF0YV93aW5kb3c6OnJlcmVuZGVyICgpCit0dWlfZGF0YV93aW5kb3c6OnJl cmVuZGVyIChib29sIHRvcGxldmVsKQogewogICBpZiAobV9yZWdzX2NvbnRlbnQuZW1wdHkg KCkpCi0gICAgZXJhc2VfZGF0YV9jb250ZW50IChfKCJbIFJlZ2lzdGVyIFZhbHVlcyBVbmF2 YWlsYWJsZSBdIikpOworICAgIHsKKyAgICAgIGlmICh0b3BsZXZlbCAmJiBoYXNfc3RhY2tf ZnJhbWVzICgpKQorCXsKKwkgIGZyYW1lX2luZm9fcHRyIGZpID0gZ2V0X3NlbGVjdGVkX2Zy YW1lIChOVUxMKTsKKwkgIGNoZWNrX3JlZ2lzdGVyX3ZhbHVlcyAoZmkpOworCX0KKyAgICAg IGVsc2UKKwllcmFzZV9kYXRhX2NvbnRlbnQgKF8oIlsgUmVnaXN0ZXIgVmFsdWVzIFVuYXZh aWxhYmxlIF0iKSk7CisgICAgfQogICBlbHNlCiAgICAgewogICAgICAgZXJhc2VfZGF0YV9j b250ZW50IChOVUxMKTsKZGlmZiAtLWdpdCBhL2dkYi90dWkvdHVpLXJlZ3MuaCBiL2dkYi90 dWkvdHVpLXJlZ3MuaAppbmRleCA1YWRmZjYzMDBhYS4uMWFiZDIyY2QzODIgMTAwNjQ0Ci0t LSBhL2dkYi90dWkvdHVpLXJlZ3MuaAorKysgYi9nZGIvdHVpL3R1aS1yZWdzLmgKQEAgLTc1 LDcgKzc1LDExIEBAIHN0cnVjdCB0dWlfZGF0YV93aW5kb3cgOiBwdWJsaWMgdHVpX3dpbl9p bmZvCiAgIHsKICAgfQogCi0gIHZvaWQgcmVyZW5kZXIgKCkgb3ZlcnJpZGU7CisgIHZvaWQg cmVyZW5kZXIgKGJvb2wgdG9wbGV2ZWwpOworICB2b2lkIHJlcmVuZGVyICgpIG92ZXJyaWRl CisgIHsKKyAgICByZXJlbmRlciAodHJ1ZSk7CisgIH0KIAogcHJpdmF0ZToKIAoKYmFzZS1j b21taXQ6IDEzNDAwNzJhNTQxMjg3N2Q5ZDk4ZjViMDEwY2Q4ZTZlOWU0MTg5MDUKLS0gCjIu MzUuMwoK --------------pVWlMWCmmWq0YZvz04mB5wG4--