From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 1282C3858C56
 for <gdb-patches@sourceware.org>; Thu, 21 Jul 2022 15:26:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1282C3858C56
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id BB95F1E13B;
 Thu, 21 Jul 2022 11:26:12 -0400 (EDT)
Message-ID: <a205a501-cadc-8820-b935-21cf8561ef71@simark.ca>
Date: Thu, 21 Jul 2022 11:26:12 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 17/29] Implement GDB_TO_EXIT support for native Linux
Content-Language: en-US
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
References: <20220713222433.374898-1-pedro@palves.net>
 <20220713222433.374898-18-pedro@palves.net>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <20220713222433.374898-18-pedro@palves.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2022 15:26:14 -0000


> @@ -1900,7 +1914,7 @@ linux_nat_target::follow_clone (ptid_t child_ptid)
>      {
>        new_lp->status = 0;
>  
> -      if (report_thread_events)
> +      if (report_exit_events_for (new_lp))
>  	new_lp->waitstatus.set_thread_created ();

This looks weird:

  if (report exit events)
    report a thread created event

Should it really be changed?

Simon