From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 7CC2A3840C31 for ; Tue, 26 May 2020 20:52:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CC2A3840C31 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-4bqotezjNs-ISwl_91ANsg-1; Tue, 26 May 2020 16:52:08 -0400 X-MC-Unique: 4bqotezjNs-ISwl_91ANsg-1 Received: by mail-wr1-f72.google.com with SMTP id s7so3767232wrm.16 for ; Tue, 26 May 2020 13:52:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bEjSNmC+HnBKdqcJVBM3P3InVwIVpvh0Q3UOSHgAFBU=; b=s6fayf6CLNVytAzZBdLMi3tKimZKYbQmKaexYp1kKDVVNDFUCs4LL+VoAyZSx7Xrhh y96fOrkj4rLm/+nDgyYMKPWwzMykp6G+7KmrLUE6/5W7zIrPGcSJhWc4JyzHDhRdzz3k v5tpGmrzQ5DCqFgKkcUn4ztXCh5lriZWVdFW+jzUj8UlP485HMlUqkCVKkwBFyAFhraB 3Yk2pjC24wlBWKFwKp9wZey+eX+/kgcnO3lUmk5V2CY9pNHdQ8I8nbyQJcKIGd/wjxHQ /QCfM2NjMTyXqVmojztyJO3ltyRbTGUp4N57XbNCE/lJHQgB01aZIgkKTgxXApHBdUjU Kqjw== X-Gm-Message-State: AOAM531LcECgqFQY3YLyijmRU1UCcLqshjG6XkYSP/Io8MesPb4K2BUn 3tAWSsXmFXq4tPTxLb70mrfcLvN8IVpOtmatTJM0KGjjCgB+OHwtb7Sx+bCjhu6Nt76pSQ1HkmA p2JMlsUY80miUk/E1rT9Ddg== X-Received: by 2002:a7b:c5cc:: with SMTP id n12mr927784wmk.69.1590526326962; Tue, 26 May 2020 13:52:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykTREAsFQxiqW9H2ZEOi3AWQyHtCq11WESyj5k/qbeSQ9LFhAJOv7NFIsZFtTzyWo+bGTDiA== X-Received: by 2002:a7b:c5cc:: with SMTP id n12mr927778wmk.69.1590526326795; Tue, 26 May 2020 13:52:06 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r2sm972788wrg.68.2020.05.26.13.52.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 13:52:05 -0700 (PDT) Subject: Re: [PATCH,v3 testsuite] Fix some duplicate test names To: Luis Machado , gdb-patches@sourceware.org References: <20200526141848.22771-1-luis.machado@linaro.org> <20200526190224.755-1-luis.machado@linaro.org> <935ac55c-e195-0aa7-c8ed-63e77f8f9c96@redhat.com> From: Pedro Alves Message-ID: Date: Tue, 26 May 2020 21:52:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 20:52:11 -0000 On 5/26/20 9:23 PM, Luis Machado wrote: > On 5/26/20 4:35 PM, Pedro Alves wrote: >> On 5/26/20 8:02 PM, Luis Machado via Gdb-patches wrote: >> >>> @@ -45,10 +45,10 @@ proc break_at { breakpoint where } { >>>         set test "break $breakpoint" >>>       set bp 0 >>> -    gdb_test_multiple "$test" "$test" { >>> +    gdb_test_multiple "$test" "$test inserted as number $bp" { >> >> As discussed, this change should be backed out, and replaced with >> with_test_prefix, right?  $bp is always zero here. > > Ugh... EWRONGPATCH, apologies. I must have mixed up the files when sending. This was already fixed. > > Follows the updated one (for sure). OK. Thanks, Pedro Alves