From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility
Date: Wed, 18 Oct 2017 10:21:00 -0000 [thread overview]
Message-ID: <a2204dfb-8b51-1b35-d25f-ab92a522be73@redhat.com> (raw)
In-Reply-To: <1508276312-7910-1-git-send-email-keiths@redhat.com>
On 10/17/2017 10:38 PM, Keith Seitz wrote:
> A previous patch called gdb_assert_not_reached whenever reading
> the accessibility of a nested typedef definition. Wisely, Pedro has asked me
> not do this.
>
> This patch changes the previous one so that it issues a complaint instead.
>
> gdb/ChangeLog:
>
> * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled
> DW_AT_accessibility.
OK.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-10-18 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 19:18 [PATCH] Record and output access specifiers for nested typedefs Keith Seitz
2017-10-16 19:57 ` Simon Marchi
2017-10-16 21:32 ` Keith Seitz
2017-10-16 21:40 ` Simon Marchi
2017-10-17 0:56 ` Keith Seitz
2017-10-17 1:05 ` Pedro Alves
2017-10-17 21:38 ` [PATCH] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility Keith Seitz
2017-10-18 10:21 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2204dfb-8b51-1b35-d25f-ab92a522be73@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).