From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E03973858D20 for ; Thu, 25 Apr 2024 17:34:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E03973858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E03973858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714066478; cv=none; b=q2TSqxSZFvjdm/WYIlFLrrslzBsfyQfIiYBw7xXktWLhBxrcuykX+q6/o7uzf6fFL679bTWNKpiel89z8M6rhAixiuyHBLvRO2Rb2R3ZxWk56+W5kTLHGjFg+CqSX43S1O4PxtVFc4wZLC8cj/fNB8AnBY5lJI6QjeVXAK/U9go= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714066478; c=relaxed/simple; bh=RpneUegf5yLHMDz+GgHVFzTQ4Yre7XNWh74Jp1ep2U4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GlbIHapUvqaBbKU82SAcygscnymXnHSoJNXBmAQyn2JzkV8wGFKQNQZrYaF5LAyQ66GUC4gKD54vexBrmvckRzxp650xUT92Q+UXsvYPvXy9zgDjxzBp/olNthhQcmQJLTiFvX2fKbypVfjYDMnTPPsAb918VCk0rqNepSYxUuI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43PGlbBP026931; Thu, 25 Apr 2024 17:05:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=KB0AqqOYHsSJ69LQAnJMuIUVZp/iL3q4Irwrr8TkFBw=; b=rNbJAHr+vtAjQY15isHaz/0Q7zAjUjYnrya7ya7G1qSiG8ReUS8UxjyxZMBPMH1WoiZf AUjPIi8IQvZddn6klRNzmL519kOOTElEq85TMJeuHnI8tnKA5L1xU5Hk9eCYSM8HuFCg cuOCu/gVsJ6+BCurK/x2kiTyDT0O9g+qwwkIefsTDCUIFdu4qnvuTiBruWXioEkJ4bkm pSJ9LxpfmnDXkOZZdfRbWRccXhioONP8UhQQr2m0QBlEJ1AL5+7p7yHUMzCkaAdMYhQ3 BpHH1IcSKY/Agj6X4pmDQLnrRBcoFR43GmbxDmDJ8T83V93o871+WkbnygNkNCl64jav Ag== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xqu0er1j7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 17:05:40 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43PFoLIJ023068; Thu, 25 Apr 2024 17:05:39 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xms1pawhh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 17:05:39 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43PH5a1Y25166474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 17:05:38 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B2F358045; Thu, 25 Apr 2024 17:05:36 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6C8558061; Thu, 25 Apr 2024 17:05:35 +0000 (GMT) Received: from [9.67.133.93] (unknown [9.67.133.93]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 25 Apr 2024 17:05:35 +0000 (GMT) Message-ID: Date: Thu, 25 Apr 2024 10:05:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] [gdb/testsuite] Fix end_sequence addresses Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org, Carl Love References: <20240408120445.12544-1-tdevries@suse.de> <20240408120445.12544-3-tdevries@suse.de> <7d515dd6-f327-4587-89c6-ed7e93b7efdd@linux.ibm.com> <8032f800-235f-4181-a84e-2f2fb2a086b7@linux.ibm.com> <64b0e2d7-666d-4435-929e-07fcf3bd9cdb@suse.de> From: Carl Love In-Reply-To: <64b0e2d7-666d-4435-929e-07fcf3bd9cdb@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _9PTfBqfi5XeSyyvTDA7yfRBmvB_TSjj X-Proofpoint-GUID: _9PTfBqfi5XeSyyvTDA7yfRBmvB_TSjj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_17,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404250124 X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_ASCII_DIVIDERS,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: Thanks for verifying the patch on X86. I agree, including the entire commit message from your patch is a little overkill. I cut down your commit message and made the description of my fix a little better. Here is what I now have for the commit message: ------------------------------------------------------ Fix end_sequence addresses for dw2-lines.exp The patch: From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 17 Apr 2024 12:55:00 +0200 Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main: ... 00000000004102c4 : 4102c4: 52800000 mov w0, #0x0 // #0 4102c8: 9100c3ff add sp, sp, #0x30 4102cc: d65f03c0 ret ... is not described by the line table: ... The regression failure on PowerPC is due to the change in file dw2-lines.exp, - DW_LNE_set_address bar_label_5 + DW_LNE_set_address "$main_start + $main_len" The label bar_label_5 is in function bar, not function main. The new set address should have been $bar_start + $bar_len. -------------------------------------------------------- Please let me know if that looks reasonable and I will then commit the fix. Thanks! Carl On 4/24/24 14:07, Tom de Vries wrote: > On 4/24/24 20:28, Carl Love wrote: >> >> Tom: >> >> The following patch fixes the issue for me on PowerPC.  Please let me know if it looks ok and if the patch works on your systems as well.  Thanks. >> >>                          Carl > > Hi Carl, > > I don't see the FAILs you mentioned, but your patch is correct, and doesn't regress the test-case for me on x86_64-linux. > > Thanks for finding, reporting and fixing this. > > So, approved, but consider making the commit message shorter. Including the entire commit message of the patch you're fixing is a bit of an overkill. > > Approved-By: Tom de Vries > > Thanks, > - Tom > >> >> ---------------------------------------------------------------------- >> >> Fix end_sequence addresses for dw2-lines.exp >> >> The patch: >> >>    From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001 >>    From: Tom de Vries >>    Date: Wed, 17 Apr 2024 12:55:00 +0200 >>    Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses >> >>    I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main: >>    ... >>    00000000004102c4 : >>      4102c4:       52800000        mov     w0, #0x0                        // #0 >>     4102c8:       9100c3ff        add     sp, sp, #0x30 >>      4102cc:       d65f03c0        ret >>    ... >>    is not described by the line table: >>    ... >>    File name                    Line number    Starting address    View    Stmt >>      ... >>    map-to-same-line.c                    54            0x4102ac               x >>    map-to-same-line.c                     -            0x4102c4 >>    ... >> >>    Fix this by ending the line table at $main_end. >> >>    Likewise in a few other test-cases, found using: >>    ... >>    $ find gdb/testsuite/ -type f \ >>      | xargs grep -B1 DW_LNE_end_sequence \ >>      | grep set_address \ >>      | egrep -v "_end|_len" >>    ... >> >>    Tested on aarch64-linux. >>    --- >>     gdb/testsuite/gdb.dwarf2/dw2-gas-workaround.exp         | 2 +- >>     gdb/testsuite/gdb.dwarf2/dw2-inline-header-1.exp        | 2 +- >>     gdb/testsuite/gdb.dwarf2/dw2-inline-header-2.exp        | 2 +- >>     gdb/testsuite/gdb.dwarf2/dw2-inline-header-3.exp        | 2 +- >>     gdb/testsuite/gdb.dwarf2/dw2-line-number-zero.exp       | 7 +++++-- >>     gdb/testsuite/gdb.dwarf2/dw2-lines.exp                  | 2 +- >>     gdb/testsuite/gdb.dwarf2/dw2-vendor-extended-opcode.exp | 4 +++- >>     gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp.tcl       | 2 +- >>     gdb/testsuite/gdb.reverse/map-to-same-line.c            | 1 - >>     gdb/testsuite/gdb.reverse/map-to-same-line.exp          | 3 ++- >>     10 files changed, 16 insertions(+), 11 deletions(-) >> >> The issue in file dw2-lines.exp is the change >> >> >> -               DW_LNE_set_address bar_label_5 >> +               DW_LNE_set_address "$main_start + $main_len" >> >> The label bar_label_5 is in function bar, not function  main.  The new >> set address should have been $bar_start + $bar_len. >> --- >>   gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp >> index 85d5e9c8afb..af5b6b71768 100644 >> --- a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp >> +++ b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp >> @@ -104,7 +104,7 @@ proc test_1 { _cv _cdw64 _lv _ldw64 {_string_form ""}} { >>           line [line_for bar_label_4] >>           DW_LNS_copy >>   -        DW_LNE_set_address "$main_start + $main_len" >> +        DW_LNE_set_address "$bar_start + $bar_len" >>           DW_LNE_end_sequence >>           } >>       } >