From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Make linux_nat_detach/thread_db_detach use the inferior parameter
Date: Thu, 18 Jan 2018 17:06:00 -0000 [thread overview]
Message-ID: <a2399e61-6e14-8ab4-a9c0-ff760fdbd360@redhat.com> (raw)
In-Reply-To: <1514699454-18587-3-git-send-email-simon.marchi@ericsson.com>
On 12/31/2017 05:50 AM, Simon Marchi wrote:
> This patch makes these two functions actually use the inferior parameter
> added by the previous patch, instead of reading inferior_ptid. I chose
> these two, because they are the one actually used when I detach on my
> GNU/Linux system, so they were easy to test.
>
> I took the opportunity to pass the inferior being detached to
> inf_ptrace_detach_success, so it could use it too. From there, it made
> sense to add an overload of detach_inferior that takes the inferior
> directly rather than the pid, to avoid having to pass inf->pid only for
> the callee to look up the inferior structure by pid.
Looks fine to me.
(FWIW, the 'detach_inferior(int)' overload disappears in
my multi-target branch).
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-01-18 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 5:56 [PATCH 1/3] Remove args from target detach Simon Marchi
2017-12-31 5:58 ` [PATCH 2/3] Pass inferior down to target_detach and to_detach Simon Marchi
2018-01-18 16:41 ` Pedro Alves
2018-01-19 3:17 ` Simon Marchi
2017-12-31 6:01 ` [PATCH 3/3] Make linux_nat_detach/thread_db_detach use the inferior parameter Simon Marchi
2018-01-18 17:06 ` Pedro Alves [this message]
2018-01-19 3:26 ` Simon Marchi
2018-01-18 15:57 ` [PATCH 1/3] Remove args from target detach Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2399e61-6e14-8ab4-a9c0-ff760fdbd360@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).