From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 00C5A3858C2D for ; Thu, 3 Nov 2022 13:09:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00C5A3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667480940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SzV65q7go3/PDUToNw0jHDjBm9d4/Hh6Bb9D7NGgrE0=; b=EqJsePhwmTnJH/9kPa0nu/28FCLf/TDpJatmkxbCLiVDRLMOddIYV18dNSgWrMyaIift8E 2J2M1qjo851g8KX9JIcwlXhyWVnE6Vvo73S4xz4pIdXhGEN59jSi2q8jmZ7KrPtBh6T3/A vz+NnE0eRV5IXLPNL2XxzzEJCYoTRmw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-596-56GY7u55MxOIYZTfORZXYA-1; Thu, 03 Nov 2022 09:08:59 -0400 X-MC-Unique: 56GY7u55MxOIYZTfORZXYA-1 Received: by mail-wr1-f71.google.com with SMTP id s7-20020adfa287000000b00236c367fcddso468995wra.6 for ; Thu, 03 Nov 2022 06:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SzV65q7go3/PDUToNw0jHDjBm9d4/Hh6Bb9D7NGgrE0=; b=g+EiU2F3XQYyydnMiAwcjxSYfw4zGEzpxYbfXrLPwczb+UEWhBLjf+/PVMkAO2nulk rx/pnX9Y329cMWeRcp8zJtEFGdnt0PWfresCt8OBK2/Tlp3hW7feTKG1mZOL1733/MV7 Iw+VwjsY+MwIeNoHW4jLTeMLN9HcGQnDsdt/SGKfJae4s3ilF5fo7NO56xb9IoUiEE56 70hcKN0Dhg8Yz6lGWc3YKKEjrmQBczIdoDHM1g44w3ILCoRTXJH3FXsNRsaFr30J/GVg k49kjl+dVSSymVCIEgjozKnKybrf4yZN+ubHUTECJYul3aci2Lu5bxoyaLcwq5px53oh QUog== X-Gm-Message-State: ACrzQf1fPoxUaW44IoMdF+5+CyN23W1sfK74m6Bdx1eH9NEsXEqHFYpW nvWgX1S7WjiboebMozcxSg6CUtCgQUkTxjKgfFbDLlMBiKXlgBWxGPqEbh92HDk5iMspkCCKI/q WrwG8a8OrZpqzNJwvLDY9jA== X-Received: by 2002:a5d:5a99:0:b0:236:7751:4e43 with SMTP id bp25-20020a5d5a99000000b0023677514e43mr18389113wrb.241.1667480937836; Thu, 03 Nov 2022 06:08:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7C/ebBrj69HIzzbSU4Ad7EHGpQfJuAebkqQmBTqHMNgf5dr6mNI/xYYTMzimx/gzOa5eiiRA== X-Received: by 2002:a5d:5a99:0:b0:236:7751:4e43 with SMTP id bp25-20020a5d5a99000000b0023677514e43mr18389070wrb.241.1667480937352; Thu, 03 Nov 2022 06:08:57 -0700 (PDT) Received: from [10.202.9.92] (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id t18-20020a05600c199200b003b3307fb98fsm1411171wmq.24.2022.11.03.06.08.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 06:08:56 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 14:08:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3] gdb: Fix issue with Clang CLI macros To: Simon Marchi , gdb-patches@sourceware.org References: <20221018132215.2593111-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/11/2022 14:07, Simon Marchi wrote: > > On 11/3/22 08:58, Bruno Larsen via Gdb-patches wrote: >> On 02/11/2022 13:36, Simon Marchi wrote: >>>> +# Clang has this bug where it puts the macros defined on the command-line >>>> +# after the main file portion (see PR 29034) and: >>> I'm not sure if the "and" a the end is supposed to be there or not, it >>> reads weird. >> Oops, it was supposed to be inside the parenthesis, making it >> >> (see PR 29034 and https://github.com/llvm/llvm-project/issues/54506) >> >> >> Is it fine if I keep it like that? > Sure. Thanks, pushed :) Cheers, Bruno > > Simon >