From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix crash in quirk_rust_enum
Date: Tue, 17 Apr 2018 16:10:00 -0000 [thread overview]
Message-ID: <a2d311fe-76d0-a2ed-1ab5-f2fc235d7a7b@redhat.com> (raw)
In-Reply-To: <20180329175126.30863-1-tom@tromey.com>
On 03/29/2018 06:51 PM, Tom Tromey wrote:
> I noticed that quirk_rust_enum can crash when presented with a union
> whose fields are all scalar types.
>
> This patch adds a new test case and fixes the bug.
>
> Regression tested on Fedora 26 x86-64.
Even though the code your touching is in dwarf2read.c, it is
Rust-only code, so IMHO you should be able to self-approve it.
I have nothing really useful to say about the change.
Mechanically, looks fine to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-04-17 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 17:51 Tom Tromey
2018-04-17 16:10 ` Pedro Alves [this message]
2018-04-17 19:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2d311fe-76d0-a2ed-1ab5-f2fc235d7a7b@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).