From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125610 invoked by alias); 17 Apr 2018 16:10:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125599 invoked by uid 89); 17 Apr 2018 16:10:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=HTo:U*tom X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Apr 2018 16:10:36 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C6788182D1C; Tue, 17 Apr 2018 16:10:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 529AF2166BAE; Tue, 17 Apr 2018 16:10:33 +0000 (UTC) Subject: Re: [RFA] Fix crash in quirk_rust_enum To: Tom Tromey , gdb-patches@sourceware.org References: <20180329175126.30863-1-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 17 Apr 2018 16:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180329175126.30863-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00340.txt.bz2 On 03/29/2018 06:51 PM, Tom Tromey wrote: > I noticed that quirk_rust_enum can crash when presented with a union > whose fields are all scalar types. > > This patch adds a new test case and fixes the bug. > > Regression tested on Fedora 26 x86-64. Even though the code your touching is in dwarf2read.c, it is Rust-only code, so IMHO you should be able to self-approve it. I have nothing really useful to say about the change. Mechanically, looks fine to me. Thanks, Pedro Alves