From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85172 invoked by alias); 11 Oct 2017 16:24:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84978 invoked by uid 89); 11 Oct 2017 16:24:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=catching, informed X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 16:24:33 +0000 Received: by mail-wm0-f44.google.com with SMTP id q124so6297661wmb.0 for ; Wed, 11 Oct 2017 09:24:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KM5XrbFpEm/ZCxtxUYOfYUISSezsTu1ri6KhrmJ4ToM=; b=kmYNg3ngOszuIWyA/jntlV6j0LtRuk+UHHRrTeb9GPDxGR1cQRKJD7ajQ//iVUalSb LnaUS8OrO+VqlrW8f4TsldgYBslLyOfovHWbHwHfDlM5fx1qHNRJddul2AAipZfoiftL tCQoRhgFce/62TZA/WlZjfTzFabsoueH94IizZeHvikTzbu2KpS0OT1teFSISSlvsVl0 dP/z4qnBeUhx4PtjugvFQqsjqmO/dPZanTZwAgk2iQzswVoayOpgMMcvZ7J1SylsphtP OLCg7XFRKgIJ3LSQxGPxmG5OK0nzhMJSsr+UI2+rtuHA9YJI0I8RJN7d8UnkXanfcy5J sXzQ== X-Gm-Message-State: AMCzsaUHQezdpKCE0AIqPPFo5nQXcQX1YhfKHqxN9ySjaWyvZ1zSzI2j WpbVf50Cc+2A95prG81SJW6weH8+rgs= X-Google-Smtp-Source: AOwi7QD/Kkzo7RNzTzyMS3hfH8VjxQoEqRvUmxi/sZaPQ8gGndWNX8lp2swtqX8WWNU3LJ1RVv6msA== X-Received: by 10.223.139.82 with SMTP id v18mr162188wra.55.1507739070726; Wed, 11 Oct 2017 09:24:30 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id f89sm21727983wmh.18.2017.10.11.09.24.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 09:24:29 -0700 (PDT) Subject: Re: [python][patch] Python rbreak To: Kevin Buettner , gdb-patches@sourceware.org References: <20171011091939.7d5931c8@pinnacle.lan> From: Phil Muldoon Message-ID: Date: Wed, 11 Oct 2017 16:24:00 -0000 MIME-Version: 1.0 In-Reply-To: <20171011091939.7d5931c8@pinnacle.lan> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00300.txt.bz2 On 11/10/17 17:19, Kevin Buettner wrote: > On Wed, 11 Oct 2017 12:30:17 +0100 > Phil Muldoon wrote: > >> So, instead, I've made the Python rbreak functionality a little more >> tuneable than the console command equivalent. The first tuneable is to >> allow the user to exclude mini symbols from the pattern matching. A > > [...] > >> gdb.rbreak ("", minisyms=False) > > While reading through your preamble, I noticed some terminology with > which I was unfamiliar: "mini symbols" and "minisyms". > > In a private discussion, you informed me that you actually meant > "minimal symbols" and "minsyms", which cleared things up for me. > > But, you also asked me to remind you about this via a public reply, so > here it is... :) > > Kevin Kevin, Thanks for catching the inconsistency in terminology! I'll clear it up and post it in the version 2 of the patch. I'll won't repost for now to see if other reviewers have other changes to request. Cheers Phil