From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49972 invoked by alias); 21 Mar 2019 16:12:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49957 invoked by uid 89); 21 Mar 2019 16:12:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 16:12:30 +0000 Received: by mail-wr1-f67.google.com with SMTP id t5so7239611wri.7 for ; Thu, 21 Mar 2019 09:12:30 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id j184sm9715454wma.47.2019.03.21.09.12.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 09:12:27 -0700 (PDT) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI To: Simon Marchi , Eli Zaretskii References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83d0n8eyzw.fsf@gnu.org> <87d0n6adk2.fsf@tromey.com> <83imwyee29.fsf@gnu.org> <87d0n67d29.fsf@tromey.com> <83imwwc7pj.fsf@gnu.org> <57558f60-8254-931f-846b-bdd6b60f5798@simark.ca> <838sx8uwbb.fsf@gnu.org> <834l7wushq.fsf@gnu.org> <0f1760b45f024d45ceece8f0fe5c2686@simark.ca> Cc: tom@tromey.com, gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 21 Mar 2019 16:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0f1760b45f024d45ceece8f0fe5c2686@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00461.txt.bz2 On 03/21/2019 04:06 PM, Simon Marchi wrote: > On 2019-03-21 12:01, Eli Zaretskii wrote: >>> Date: Thu, 21 Mar 2019 11:02:00 -0400 >>> From: Simon Marchi >>> Cc: tom@tromey.com, gdb-patches@sourceware.org >>> >>> > I don't have a strong opinion, but I do have a weak one: the decimal >>> > "encoding" makes it much easier for humans to construct version >>> > numbers, they don't need to convert to hex. >>> >>> There's not much difference in hex, you would just write "if >>> $_gdb_version >= 0x0901" for example, rather than "if $_gdb_version >= >>> 901". Is there an advantage of a single variable that encodes the version, compared to separate major/minor variables? Separate variables would render the discussion of how to encode this moot. GCC has these as predefined preprocessor macros: __GNUC__ __GNUC_MINOR__ __GNUC_PATCHLEVEL__ We could likewise have separate variables for these. Thanks, Pedro Alves