Re: [PATCH 5/6] gdb: prepend comp_dir to symtab name in buildsym_compunit

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-04-18 12:36, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> This patch fixes things locally in a rather naive way by making
> Simon> buildsym_compunit format the main subfile's name the same way as the
> Simon> DWARF reader formats the main name, that is by prepending the directory
> Simon> part.
> 
> This looks good to me.

FYI, my next version will use a different method.  The "problem" with
this one is that the path to the main source file still gets expressed
in different ways in some cases.  When constructing the
buildsym_compunit, the path comes from the compilation unit's
DW_AT_comp_dir + DW_AT_name.  And that can give a different result than
a when built from the line table header.  Things still work, but only
because of the heuristic in watch_main_source_file_lossage.  But I'd
rather avoid that if possible.

Instead, I am changing the DWARF reader to always use "full paths"
everwhere.

Simon