From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1090B3858D1E for ; Mon, 18 Apr 2022 20:18:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1090B3858D1E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 23IKI2tL013713 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Apr 2022 16:18:07 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 23IKI2tL013713 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 712E61E150; Mon, 18 Apr 2022 16:18:02 -0400 (EDT) Message-ID: Date: Mon, 18 Apr 2022 16:18:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 5/6] gdb: prepend comp_dir to symtab name in buildsym_compunit Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20220407015159.1734834-1-simon.marchi@polymtl.ca> <20220407015159.1734834-6-simon.marchi@polymtl.ca> <87o80yuz56.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87o80yuz56.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 18 Apr 2022 20:18:02 +0000 X-Spam-Status: No, score=-3034.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2022 20:18:09 -0000 On 2022-04-18 12:36, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This patch fixes things locally in a rather naive way by making > Simon> buildsym_compunit format the main subfile's name the same way as the > Simon> DWARF reader formats the main name, that is by prepending the directory > Simon> part. > > This looks good to me. FYI, my next version will use a different method. The "problem" with this one is that the path to the main source file still gets expressed in different ways in some cases. When constructing the buildsym_compunit, the path comes from the compilation unit's DW_AT_comp_dir + DW_AT_name. And that can give a different result than a when built from the line table header. Things still work, but only because of the heuristic in watch_main_source_file_lossage. But I'd rather avoid that if possible. Instead, I am changing the DWARF reader to always use "full paths" everwhere. Simon