Re: [FYI/pushed v4 08/25] Thread options & clone events (Linux GDBserver)

[Pedro Alves <pedro@palves.net>]

Hi!

On 2024-02-07 18:18, Tom Tromey wrote:
>>>>>> "Luis" == Luis Machado <luis.machado@arm.com> writes:
> 
> Luis> I see. Is this logic expected? Naturally I'd expect a process to
> Luis> exist before a thread can exist.
> 
> Me too but you can see it in
> linux-low.cc:linux_process_target::handle_extended_wait.
> 
>       lwp_info *child_lwp = add_lwp (child_ptid);
> [...]
>       if (event != PTRACE_EVENT_CLONE)
> 	{
> 	  /* Add the new process to the tables and clone the breakpoint
> 	     lists of the parent.  We need to do this even if the new process
> 	     will be detached, since we will need the process object and the
> 	     breakpoints to remove any breakpoints from memory when we
> 	     detach, and the client side will access registers.  */
> 	  process_info *child_proc = add_linux_process (new_pid, 0);
> [...]
> 

I don't recall off hand a reason that prevents us from tweaking this code a little to
create the child process before the child lwp is created.  I think that was how it was
done before my changes, and I just reordered code to make it end up with fewer lines.
I think we can create the child process earlier.

I'll send a patch in a sec, once I test it.

Pedro Alves