From: Wei-min Pan <weimin.pan@oracle.com>
To: Tom Tromey <tom@tromey.com>,
Weimin Pan via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab
Date: Wed, 3 Mar 2021 14:27:00 -0800 [thread overview]
Message-ID: <a3abfedf-687c-d387-8648-a39f4f0f6f5f@oracle.com> (raw)
In-Reply-To: <874khsyngx.fsf@tromey.com>
On 3/3/2021 12:46 PM, Tom Tromey wrote:
>>>>>> ">" == Weimin Pan via Gdb-patches <gdb-patches@sourceware.org> writes:
>>> With the following change which was made last April:
>>> [gdb] Use partial symbol table to find language for main
>>> commit d3214198119c1a2f9a6a2b8fcc56d8c324e1a245
>>> The ctf reader was modified to enter all members of an enum type,
>>> similar to what the dwarf2 reader did, into the psymtab or gdb
>>> won't be able to find them. In addition, the empty name checking
>>> needed to be moved down so members of a unnamed enum were not left
>>> out.
> Thanks for the patch.
>
>>> + ctf_next_t *i = NULL;
>>> +
>>> + while ((ename = ctf_enum_next (ccp->fp, tid, &i, &val)) != NULL)
> Should probably use nullptr here.
Yes, will do.
> This is ok with this change.
Thanks.
> Tom
next prev parent reply other threads:[~2021-03-03 22:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 1:53 [PATCH,V2 0/5] CTF: bug fixes and new features Weimin Pan
2021-03-02 1:53 ` [PATCH,V2 1/5] CTF: fix incorrect function return type Weimin Pan
2021-03-02 1:53 ` [PATCH,V2 2/5] CTF: set up debug info for function arguments Weimin Pan
2021-03-02 1:53 ` [PATCH,V2 3/5] CTF: handle forward reference type Weimin Pan
2021-03-02 1:53 ` [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab Weimin Pan
2021-03-02 1:53 ` [PATCH,V2 5/5] CTF: multi-CU and archive support Weimin Pan
2021-03-02 23:15 ` Lancelot SIX
2021-03-03 1:01 ` Wei-min Pan
2021-03-03 17:37 ` Lancelot SIX
2021-03-03 18:31 ` Weimin Pan
2021-03-03 20:46 ` [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab Tom Tromey
2021-03-03 22:27 ` Wei-min Pan [this message]
2021-03-03 20:49 ` [PATCH,V2 3/5] CTF: handle forward reference type Tom Tromey
2021-03-03 22:01 ` Wei-min Pan
2021-03-02 12:23 ` [PATCH,V2 2/5] CTF: set up debug info for function arguments Lancelot SIX
2021-03-02 18:12 ` Wei-min Pan
2021-03-03 20:38 ` Tom Tromey
2021-03-03 21:58 ` Wei-min Pan
2021-03-03 20:41 ` Tom Tromey
2021-03-03 20:37 ` [PATCH,V2 1/5] CTF: fix incorrect function return type Tom Tromey
2021-03-03 21:57 ` Wei-min Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3abfedf-687c-d387-8648-a39f4f0f6f5f@oracle.com \
--to=weimin.pan@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).