From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by sourceware.org (Postfix) with ESMTPS id 3FC413851C31 for ; Wed, 3 Mar 2021 22:27:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3FC413851C31 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123MJn1w043283; Wed, 3 Mar 2021 22:27:03 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 371hhc6hgb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 22:27:03 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123ML23W178231; Wed, 3 Mar 2021 22:27:02 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 36yynr4j8n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 22:27:02 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 123MR1Ic005447; Wed, 3 Mar 2021 22:27:02 GMT Received: from [10.159.251.190] (/10.159.251.190) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Mar 2021 14:27:01 -0800 Subject: Re: [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab To: Tom Tromey , Weimin Pan via Gdb-patches References: <1614650018-9135-1-git-send-email-weimin.pan@oracle.com> <1614650018-9135-2-git-send-email-weimin.pan@oracle.com> <1614650018-9135-3-git-send-email-weimin.pan@oracle.com> <1614650018-9135-4-git-send-email-weimin.pan@oracle.com> <1614650018-9135-5-git-send-email-weimin.pan@oracle.com> <874khsyngx.fsf@tromey.com> From: Wei-min Pan Message-ID: Date: Wed, 3 Mar 2021 14:27:00 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <874khsyngx.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030159 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030159 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 22:27:06 -0000 On 3/3/2021 12:46 PM, Tom Tromey wrote: >>>>>> ">" == Weimin Pan via Gdb-patches writes: >>> With the following change which was made last April: >>> [gdb] Use partial symbol table to find language for main >>> commit d3214198119c1a2f9a6a2b8fcc56d8c324e1a245 >>> The ctf reader was modified to enter all members of an enum type, >>> similar to what the dwarf2 reader did, into the psymtab or gdb >>> won't be able to find them. In addition, the empty name checking >>> needed to be moved down so members of a unnamed enum were not left >>> out. > Thanks for the patch. > >>> + ctf_next_t *i = NULL; >>> + >>> + while ((ename = ctf_enum_next (ccp->fp, tid, &i, &val)) != NULL) > Should probably use nullptr here. Yes, will do. > This is ok with this change. Thanks. > Tom