public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/8] Convert C compile to C++
Date: Wed, 11 Jul 2018 11:31:00 -0000	[thread overview]
Message-ID: <a3b9fd48-0416-09f3-79ec-42b6d6998bb1@redhat.com> (raw)
In-Reply-To: <341ea2b9-714f-2e6a-9e3d-8de8075e364e@redhat.com>

On 07/10/2018 06:07 PM, Keith Seitz wrote:
> On 06/06/2018 07:38 AM, Pedro Alves wrote:
>> On 05/03/2018 07:41 PM, Keith Seitz wrote:
>>> This patch series begins the move to C++ for the compile feature,
>>> specifically targeting C type conversion.  This work is the basis for ongoing
>>> C++ compile work, which I hope to submit in the not-too-distant future.
>>
>> Looking forward to that.
> 
> Me, too. I've hoarded this for far too long!
> 
>> The series LGTM.  I sent a few comments, but really nothing serious.
>>
>> I was a bit surprised by use policy templates in patch #8,
>> but if it works for you, then it's certainly fine with me.
> 
> If you have a better/more maintainable/easier to read/understand alternative, I'm all ears.

Nah, it's not really possible to suggest something else before
seeing the corresponding C++ bits.  I guess templates makes sense
assuming the C++ bits add new plugin types unrelated to the C
plugin, etc.  I trust you on that, I was just surprised to see it.

Thanks,
Pedro Alves

      reply	other threads:[~2018-07-11 11:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 18:42 Keith Seitz
2018-05-03 18:41 ` [PATCH 2/8] Rename symbol_substitution_name Keith Seitz
2018-05-03 18:42 ` [PATCH 3/8] Move C-related declarations to compile-c.h Keith Seitz
2018-06-06 14:34   ` Pedro Alves
2018-05-03 18:42 ` [PATCH 1/8] Return unique_xmalloc_ptr for generate_c_for_variable_locations Keith Seitz
2018-05-03 18:49 ` [PATCH 6/8] Use std::unordered_map instead of htab_t Keith Seitz
2018-06-06 14:35   ` Pedro Alves
2018-07-10 17:05     ` Keith Seitz
2018-07-11 11:21       ` Pedro Alves
2018-08-07 14:57         ` Keith Seitz
2018-08-08 12:29           ` Pedro Alves
2018-08-10 18:18             ` Keith Seitz
2018-05-03 18:49 ` [PATCH 4/8] Add a C++ wrapper for GCC C plug-in Keith Seitz
2018-06-06 14:34   ` Pedro Alves
2018-07-10 16:58     ` Keith Seitz
2018-05-03 18:50 ` [PATCH 7/8] Move compile_instance to compile.c Keith Seitz
2018-05-03 18:50 ` [PATCH 8/8] Use policies for code generation Keith Seitz
2018-05-03 18:51 ` [PATCH 5/8] Change compile_instance/compile_c_instance into classes Keith Seitz
2018-06-06 14:38 ` [PATCH 0/8] Convert C compile to C++ Pedro Alves
2018-07-10 17:07   ` Keith Seitz
2018-07-11 11:31     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3b9fd48-0416-09f3-79ec-42b6d6998bb1@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).