From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65985 invoked by alias); 11 Jul 2018 11:31:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65976 invoked by uid 89); 11 Jul 2018 11:31:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1057 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jul 2018 11:31:05 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C59780D2F6B for ; Wed, 11 Jul 2018 11:31:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1662E2025089; Wed, 11 Jul 2018 11:31:02 +0000 (UTC) Subject: Re: [PATCH 0/8] Convert C compile to C++ To: Keith Seitz , gdb-patches@sourceware.org References: <20180503184153.31183-1-keiths@redhat.com> <995d9149-92bb-f6b4-a9c1-8ec61e3ccf40@redhat.com> <341ea2b9-714f-2e6a-9e3d-8de8075e364e@redhat.com> From: Pedro Alves Message-ID: Date: Wed, 11 Jul 2018 11:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <341ea2b9-714f-2e6a-9e3d-8de8075e364e@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00299.txt.bz2 On 07/10/2018 06:07 PM, Keith Seitz wrote: > On 06/06/2018 07:38 AM, Pedro Alves wrote: >> On 05/03/2018 07:41 PM, Keith Seitz wrote: >>> This patch series begins the move to C++ for the compile feature, >>> specifically targeting C type conversion. This work is the basis for ongoing >>> C++ compile work, which I hope to submit in the not-too-distant future. >> >> Looking forward to that. > > Me, too. I've hoarded this for far too long! > >> The series LGTM. I sent a few comments, but really nothing serious. >> >> I was a bit surprised by use policy templates in patch #8, >> but if it works for you, then it's certainly fine with me. > > If you have a better/more maintainable/easier to read/understand alternative, I'm all ears. Nah, it's not really possible to suggest something else before seeing the corresponding C++ bits. I guess templates makes sense assuming the C++ bits add new plugin types unrelated to the C plugin, etc. I trust you on that, I was just surprised to see it. Thanks, Pedro Alves