From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 133253850220 for ; Fri, 17 Mar 2023 20:36:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 133253850220 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 32HKapnO010094 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Mar 2023 16:36:56 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 32HKapnO010094 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1679085416; bh=TZAOmVXPcKzEvp+LHbt2pVOu5+1ldrRwPdjCfEILcSc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=lBc4dVsloWnnHT50+WfG6lwzVMgw4Lnw3uZmVaxXFDkyAIW05Db5CWUva5OtqjIRO ShChousZQU1gpefUmmLANvGi3Ua/WbmHNsBHFR6N/7cM1q/fDeJEXgVJFjMBWBjBYE lqoLHQpphLECFZwxarCkKP6wAIngqj00q7YwbSLA= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2FE081E110; Fri, 17 Mar 2023 16:36:50 -0400 (EDT) Message-ID: Date: Fri, 17 Mar 2023 16:36:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] gdb: introduce bp_loc_tracepoint Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20221125185614.363400-1-simon.marchi@polymtl.ca> <87o7qv20sk.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87o7qv20sk.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 17 Mar 2023 20:36:51 +0000 X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/18/23 12:46, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Because locations for tracepoints have the bp_loc_other type, > Simon> bl_address_is_meaningful started to return false for them, where it > Simon> returned true before. This made update_global_location_list skip the > Simon> part where it calls swap_insertion. > > Simon> I think this can be solved by introduced a new bp_loc_tracepoint > Simon> bp_loc_type. > > FWIW this patch looks good to me. > > Tom Thanks, pushed. Simon