From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 1BF903858D37 for ; Tue, 27 Feb 2024 23:17:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BF903858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BF903858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709075830; cv=pass; b=ol36Kt2RXC/2PuHbMBLFFALyopNY1iQVVpXtjhQ/6+hy1LFXzmipwNNjiYklPsjCWG9guz+VbyjFwVU83bgcMMVbF4Vnpbav87U+b/VlUqkD4ckCihzeg5Eml3PVRi+eYARfvmZkekFOqs13fXjS0wnppZTe5Xwhl07L+nZmG4k= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709075830; c=relaxed/simple; bh=n4DIhmsUTI5bDvUuHp8FrbCUEQHoSBbTtjSpiczjaHc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZbiFT/rD/ijBHTwqg3YIZAPepGw17L8hK2m8XXwVNs+7GlG5izwtAND4oUMRmGtZ8qV0XROD7H6skch7/HS+FAtez5DvPNtD3BFfZu51HKGsTnKMrhAcc44Z27uIVzWeQapelv9VwP1o4Xk44ckXQXNeB9qPt5IxgFZK/HmVrTM= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Tktfr6gf9z3nvk; Tue, 27 Feb 2024 23:17:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tktfr5rh8z4Nvj; Tue, 27 Feb 2024 23:17:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709075828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRURWEDpor89dPaRMb6knanqwG8IZz2lWni3Y1tNr0U=; b=Tq10T/DH+K6bHEdJjpkqNZAwEbjmyBkhKzRQLx7eW3cQN2iKQVzPV9aANGIzw22qK5GXTr vjF3YnOFyarhcRUJ+BLExU6P/F4ytV93el6KesqYnO0g1CJ/ytkxYWHWbVMi4DcT1nE6Sc 5GseF7Hwe33fsdR+LHNguDC5lWy4Gh+kxNkRwRsOvcYxEhqDmBbXcsVrbPtvMw0MCG/YHG Gn6YH+gWohsC+w5voVARGA7lxh8hdIIfqAB8fFJUoIrxZrQ1aUQMa8c+C0th6oOTuRypE/ ++d0jkGp+3NHIHnltKcDC/ExoxMRCxsOVcK3S5HHQWrhmS6fTV8UhZVl7Aczxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709075828; a=rsa-sha256; cv=none; b=WXdc98GKQ4r+OZ9EkVnHbvhvp2ArPmyFWqwUaC518z3Jd4dWzihhkjTsX+drFm0fH1ONlN E1U8mj/2+H5bWw7qirDQwQda3VZZYNjedNpvgAmoz8NRKxIlMPFv2urSWwtyKn3vUMLm9g 2fjEnp8wWV/iq8si6+mcNa9LA5y1/9BUBR9YZUT49NfW4tAvtaSXJtlwUhrJQNo39+zbuc PZ1dgKIxBYTZzDNDbr8XqF4XCyKMljRdBRSU96X783AgTpTv3tcpPNQNjC7Rdo+GgKR1fF pBLTnlf2DGYsg/yEFKG6Vj/NkSpbjqcz1qgr3Mb6z3znDw2LCuwyblBaHNosHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709075828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRURWEDpor89dPaRMb6knanqwG8IZz2lWni3Y1tNr0U=; b=CpRsunCT6jUB47WQHrk2cjy+BaEiQiTkD01vgi+kGTD7CDH9gdQKn45p/Xr//dWnXyDJU4 PkHRbFtOPK/pmCzrdSq1JTWsEqcog9HbzFdcvM/afQujldaZgWBQ2d+m3YmDAqkhaHTYSi yxdAX+qrHKhyTBVvo9WqkxjqPBoIyvsrnAuWzPHgtGe6WBzmoCwGH1qE8LMHxWyBfYpo0t M9e0EezaU/Nt5JijUa3qVVZ6bbwju6LGqcbmjWlFmPpTcINHtAs2GxRFAmjqyA9sil/PY5 Ro6o3aXb7LO36S9CvnuDHB7RILO28fuQck/UshUkKwpZlp1KxOJ3FXOU8ogQVA== Received: from [128.232.109.25] (user-109-25.vpn.cl.cam.ac.uk [128.232.109.25]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Tktfq6wLczbtW; Tue, 27 Feb 2024 23:17:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 27 Feb 2024 15:17:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] Remove two unnecessary casts Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240226205202.509729-1-tromey@adacore.com> From: John Baldwin In-Reply-To: <20240226205202.509729-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/26/24 12:52 PM, Tom Tromey wrote: > I noticed a spot in ada-lang.c where the return value of > value_as_address was cast to CORE_ADDR -- a no-op cast. I searched > and found another. This patch fixes both. > --- > gdb/ada-lang.c | 2 +- > gdb/eval.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index 3f398540010..1c26ebf7b30 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -10993,7 +10993,7 @@ ada_unop_ind_operation::evaluate (struct type *expect_type, > arg1)); > else > return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int, > - (CORE_ADDR) value_as_address (arg1)); > + value_as_address (arg1)); > } > > if (ada_is_array_descriptor_type (type)) > diff --git a/gdb/eval.c b/gdb/eval.c > index 4c438f927c0..2759b46a5df 100644 > --- a/gdb/eval.c > +++ b/gdb/eval.c > @@ -1685,7 +1685,7 @@ eval_op_ind (struct type *expect_type, struct expression *exp, > BUILTIN_TYPE_LONGEST would seem to be a mistake. */ > if (type->code () == TYPE_CODE_INT) > return value_at_lazy (builtin_type (exp->gdbarch)->builtin_int, > - (CORE_ADDR) value_as_address (arg1)); > + value_as_address (arg1)); > return value_ind (arg1); > } > LGTM Approved-By: John Baldwin -- John Baldwin