From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) by sourceware.org (Postfix) with ESMTPS id 8BF143858285 for ; Tue, 8 Nov 2022 11:24:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BF143858285 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=C9mhvGrmOtW87OUJWWmVJtGyHpNokeJ5wh9kQwivWSGYWim6d7NKyqLnreHL8C1Qh/nA/qX88UbpffjjxK1rn69L+1fz9K9llBkUwvWspsV0etmJ0VLMTZUmZXF64WRebspYW1Dfyc0OpLzQTaAryPHsqlmI0DWT80C+KgywJ8wxR8QjiddwhLgLzJ/Q28BFrFEdU+vmAwBRW1+8oLWql1eH7p/Z2zaj0kQ9bx60TzgKHYm0X/Av+Q+B1cIjcLSNTaqO8b6fOjmKwMiDuT4mmAIExHQK0NsX5rMlAmJFdL/dH2Lixl9zuO+YOJngQLCQ2i8I3MX5gVhtMtE42uuN4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1e5OL3kicGgoIt8QZHabfG938aENQlNJg9fn7/BwfJA=; b=AszxSdAZL62TaeQkSz59bHvszxaWTP87/0Z+DmpqJoylpbk24rvcj0iwVbwSwyrW4/fwnY/S8mTlKot4a7O+TztHUGDwZMrCBfuXLUQQHNxz17d4+C74I9ycF1ctiw9EuGzu52Z+jCe6ePHPuclWos2P6vI2lDeHu0L353zbwbGDzvuFBhM3we3GmNImty6X0FzqfrTmGm+guYhfJgX+e2dM5kGyMM53QDZiuJDoWPBdoeVu/pBWUGsyOjQAOSBjyGYnmFj0GPv58+tYXnZso4BVoXJXZHG7vIDGVB4IYc8Tcv3fbcNXLw1XjfNrzYQezuYzYwsDZcyfkQtV/40VLA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1e5OL3kicGgoIt8QZHabfG938aENQlNJg9fn7/BwfJA=; b=jGfbsMbT53NZk7+Kc9W+HDb94wMce2JoaciAU+rxZB3uvHqF4CdEU33tRtxd0dF3CWJ0TW8gvu6Fn2S1aiOuBulhAgdMqxluD3LJ2XEQh8JQRR6daFg3D21Vmta4JNuV8n2OHptEvMpGaFCecfm2d+MnzLs+wmGyrLVFMcBzdDU= Received: from DB6PR0501CA0017.eurprd05.prod.outlook.com (2603:10a6:4:8f::27) by GV1PR08MB7900.eurprd08.prod.outlook.com (2603:10a6:150:5f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:24:03 +0000 Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::7d) by DB6PR0501CA0017.outlook.office365.com (2603:10a6:4:8f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Tue, 8 Nov 2022 11:24:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 11:24:02 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Tue, 08 Nov 2022 11:24:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d13ab5171f441a66 X-CR-MTA-TID: 64aa7808 Received: from af7fd2600951.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 393E45DA-94B5-497A-B581-8E3F31E8607D.1; Tue, 08 Nov 2022 11:23:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af7fd2600951.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 11:23:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ti5xCXeeft7IXsHtnrGWDVUAfthbrMAsifowd2MSQpy/vQ8pOWM2ch6jXjcp4B71XpY+uSzMU4YYLm9ezwu5kS7KV7lkr+UAcdY7x+OWyoma+B4ck1dpdz5TLf1xR1QMtXYsDtU856e9dDeBwzy4fQEZeQFSmkh5Gq57YZEkQRdQsDB95Bsq74VNMg89D+si24oI6+gqQm43cG3P9518xPkXNTWlM8zSgCvMYYdXCtVBq7bMGGTPG5dESX8JhXubK+aOrXfEv6E1kV+cohEtWff7BdpMN3vjRqISPRuRRhLPWafZQ+EYxIxCWqqDeBzhQhwF148EZ3HvnoyuHSSUUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1e5OL3kicGgoIt8QZHabfG938aENQlNJg9fn7/BwfJA=; b=NzsKhSU+aouEi/KRe6YpsZianO1TSnqRBx3UMHcelmv1GXu26yjX1pbsJOpR09qiRaP3eT76TYm3IxQSdPYWKz0vVcFwVV0K+aSQ6fdbr4sbYCNEjcTgHWj7wreMayFTIIl8lWe06rQQeVTPfZt+9wkeXi2MllKwegpT3VV5871Ji857uxBcLYB4+ddV7fNtiLqNxUCgN9Sme0bdUWYBSe2koa5Nsa1B0+VsQfovEjEiai2K8B1ciPgIj4k4bqVKEevPmIOeSCJwTO54VejMwd9NEeQMTLUWlHWdtoHh+GY4nSv2Jf4kffvMinLg2fvrq9JvOEOzaxFPfdr3ZG2EaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1e5OL3kicGgoIt8QZHabfG938aENQlNJg9fn7/BwfJA=; b=jGfbsMbT53NZk7+Kc9W+HDb94wMce2JoaciAU+rxZB3uvHqF4CdEU33tRtxd0dF3CWJ0TW8gvu6Fn2S1aiOuBulhAgdMqxluD3LJ2XEQh8JQRR6daFg3D21Vmta4JNuV8n2OHptEvMpGaFCecfm2d+MnzLs+wmGyrLVFMcBzdDU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB9PR08MB9561.eurprd08.prod.outlook.com (2603:10a6:10:452::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:23:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801%5]) with mapi id 15.20.5813.009; Tue, 8 Nov 2022 11:23:51 +0000 Message-ID: Date: Tue, 8 Nov 2022 11:23:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC PATCH 1/5] gdb/arm: Introduce control_s and control_ns registers Content-Language: en-US To: Tomas Vanek , gdb-patches@sourceware.org References: <1667641476-31602-1-git-send-email-vanekt@fbl.cz> From: Luis Machado In-Reply-To: <1667641476-31602-1-git-send-email-vanekt@fbl.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR13CA0013.namprd13.prod.outlook.com (2603:10b6:806:130::18) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB9PR08MB9561:EE_|DBAEUR03FT008:EE_|GV1PR08MB7900:EE_ X-MS-Office365-Filtering-Correlation-Id: a41bd848-b45b-4934-cf1d-08dac17bbd55 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: U2Mvp3f2/zzj8nEzPVV9dWHNqL1WhQSPTPbx+dFDvyC5rQGfkXuGX6hDiiBnGjAG0o4R+oIMMwvSTx6WskMvfBRmwNEYvbIF5OdmzeQAHRULvDJzr5vrjJUR+AA7+Z+KchJUzi1EUk3YjboXZgrSI2F7L8yfw40vk1VAM1IEEuOuZj7Pvi2FpalkY9I2Gy0tXZraRXlXU3ahmyXTAmoU4UlbJ1CcD9WabsFYu/9jsfvuqTS4SBzAugJxd36xnd2DX76mwmdWAIkYqGiXPdVgTKgfly2o5INg8RovT9QlpQUveI/eQMqKUSkk7caYpyTEiPygbrDgDHmmDhkful0+I8djF3gVFMhgW8EwJel+QCQ6lbDag9aOyj++gwarZ3c2ipQWUW75e1QGvCBghQ01ECcNJp3la6gjkarfILktW7KpQceTvB5LNyaumfVJ6s+YAErc6LAnUgL4mOXK1UTiA0AwR5UmYrV7xCySK0lEm8btEPELR6TFYXyyf6aSyRAD7+STagxPqeBuekP6tkMNIFSLdeD2MB93/91qY+3CjxRxFFcGKXLzjtT1pIBJ6a+Q6D+AgNqh0DinPfC5PSKK4M4ftt0rmj7z2kW35ui1kPTAujyTvnvjkd3KUaW2JpmN1mBLQegi9J4nehYOJV3BSOWR8P0FZy0wKuYC+gCNBDx70ZXIjPBa5rkEKB/SdafGbNukdSGjsI50i3EblnzAilt9R/MKTfHMmKyE6H3aIHCO2Jp2o0pla3iRqSkws7obMoKzzVjirIpTvsSbritK/T+82z1MIrDfGxZGjqVD7EQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199015)(83380400001)(6512007)(53546011)(26005)(6666004)(6506007)(2616005)(66946007)(186003)(2906002)(44832011)(41300700001)(38100700002)(6486002)(316002)(8676002)(8936002)(5660300002)(66556008)(66476007)(478600001)(36756003)(86362001)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9561 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d6aff75-9edd-40dc-7868-08dac17bb633 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5lqm7eq7xHcV5KjEraTPFtb+eQMeBAlpc4czr5Ey6Y8UcX4g9qJi9R9ujE/uGD5meoSwP3ynU4dTrhm3RwwtnW8Mc5+oVoAtEVrI1vv56C8j/+atwLfybADUnjVt8mcSZIOCKV5RBwIfikDAA6kx8Oo2tGDJCJ3ZhdrwYb1UsI1hgSLzR//vo7Cld/wEs83KPWk+6ir/8BVFFnX5MfUF3vfxzp2Sm44fILawVSWZAuGU9lvbPRALsgqAHWs5KNBsMUcwnQ1RjnNexcjjCQCoumgOYRkZblaQTEm1X5rvNsmwSHzaQBmzpfCbnmouTZvZOXBw+4n4U6nyicss3YNWoZgyVdXvFAXGMcOGIX83Gi114+2rgbxME5EZJHpATwFAd6FZp0NCSeZWHqiNfPG61TKoOVoetaAmLYA7qjd+g90HQWQvu1wHIydIlhPk1VgHp7sdzee9llD3qrijxTGokPjiL6j15RbEJwubzXu3A8RszwU52ugPae84rvSBiOScwzy4LOwDiOqoXE7aAyBy1C8dh2sHKZUDMZViba3xutxSdtGfSIkWVBuO8B8e0+yQKuWQ6UxYAsVESFixoimh45Oz+atEYiwUKKgLaHstFtTqVhMIvegB83vC2XJ5zLaz5P1InjaFWQtJmABvuSM80pQKh/dkRPg9HIstqXi3Z2oVW1+0X74Dg8JZlvynM9c67yvOYpZKGciIBMjosSErUeulOA8am+7V5+O1kKlzUklJTrFy8k2HYtgJMC0KOh4W/kjCl/EaoImo/tSIRp8ubR9M1QxPjB/f8dUiOE7tP92yHPMghovI8JBrbd7+wSFc X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(356005)(82740400003)(81166007)(31696002)(86362001)(40480700001)(36860700001)(6486002)(44832011)(478600001)(2906002)(53546011)(6666004)(40460700003)(70586007)(8676002)(316002)(70206006)(5660300002)(8936002)(41300700001)(83380400001)(6506007)(82310400005)(2616005)(336012)(186003)(26005)(6512007)(47076005)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 11:24:02.7845 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a41bd848-b45b-4934-cf1d-08dac17bbd55 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7900 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,LIKELY_SPAM_BODY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tomas, On 11/5/22 09:44, Tomas Vanek wrote: > The M-profile security extension registers will be used for stack > selection in FNC_RETURN and return from secure to non-secure state. > > The presence of the registers is optional. > If one or both are missing the security extension profile is accepted. > The code using the registers must check m_profile_control_[n]?s_regnum > for -1. > > Signed-off-by: Tomas Vanek > --- > gdb/arm-tdep.c | 20 ++++++++++++++++++++ > gdb/arm-tdep.h | 2 ++ > 2 files changed, 22 insertions(+) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 3105543..564ee43 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -9996,6 +9996,8 @@ enum arm_vfp_cprc_base_type > int m_profile_psp_ns_regnum = -1; > int m_profile_msp_s_regnum = -1; > int m_profile_psp_s_regnum = -1; > + int m_profile_control_s_regnum = -1; > + int m_profile_control_ns_regnum = -1; > int tls_regnum = 0; > > /* If we have an object to base this architecture on, try to determine > @@ -10473,6 +10475,22 @@ enum arm_vfp_cprc_base_type > } > m_profile_psp_s_regnum = register_count++; > > + /* Regard the control_s and control_ns registers optional, > + * accept the security extension feature even without them */ > + valid_p = tdesc_numbered_register (feature, tdesc_data.get (), > + register_count, "control_s"); What tools are advertising control_s and control_ns? We need to document those properly if we're planning on using them as part of decision-making in GDB. > + if (!valid_p) > + warning (_("M-profile secext feature is missing required register control_s.")); > + else > + m_profile_control_s_regnum = register_count++; > + > + valid_p = tdesc_numbered_register (feature, tdesc_data.get (), > + register_count, "control_ns"); > + if (!valid_p) > + warning (_("M-profile secext feature is missing required register control_ns.")); > + else > + m_profile_control_ns_regnum = register_count++; > + > have_sec_ext = true; > } > > @@ -10553,6 +10571,8 @@ enum arm_vfp_cprc_base_type > tdep->m_profile_psp_ns_regnum = m_profile_psp_ns_regnum; > tdep->m_profile_msp_s_regnum = m_profile_msp_s_regnum; > tdep->m_profile_psp_s_regnum = m_profile_psp_s_regnum; > + tdep->m_profile_control_s_regnum = m_profile_control_s_regnum; > + tdep->m_profile_control_ns_regnum = m_profile_control_ns_regnum; > } > > arm_register_g_packet_guesses (gdbarch); > diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h > index bcd7e08..11670e9 100644 > --- a/gdb/arm-tdep.h > +++ b/gdb/arm-tdep.h > @@ -133,6 +133,8 @@ struct arm_gdbarch_tdep : gdbarch_tdep_base > int m_profile_psp_ns_regnum = ARM_SP_REGNUM; /* M-profile PSP_NS register number. */ > int m_profile_msp_s_regnum = ARM_SP_REGNUM; /* M-profile MSP_S register number. */ > int m_profile_psp_s_regnum = ARM_SP_REGNUM; /* M-profile PSP_S register number. */ > + int m_profile_control_s_regnum = -1; /* M-profile CONTROL_S register number. */ > + int m_profile_control_ns_regnum = -1; /* M-profile CONTROL_NS register number. */ > > int tls_regnum = 0; /* Number of the tpidruro register. */ >