From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 697A83858D20 for ; Thu, 10 Nov 2022 17:36:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 697A83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CA5AD1E0D3; Thu, 10 Nov 2022 12:36:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1668101795; bh=p8KY+8Wc17sA6978PVi28KcakVwFUn9blTTg+DjfIho=; h=Date:Subject:To:References:From:In-Reply-To:From; b=IVXkPfdKR9WVOtd7MSn7poNd4wE+D4W6y4A0Kl4UD/iarNJ8n7JpsMrFxtkRogyig NA06SmTfIk3B3ZBl1xsdepxlXg/aqB/rocpycE9DMXVXG2Ur7zP77PH1tzgqpmDVSE jmAQEoesMG8AUJM2J7zlQ/7YteRjKI24P6Apj7zE= Message-ID: Date: Thu, 10 Nov 2022 12:36:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2] gdb: make "start" breakpoint inferior-specific Content-Language: en-US To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <691c5a58-68ae-5fe9-2f3d-34fb7af69ad0@palves.net> <20221108212008.1792090-1-simon.marchi@efficios.com> <47b696c4-6584-8165-0799-5d742132361a@palves.net> <0ebeeb02-db83-53ac-2bcb-05dc92b96316@simark.ca> From: Simon Marchi In-Reply-To: <0ebeeb02-db83-53ac-2bcb-05dc92b96316@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> Even though this does work, it still sets the breakpoint on all the pspaces >> unnecessarily. It would be nice if the breakpoint was pspace specific, in >> addition to inferior specific like you have (or some other way). But, what you >> have is fine with me as is, as it is better than what we have today. >> Maybe just add a little comment suggesting that it would be even better >> to make the breakpoint apply to the current pspace only? > > Will do. FWIW, here's what I'm adding /* To avoid other inferiors hitting this breakpoint, make it inferior-specific using a condition. A better solution would be to have proper inferior-specific breakpoint support, in the breakpoint machinery. We could then avoid inserting a breakpoint in the program spaces unrelated to this inferior. */ Simon