From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1DE1A3858D35 for ; Thu, 21 Dec 2023 10:01:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DE1A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DE1A3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703152873; cv=none; b=ctoowU0RYobGIPNSkbxcsIhwrrWalcbph4wjhQyG/Tu/vMAYc7zJ3fuVQQPd7mTlWa9u9/j0dE2FZ3iJLy7t8Mlx3WnUcJUsL5A6KI/FT3bLHbitIs0hZNu8/imKWHg/lufGuQlv+RMPzUbplZZ6iVG9SLPTZfMiAr1GJfHbEtg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703152873; c=relaxed/simple; bh=wZyuenpaqgK3JzdmtpKyeRRnZX+c6u/htvwAwanirZI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hs/Kc48w7lsZgtSlGs6Ys2+pXMAGoD4RopgammfM398JuDE1gxs8BkWFHxWv7CvNXi3rno34j2eZzNsa4XFMOd1RqsgN4hueA/kilsnXtML09zOr/lBLluH5AjOZ+5G9gOh35eUMupsrjlwbhwu5MAj17ceup3TQGlsbW6tMBEQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703152870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TL72xoVEKPRuxSiqrFt01WT4YKbTnU1NAzoSU2Xbrjc=; b=LqVkP2MD1jm/RrJ9KPDBaWvVwIbJr57i/yVNw6EWISbkRFPWcyHySVrYtwBFm2dTGmgHwk O6DwKCIfsJmwxigzK9+fxI9wFHgtlYAzP0K4DP4FvOV797EigWFJY+BgrSLU5bu0lo497g TbQYw5OkeErIZUiIKMWzt4mlLFXrc6M= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-8lsUH8R_NreoqSg4rQ0uQA-1; Thu, 21 Dec 2023 05:01:09 -0500 X-MC-Unique: 8lsUH8R_NreoqSg4rQ0uQA-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-554055455a5so315000a12.2 for ; Thu, 21 Dec 2023 02:01:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703152868; x=1703757668; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TL72xoVEKPRuxSiqrFt01WT4YKbTnU1NAzoSU2Xbrjc=; b=G5jRy4nkWMwxslVeQvRuteQMaH/1bdVwdfSI9gh2KV79q7xJ2bvst0vSKQw/J4Vr1+ 9VR+/Zhh1//YKGZ9ODo28Sd8abbA5UkkOOaVZDxiaeh86VqCCZc4W1280DTFFDtOHSRd xYTU4rRk1Mz1O/y25Z5aAhV3Sg3MUKW49Ac6wGqqe9dPBZEIDEoo76MwP4TTb7yVy1NE gCo2GLUE+xIPyAcpZ28dpUmeXiRSOZ+HqZUmMU5Xn8tTrrTQKoGpw4C5U1dW0hHEeJTD rzQwHv5ZHFIV23HV+Mxzo1EEfF4AcQx2LBsBb/eLwFuLzneZpF6wJmj5iH09aY8E6UUs /EUg== X-Gm-Message-State: AOJu0YzFxx0GMhBaOh3XSlWtU28J8/ZxPwrPPlichg+/5ZOG5CNgPzEE 8gkRVhrYMk6P1z8JkumD+IhzcH/Rd+RQzRJ0pwF5AxLpCHEpvzu8G66J8/FTAfaDQKdwgVcc5Yr kM4PYSC9HiLUwSLkgfLbNV5jiJbQ9noJllFPCnj+paroLxJBegW5CNLZvdzkLlmXR44nly2LcwL aU/5L8 X-Received: by 2002:a05:6402:902:b0:54c:47cc:caf8 with SMTP id g2-20020a056402090200b0054c47cccaf8mr8178339edz.62.1703152867900; Thu, 21 Dec 2023 02:01:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvH5LkPbvvNuivWTSE+kg6AGrPaToDCytdvYibgEjoWayUSimaemM2wccrEfvTJI7tfzzNHQ== X-Received: by 2002:a05:6402:902:b0:54c:47cc:caf8 with SMTP id g2-20020a056402090200b0054c47cccaf8mr8178325edz.62.1703152867258; Thu, 21 Dec 2023 02:01:07 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id b3-20020aa7d483000000b0054c7dfc63b4sm956525edr.43.2023.12.21.02.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 02:01:06 -0800 (PST) Message-ID: Date: Thu, 21 Dec 2023 11:01:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PING][PATCH v7] gdb: add git trailer information on gdb/MAINTAINERS To: gdb-patches@sourceware.org Cc: Kevin Buettner , Luis Machado References: <20231207173415.2311804-2-blarsen@redhat.com> From: Guinevere Larsen In-Reply-To: <20231207173415.2311804-2-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! Three global maintainers have already added review by tags, so I wonder when it is ready for pushing... -- Cheers, Guinevere Larsen She/Her/Hers On 07/12/2023 18:34, Guinevere Larsen wrote: > The project has been using Tested-By (tb), Reviewed-By (rb) and > Approved-By (ab) for some time, but there has been no information to be > found in the actual repository. This commit changes that by adding > information about all git trailers to the MAINTAINERS file, so that it > can be easily double-checked. Simply put, the trailers in use work as > follows: > > * Tested-by: The person tested the patch and it fixes the problem, or > introduces no regressions (or both). > * Acked-by: The general outline looks good, but the maintainer hasn't > looked at the code > * Reviewed-by: The code looks good, but the reviewer has not approved > the patch to go upstream > * Approved-by: The patch is ready to be pushed to master > > These last 3 trailers can also be restricted to one or more areas of GDB > by adding the areas in a comma separated list in parenthesis after the > trailers. > > Finally, for completeness sake, the trailers Co-Authored-By and Bug > were added, even though they have been in use for a long time already > > Reviewed-by: Kevin Buettner > Reviewed-by: Luis Machado > --- > gdb/MAINTAINERS | 96 ++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 88 insertions(+), 8 deletions(-) > > diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > index 38c982ef7eb..f86aa8818a0 100644 > --- a/gdb/MAINTAINERS > +++ b/gdb/MAINTAINERS > @@ -43,14 +43,9 @@ patch without review from another maintainer. This especially includes > patches which change internal interfaces (e.g. global functions, data > structures) or external interfaces (e.g. user, remote, MI, et cetera). > > -The term "review" is used in this file to describe several kinds of feedback > -from a maintainer: approval, rejection, and requests for changes or > -clarification with the intention of approving a revised version. Review is > -a privilege and/or responsibility of various positions among the GDB > -Maintainers. Of course, anyone - whether they hold a position but not the > -relevant one for a particular patch, or are just following along on the > -mailing lists for fun, or anything in between - may suggest changes or > -ask questions about a patch! > +The word "contributor" is used in this document to refer to any GDB > +developer listed above as well as folks who may have suggested some > +patches but aren't part of one of those categories for any reason. > > There's also a couple of other people who play special roles in the GDB > community, separately from the patch process: > @@ -78,6 +73,91 @@ consensus among the global maintainers and any other involved parties. > In cases where consensus can not be reached, the global maintainers may > ask the official FSF-appointed GDB maintainers for a final decision. > > +The term "review" is used in this file to describe several kinds of > +feedback from a maintainer: approval, rejection, and requests for changes > +or clarification with the intention of approving a revised version. > +Approval is a privilege and/or responsibility of various positions among > +the GDB Maintainers. Of course, anyone - whether they hold a position, but > +not the relevant one for a particular patch, or are just following along on > +the mailing lists for fun, or anything in between - may suggest changes, ask > +questions about a patch or say if they believe a patch is fit for upstreaming! > + > +To ensure that patches are only pushed when approved, and to properly credit > +the contributors who take the time to improve this project, the following > +trailers are used to identify who contributed and how. The trailers (or tags) > +currently in use are: > + > + - Tested-By: > + > + Used when a contributor has tested the patch and finds that it > + fixes the claimed problem. It may also be used to indicate that > + the contributor has performed regression testing. By itself, this > + tag says nothing about the quality of the fix implemented by the > + patch, nor the amount of testing that was actually performed. > + > + Usage: "Tested-By: Your Name " > + > + - Acked-By: > + > + Used when a responsible or global maintainer has taken a superficial > + look at a patch and agrees with its direction, but has not done further > + review on the subject. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma-separated list. > + Usage: "Acked-By: Your Name (area1, area2)" > + > + - Reviewed-By: > + > + Used when a contributor has looked at the code and agrees with > + the changes, but either doesn't have the authority or doesn't > + feel comfortable approving the patch. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma-separated list. > + Usage: "Reviewed-By: Your Name (area1, area2)" > + > + - Approved-By: > + > + Used by responsible maintainers or global maintainers when a patch is > + ready to be upstreamed. If a patch requires multiple approvals, only > + the last reviewer should use this tag, making it obvious to the > + contributor that the patch is ready to be pushed. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma separated list. Patches must have all areas > + approved before being pushed. If a patch has had some areas approved, > + it is recommended that the final approver makes it explicit that the > + patch is ready for pushing. > + Responsible, Global and Official FSF-appointed maintainers may approve > + their own patches, but it is recommended that they seek external approval > + before doing so. > + > + Usage: "Approved-By: Your Name " > + > + - Co-Authored-By: > + > + Used when the commit includes meaningful contributions from multiple people. > + > + Usage: "Co-Authored-By: Contributor's Name " > + > + - Bug: > + > + This trailer is added with a link to the GDB bug tracker bug for > + added context on relevant commits. > + > + Usage: "Bug: " > + > +Sometimes, contributors may request small changes, such as fixing typos, before > +granting the review or approval trailer. When the contributor thinks that > +these changes are so small that it isn't necessary to send a new version, they > +may add some text like "with these changes, I'm ok with the patch", followed by > +their trailer. In those situations, the trailer is only valid after the > +changes are made. > + > > The Obvious Fix Rule > --------------------