Re: [PATCH v5 1/6] [gdb/cli] Add signal_handler_selftest

[Tom de Vries <tdevries@suse.de>]

On 10/24/23 11:49, Tom de Vries wrote:
> +signal_handler_selftest::signal_handler_selftest () +{ + /* If SIGINT 
> or SIGTERM is pending, try to handle it as usual. */ + QUIT; + + /* 
> Assert SIGTERM is not pending. */ + gdb_assert (!pending_sigterm ()); + 
> + if (check_quit_flag ()) + { + /* SIGINT is still pending. This can 
> happen because QUIT doesn't + handle pending SIGINT in all cases. Bail 
> out. */ + set_quit_flag (); + return; + } + + /* Assert SIGINT is not 
> pending. */ + gdb_assert (!pending_sigint ()); +

I was about to check in this patch, and the following that uses it in 
the python selftest, but I decided to play a bit more with it, and ran 
the selftests while hitting control-C, and ran into:
...
Running selftest python.
/data/vries/gdb/src/gdb/event-top.c:1246: internal-error: 
signal_handler_selftest: Assertion `!pending_sigint ()' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
----- Backtrace -----
0x5a1ac2 gdb_internal_backtrace_1
	/data/vries/gdb/src/gdb/bt-utils.c:122
0x5a1b65 _Z22gdb_internal_backtracev
	/data/vries/gdb/src/gdb/bt-utils.c:168
0xcf93d6 internal_vproblem
	/data/vries/gdb/src/gdb/utils.c:396
0xcf97a5 _Z15internal_verrorPKciS0_P13__va_list_tag
	/data/vries/gdb/src/gdb/utils.c:476
0x14b002e _Z18internal_error_locPKciS0_z
	/data/vries/gdb/src/gdbsupport/errors.cc:58
0x788092 _ZN9selftests23signal_handler_selftestC2Ev
	/data/vries/gdb/src/gdb/event-top.c:1246
0xa84b53 test_python
	/data/vries/gdb/src/gdb/python/python.c:2331
0x42258f ???
0x6104af _ZNKSt8functionIFvvEEclEv
	/usr/include/c++/9/bits/std_function.h:688
0x14c4632 _ZN9selftests9run_testsEN3gdb10array_viewIKPKcEEb
	/data/vries/gdb/src/gdbsupport/selftest.cc:101
0x91cbaa maintenance_selftest
	/data/vries/gdb/src/gdb/maint.c:1164
0x5f60ee do_simple_func
	/data/vries/gdb/src/gdb/cli/cli-decode.c:95
0x5fb0e1 _Z8cmd_funcP16cmd_list_elementPKci
	/data/vries/gdb/src/gdb/cli/cli-decode.c:2735
0xc605b2 _Z15execute_commandPKci
	/data/vries/gdb/src/gdb/top.c:575
0x912551 catch_command_errors
	/data/vries/gdb/src/gdb/main.c:513
0x91275c execute_cmdargs
	/data/vries/gdb/src/gdb/main.c:612
0x913aac captured_main_1
	/data/vries/gdb/src/gdb/main.c:1293
0x913caf captured_main
	/data/vries/gdb/src/gdb/main.c:1314
0x913d4e _Z8gdb_mainP18captured_main_args
	/data/vries/gdb/src/gdb/main.c:1343
0x4188bd main
	/data/vries/gdb/src/gdb/gdb.c:39
---------------------
/data/vries/gdb/src/gdb/event-top.c:1246: internal-error: 
signal_handler_selftest: Assertion `!pending_sigint ()' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) [answered Y; input not from terminal]
...

I'm not sure yet how this happens, but it's clear this needs further work.

Thanks,
- Tom