From: Simon Marchi <simon.marchi@efficios.com>
To: Pedro Alves <pedro@palves.net>,
Simon Marchi <simon.marchi@polymtl.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 05/14] gdb: rename things related to step over chains
Date: Fri, 4 Dec 2020 16:04:34 -0500 [thread overview]
Message-ID: <a59a169c-571a-1581-debf-005670d9c236@efficios.com> (raw)
In-Reply-To: <a0fdfc58-50e9-37bd-591e-9335d6835d6d@palves.net>
On 2020-12-03 8:49 p.m., Pedro Alves wrote:
> On 12/2/20 3:47 PM, Simon Marchi via Gdb-patches wrote:
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> New in v2: comment and formatting fixes.
>>
>> Rename step_over_queue_head to global_thread_step_over_chain_head, to
>> make it more obvious when reading code that we are touching the global
>> queue. Rename all functions that operate on it to have "global" in
>> their name, to make it clear on which chain they operate on. Also, in a
>> subsequent patch, we'll need both global and non-global versions of
>> these functions, so it will be easier to do the distinction if they are
>> named properly.
>>
>> Normalize the naming to use "chain" everywhere instead of sometimes
>> "queue", sometimes "chain".
>>
>> I also reworded a few comments in gdbthread.h. They implied that the
>> step over chain is per-inferior, when in reality there is only one
>> global chain, not one per inferior, as far as I understand.
>>
>> gdb/ChangeLog:
>>
>> * gdbthread.h (thread_step_over_chain_enqueue): Rename to...
>> (global_thread_step_over_chain_enqueue): ... this. Update all
>> users.
>> (thread_step_over_chain_remove): Rename to...
>> (global_thread_step_over_chain_remove): ... this. Update all
>> users.
>> (thread_step_over_chain_next): Rename to...
>> (global_thread_step_over_chain_next): ... this. Update all
>> users.
>> * infrun.h (step_over_queue_head): Rename to...
>> (global_thread_step_over_chain_head): ... this. Update all
>> users.
>> * infrun.c (step_over_queue_head): Rename to...
>> (global_thread_step_over_chain_head): ... this. Update all
>> users.
>> * thread.c (step_over_chain_remove): Rename to...
>> (thread_step_over_chain_remove): ... this. Update all users.
>> (thread_step_over_chain_next): Rename to...
>> (global_thread_step_over_chain_next): ... this. Update all
>> users.
>> (thread_step_over_chain_enqueue): Rename to...
>> (global_thread_step_over_chain_enqueue): ... this. Update all
>> users.
>> (thread_step_over_chain_remove): Rename to...
>> (global_thread_step_over_chain_remove): ... this. Update all
>> users.
>
> Tabs vs spaces in ChangeLog. Otherwise OK.
>
Fixed, thanks.
Simon
next prev parent reply other threads:[~2020-12-04 21:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 15:47 [PATCH v2 00/14] Concurrent displaced stepping Simon Marchi
2020-12-02 15:47 ` [PATCH v2 01/14] gdb: add inferior_execd observable Simon Marchi
2020-12-04 1:45 ` Pedro Alves
2020-12-02 15:47 ` [PATCH v2 02/14] gdb: clear inferior displaced stepping state and in-line step-over info on exec Simon Marchi
2020-12-02 17:16 ` Simon Marchi
2020-12-04 1:54 ` Pedro Alves
2020-12-04 20:49 ` Simon Marchi
2020-12-04 1:48 ` Pedro Alves
2020-12-04 21:03 ` Simon Marchi
2020-12-02 15:47 ` [PATCH v2 03/14] gdb: restore displaced step buffer bytes when another thread forks Simon Marchi
2020-12-04 1:48 ` Pedro Alves
2020-12-02 15:47 ` [PATCH v2 04/14] gdb: get rid of get_displaced_stepping_state Simon Marchi
2020-12-04 1:48 ` Pedro Alves
2020-12-04 21:06 ` Simon Marchi
2020-12-02 15:47 ` [PATCH v2 05/14] gdb: rename things related to step over chains Simon Marchi
2020-12-04 1:49 ` Pedro Alves
2020-12-04 21:04 ` Simon Marchi [this message]
2020-12-02 15:47 ` [PATCH v2 06/14] gdb: rename displaced_step_closure to displaced_step_copy_insn_closure Simon Marchi
2020-12-04 1:49 ` Pedro Alves
2020-12-02 15:47 ` [PATCH v2 07/14] gdb: rename displaced_step_fixup to displaced_step_finish Simon Marchi
2020-12-04 1:49 ` Pedro Alves
2020-12-02 15:47 ` [PATCH v2 08/14] gdb: introduce status enum for displaced step prepare/finish Simon Marchi
2020-12-04 1:49 ` Pedro Alves
2020-12-04 21:08 ` Simon Marchi
2020-12-02 15:48 ` [PATCH v2 09/14] gdb: pass inferior to get_linux_inferior_data Simon Marchi
2020-12-04 1:50 ` Pedro Alves
2020-12-02 15:48 ` [PATCH v2 10/14] gdb: move displaced stepping types to displaced-stepping.{h, c} Simon Marchi
2020-12-04 1:50 ` Pedro Alves
2020-12-02 15:48 ` [PATCH v2 11/14] gdb: move displaced stepping logic to gdbarch, allow starting concurrent displaced steps Simon Marchi
2020-12-04 1:50 ` Pedro Alves
2020-12-04 21:11 ` Simon Marchi
2020-12-02 15:48 ` [PATCH v2 12/14] gdb: change linux gdbarch data from post to pre-init Simon Marchi
2020-12-04 1:50 ` Pedro Alves
2020-12-02 15:48 ` [PATCH v2 13/14] gdb: make displaced stepping implementation capable of managing multiple buffers Simon Marchi
2020-12-04 1:51 ` Pedro Alves
2020-12-04 21:14 ` Simon Marchi
2020-12-02 15:48 ` [PATCH v2 14/14] gdb: use two displaced step buffers on amd64/Linux Simon Marchi
2020-12-04 1:51 ` Pedro Alves
2020-12-04 1:56 ` [PATCH v2 00/14] Concurrent displaced stepping Pedro Alves
2020-12-04 21:52 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a59a169c-571a-1581-debf-005670d9c236@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).