From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-144880-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32856 invoked by alias); 17 Jan 2018 17:36:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 32840 invoked by uid 89); 17 Jan 2018 17:36:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jan 2018 17:36:32 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w0HHaPxR030967	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Wed, 17 Jan 2018 12:36:30 -0500
Received: by simark.ca (Postfix, from userid 112)	id 9D5351E5B7; Wed, 17 Jan 2018 12:36:25 -0500 (EST)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id 16B9F1E074;	Wed, 17 Jan 2018 12:36:25 -0500 (EST)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 17 Jan 2018 17:36:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup
In-Reply-To: <14229ad8-5663-ff4a-51b1-479f75bcd3fe@redhat.com>
References: <1514732385-5506-1-git-send-email-simon.marchi@ericsson.com> <14229ad8-5663-ff4a-51b1-479f75bcd3fe@redhat.com>
Message-ID: <a5ceafb0503b1cbef822ffa82ee9592c@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.2
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 17 Jan 2018 17:36:25 +0000
X-IsSubscribed: yes
X-SW-Source: 2018-01/txt/msg00354.txt.bz2

On 2018-01-17 07:25, Pedro Alves wrote:
> On 12/31/2017 02:59 PM, Simon Marchi wrote:
>> I think this xstrdup is not useful.  We can pass ex.message directly 
>> to
>> throw_error instead.
>> 
>> gdb/ChangeLog:
>> 
>> 	* linux-nat.c (linux_nat_attach): Remove xstrdup.
> 
> LGTM.
> 
> Thanks,
> Pedro Alves

Thanks, I pushed both patches.

Simon