From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by sourceware.org (Postfix) with ESMTPS id 9B51C3858D1E for ; Tue, 13 Sep 2022 14:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B51C3858D1E ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Z4uZNHLyq6aZF7q5+FpNgECz0uykUZz0cKecBDVojCBKHQ3SOIuEc3hF+UWYf+r3JOKY1iGYI9VSabsySlI4huLozvvq6Ld76gwr+hgt7x0JgP8oyLu+FLGxA6IKO6BujdHZdpkXI6fLvyY0CQoAu0q/1gxjFYX4XtKZ7+V1yBGOI9QcogksCfuRSK9uaJfDuW2ZJoOCVvxG0ARBRgrhkRO/rICqLeiq1xaJ0dy/sxs7b/FQn3sLDf2jdLrFX9XqTjUcS1Y8SndoFF8B3jcz4KjOC2b2Zx75lnOzNU56RmS7C+tR0iVd3bc+0nB5Wv6mkZyp/EjA1I4FSFXhQJP4vA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1tQklJ50kwh8/vGM2I6Ozh/Mt4hn5DWuBiaLgjRmOUA=; b=jsI5jcaAE72mUGjY4jVRefzAAfAWpybS0BdEV/RTGZTuk4m51tfi0HQ8II6Nf3s7SqmgysZUe3/dWRWKWIIyvROQvn96RbjWBEug7nZvL/0noez8FqyeJzLfYBlzZNay3hsqYm9AhGse5QrTxLB2VWSCb5UmaNqZ0PV5iLqYM7DQEssu5Xc4T/YAUZw4LCK/4j+6jUmv6id02QnMmbx3vUpOAURptFZIWN0Vrh0e/SB+tYyBmogXbScCddqEYi+ZlExuJNgN/10x4k6mDFR//G4ecQeQfxI++8gWT7DdKJ+qsiOIjTPzMJWfYcK/kaMzE3APchivCKGhpJt4wp/Ndw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DU2PR04CA0007.eurprd04.prod.outlook.com (2603:10a6:10:3b::12) by AS8PR08MB9118.eurprd08.prod.outlook.com (2603:10a6:20b:5b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Tue, 13 Sep 2022 14:10:48 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::ca) by DU2PR04CA0007.outlook.office365.com (2603:10a6:10:3b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22 via Frontend Transport; Tue, 13 Sep 2022 14:10:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 14:10:48 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Tue, 13 Sep 2022 14:10:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e8db61203942f218 X-CR-MTA-TID: 64aa7808 Received: from 65815c2fcd6f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 295F275D-9233-4551-93E7-021B07D1155D.1; Tue, 13 Sep 2022 14:10:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 65815c2fcd6f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Sep 2022 14:10:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzkLgHs2jar45vH0VVyDNQxc6AShseImDydrixa7ydb5hid1yWuqwa5ci+UC/brwchiOUwq9yYlIocyD9NbC4IBR6OJ2KXhr373ESjVc3nASltI62+epvHSmZbf7hVUq3ATwJctvOiJQmJAoo853Y63yfkAU6/fq6KW2Nw5yda4LngmWo33FecmrcnDuCCCrZsCDcWInopBhO+9fl1WMrmkzhAiVZTQGjuyqoqxWvLHA4TMRaOHhyy0IWyNWw9pRvXA7VgzKpQo3hYXEBokklCYomz6Vb52fQlC6A3C5ZBf4xeWg6r4pktthrNlucNcbu0cG8xm1QC0780SuxoCW/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1tQklJ50kwh8/vGM2I6Ozh/Mt4hn5DWuBiaLgjRmOUA=; b=VK39VC1tPnIIG2kRVAMcb/8YIp2kT7cF1Anl+VYALybPThU5KANBSaPD4/Q9K8foWiNX59jKjbJvmNJcc2honhGLicF7ReL965P+RDHXbLJCN9OEjmNrxohGHxwEK18lnZstFXJvR4+Jit1pL/E0eLuywtcw2m7mRngea8CDO2r1hUsSkA4BULBhqnW6YXETCA9Kq6qf2MPrprQuGyg7Di4Pj208I9vs7e2GOG7Y6Ssa9C7SVKTGZu1w0XSmFGhDijl94ir5hbsCinlozc6vWpArrecDhooxAZ7dF+Bc/d2bLDjt9TGyj7mCRE0BI/yWzSYYQ4kfIHWkFmYOEnlM3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV1PR08MB8239.eurprd08.prod.outlook.com (2603:10a6:150:5f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 14:10:39 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 14:10:39 +0000 Message-ID: Date: Tue, 13 Sep 2022 15:10:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile Content-Language: en-US To: Keith Seitz , Simon Marchi , gdb-patches@sourceware.org References: <20220912224733.2962282-1-keiths@redhat.com> <383112d6-4d64-38e5-9e77-3f46b845e494@simark.ca> <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com> From: Luis Machado In-Reply-To: <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0060.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::11) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV1PR08MB8239:EE_|DBAEUR03FT025:EE_|AS8PR08MB9118:EE_ X-MS-Office365-Filtering-Correlation-Id: 476ec610-0040-4b9f-d55c-08da9591c237 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VLQbSQxJ7b7nhImZKxWlMdVVepABa0pDHLLaQ4OIjkyddY+6T6u/27xtsgT4lC4qEMo8SJE/WyKQF2EEHVIAlNPCBS9NtKX+p/JERA2bGIvoOVv/2pSrtCZ5UP7A7+2bYwi3Ld5WVvrEhjXHOsaFj41Zjwi6a1XNCamivzaVJFLMSTMBScbU0DqX6nqQs2rWFKAaIaoSRdXGHzbe0n8RB9bv+Sc9i/LvqPOosztAXwZ3L6oX9Y87vNB2jVGuNUanYI/7tpjYO8yiooQ3d0nMtU1RpA7VBOMQ23r5n090lmUKfKKo1yHKL589IUinCIVM8710GWw/GSdNJOTI3oQeIoGibSDj0U31Q3dOgiMNy17QmzvkKptf8Ad95VOfYCzZAs7D3ZWhYyPyMafUHdMrgFDIDHXADL+dDg6g2ibeKwBOPT6vWmk9S42sQ0tRLe/h8yLn9quQj0HfgPrXL4dr7YJAWtHpOoNaf6F1BQwIH/bmiP9D1k/2syMTuT+YWXfcuNop6/XJ/X8GbDvdMk0y+KMGQwovpfvGwwdWvfgYtP+UxJ6OO6ImBFdDwPb/aNMqYS69b/FJPLROMYS+l7sf0p5VMFgENA5DhT/YaNmkVTcIUd8oG2gt1DaC+iDkHJsCu95XmH0ZfNgRA217guEWOe2M0Z+y5OZ9QTEtjR1WH8E+pCkgzP+uBFD5rXRslSEeC7zIsFb2LK9zVRGdZB+IgHo8AAuF8DeoQ+UhCSJliYnmhBu1YDhEElgJ9GcTntWzfNhkF23o7uSRZKslBSc3JtiM/KlQNZPLwx1S/FMyifA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(366004)(346002)(396003)(376002)(451199015)(2616005)(478600001)(6512007)(36756003)(41300700001)(6486002)(26005)(6506007)(53546011)(38100700002)(186003)(83380400001)(86362001)(31696002)(2906002)(31686004)(5660300002)(316002)(66476007)(8676002)(110136005)(44832011)(8936002)(66946007)(66556008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8239 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0a2aa3b9-49a8-4815-53c8-08da9591bc22 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NzV6iSK9uC1QGO1CXNTOA+oS5nGUGTzSzyPcFhqk3aj8ixCUTdMq3RwUXXBwoqs+DyXEQsoDPbNakEBwspbjA4t4OzHk/feb17PRQWZqS6hkXaCIuCCa8URT/XBqtLQJlbIbpC6E+aMO2aRHIKq2AQ28JQmDgJXWKM0S/tpTTGSOaSAw5B/B3mV3yNPwO+ZcJ7YFja/vQkx/F6u+pG+Q4yiQoT0Db6k0GzGQKHQIX+hTGzvr8V0b6t2PE+y+sdf/XHqw3rRmBm0TWr4i09Qw24R1k6L+QyBHExiEHiM6yBnBonAdwZCzw4NUHBeoVZsWpb5WusUGy12w+BpZW6xBl3sY1EGDmXjyLYbrkvlRYJh9K3mXqpNeBwAWqIRIx7kDbNaX1rlw4c9B5s5GzU4zn0TssUyHPxaTmhmM5I4WMIwHxuhoalOkCztQQto1G8uEANk/4ZPYo9HZGxa1YRTjs0wRBkXsPAR0XMVlFJLXTAe2KrTcP166uQJ6cMWiVA0ofjEOPVvwYyYS+uxRP+gkmfJn9eKnwyhMpJAqs2jwbpuDH7z4E655C/B9sBwPmGb2GnBCzkdiRHVe9Et6y46bAbR1CsyIqInUQ7MZCsTo+haewMAbgpHOApDN3X3cAGQWSbgVxfcqnan2GWvvSld6p1+N3/h1AtIpumw2XgjW6EPY+k2xkvflfY0rKb322VN9fPBM1pJGhlUDV+v+LzLJIWswAwA/kmlo0V2b+bGLwMvfrnAECZk4q2sly+CFpzWTFtr3qtNSDcFgM1jSMlmSR2K5fw/R1oSTnc0NTqmUs0s0SEF6G+uxQwm5NNzvwxB3 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(47076005)(82740400003)(336012)(81166007)(83380400001)(8676002)(186003)(82310400005)(6506007)(2616005)(6486002)(40460700003)(316002)(41300700001)(31696002)(44832011)(53546011)(5660300002)(70206006)(36860700001)(70586007)(110136005)(40480700001)(6512007)(356005)(478600001)(31686004)(36756003)(8936002)(86362001)(2906002)(26005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 14:10:48.7425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 476ec610-0040-4b9f-d55c-08da9591c237 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9118 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 14:10:54 -0000 On 9/13/22 14:55, Keith Seitz wrote: > On 9/13/22 06:34, Simon Marchi wrote: >> With your patch applied, I tried re-generating everything: >> >> $ cd features >> $ rm *.c */*.c >> $ make cfiles GDB="/home/simark/build/binutils-gdb-all-targets/gdb/gdb --data-directory=/home/simark/build/binutils-gdb-all-targets/gdb/data-directory" >> >> And then git shows these files as missing: >> >>          deleted:    aarch64-sve.c >>          deleted:    cskyv2-linux.c >> >> aarch64-sve.c is not generate, so it's actually fine.  cskyv2-linux.c is >> generated, but we are missing the XML for it, I sent a reply to the >> patch thread that added it to ask the author to upload it. > > Bah. I caught aarch64-sve.c, but not the other. Thank you for catching that. > I will keep my eye out for it and update when cskyv2-linux.xml reappears. > >> >> When typing just "make" in features/, I get this diff: >> >> diff --git a/gdb/regformats/or1k-linux.dat b/gdb/regformats/or1k-linux.dat >> index 7b64646fc65a..9a9f8a640188 100644 >> --- a/gdb/regformats/or1k-linux.dat >> +++ b/gdb/regformats/or1k-linux.dat >> @@ -2,7 +2,7 @@ >>   # Generated from: or1k-linux.xml >>   name:or1k_linux >>   xmltarget:or1k-linux.xml >> -expedite:r1,npc >> +expedite: >>   32:r0 >>   32:r1 >>   32:r2 >> >> Probably a separate fix, but I think we need >> >>    or1k-expedite = r1,npc >> >> in features/Makefile > > Just typing "make" in features does nothing here. Am I neglecting to do > something? > >>>       rs6000/powerpc-32.xml \ >>>       rs6000/powerpc-32l.xml \ >>>       rs6000/powerpc-403.xml \ >>> diff --git a/gdb/features/arm/arm-secext.c b/gdb/features/arm/arm-secext.c >>> index 39ef4afb05f..c71cffd2db6 100644 >>> --- a/gdb/features/arm/arm-secext.c >>> +++ b/gdb/features/arm/arm-secext.c >>> @@ -4,7 +4,7 @@ >>>   #include "gdbsupport/tdesc.h" >>>   static int >>> -create_feature_arm_arm_m_system (struct target_desc *result, long regnum) >>> +create_feature_arm_arm_secext (struct target_desc *result, long regnum) >> >> This change looks good, it was obviously wrong before.  But I don't see >> any call to create_feature_arm_arm_secext in the code base, so what is >> the point of this file?  Should the arm tdep code use it?  It might be >> worth asking in the thread that added this file. > > Before submitting, I did email the original author, who CC'd Luis. I've added > him (Luis) to CC so that he can answer here more definitively than any > paraphrase in which I might introduce confusion. > > Keith > Right. So the org.gnu.gdb.arm.secext feature + registers are only reported by remote targets. We don't actually use this C file or its functions in GDB/GDBserver. I think it should be OK to remove these files (Linux doesn't support m-profiles, so it is unlikely this will get used in the near future). We should add documentation about the feature, its registers and its purpose somewhere, either in the code or in the manual. I can do that. Otherwise the changes look OK to me. Watch out for the dynamically-generated descriptions (like aarch64-sve.c). I plan to submit a patch to remove aarch64-tls.xml and make aarch64-tls.c generate the feature dynamically. Is there something we should be aware of when adding such files that don't have corresponding .xml ones?