From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 67DC83861C56 for ; Wed, 11 Mar 2020 03:38:08 +0000 (GMT) Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5C11C1E4C2; Tue, 10 Mar 2020 23:38:07 -0400 (EDT) Subject: Re: [PATCH v2 3/6] Cast to bfd_vma in arm-tdep.c To: Tom Tromey , gdb-patches@sourceware.org References: <20200225222243.8260-1-tom@tromey.com> <20200225222243.8260-4-tom@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 10 Mar 2020 23:38:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200225222243.8260-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2020 03:38:09 -0000 On 2020-02-25 5:22 p.m., Tom Tromey wrote: > Some arm-tdep.c data structures use a bfd_vma. A couple of spots will > warn about an implicit narrowing cast when building a gdb where > CORE_ADDR is 64-bit but bfd_vma is 32-bit. > > This patch silences these warnings by introducing an explicit cast. > This seemed both simplest and correct. Did you consider changing arm_mapping_symbol::value to be a CORE_ADDR? It would seem even simpler and safe to me. Simon