From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fpye=A2=suse.de=tdevries@sourceware.org>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
	by sourceware.org (Postfix) with ESMTPS id BAFBA3858D33
	for <gdb-patches@sourceware.org>; Fri,  5 May 2023 13:27:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAFBA3858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out2.suse.de (Postfix) with ESMTPS id EF19C2002F;
	Fri,  5 May 2023 13:27:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1683293261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7zKfhSQQ0a+KjMdnQQ+MfU/Yn+EEulmCicN43fSot0o=;
	b=OCZgLiBE5FlVMX6sgnEnmDHOctwJuR8U2//xZG0thfhf/NMNRx8dD0pZTeXgCVU014O3me
	9/DVK6zoi9Fu8LXg4AMMhxFexD7CDZ5H+nAIIZH0d4P0NqMBg98Q8u9jIpXvFKkv75dT/l
	cgwJMd/NaN/M+0IyVdJZ+X7NgAV0O5A=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1683293261;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7zKfhSQQ0a+KjMdnQQ+MfU/Yn+EEulmCicN43fSot0o=;
	b=YDmGskqMrsyF9pw7TNHtbTilIopPCeWh8KzoPm2DAIl6Ve1jESzEVXhYHe0W0v8RZPPa5M
	xdwMErgDWg85zKAA==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB86413488;
	Fri,  5 May 2023 13:27:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id f1uSNE0EVWSkVQAAMHmgww
	(envelope-from <tdevries@suse.de>); Fri, 05 May 2023 13:27:41 +0000
Message-ID: <a62c261c-941f-dc09-3f06-708b249b88dd@suse.de>
Date: Fri, 5 May 2023 15:27:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v2] [gdb/cli] Fix wrapping for TERM=ansi
Content-Language: en-US
To: gdb-patches@sourceware.org
References: <20230502133258.8380-1-tdevries@suse.de>
From: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>
In-Reply-To: <20230502133258.8380-1-tdevries@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

I've submitted a v3.

Changes since v2:
- testsuite part is now just removing KFAILs
- I've dropped the bit about "set width" semantics.  I still think it's
   worthwhile, but I think I should sent it as a separate patch
   (and I'm thinking about adding a warning when setting width to
   something different than 0 or the auto-detected width).

I'm fairly happy with the v3, and intend to commit end of next week, 
unless there are comments.

Thanks,
- Tom