From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42063 invoked by alias); 23 Mar 2018 19:50:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41566 invoked by uid 89); 23 Mar 2018 19:50:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy=picture, UD:defs.h, defsh, defs.h X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Mar 2018 19:50:17 +0000 Received: from ESESSHC008.ericsson.se (Unknown_Domain [153.88.183.42]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 8C.5F.03693.67A55BA5; Fri, 23 Mar 2018 20:50:14 +0100 (CET) Received: from ESESSMR503.ericsson.se (153.88.183.112) by ESESSHC008.ericsson.se (153.88.183.42) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 23 Mar 2018 20:50:13 +0100 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMR503.ericsson.se (153.88.183.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Fri, 23 Mar 2018 20:50:13 +0100 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Fri, 23 Mar 2018 20:50:13 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.63] (192.75.88.130) by DM5PR1501MB2006.namprd15.prod.outlook.com (2603:10b6:4:a1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Fri, 23 Mar 2018 19:50:10 +0000 Subject: Re: [PATCH v4 03/10] Commonise tdesc_reg To: , CC: References: <20180322084429.26250-1-alan.hayward@arm.com> <20180322084429.26250-4-alan.hayward@arm.com> From: Simon Marchi Message-ID: Date: Fri, 23 Mar 2018 19:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322084429.26250-4-alan.hayward@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR18CA0012.namprd18.prod.outlook.com (2603:10b6:404:121::22) To DM5PR1501MB2006.namprd15.prod.outlook.com (2603:10b6:4:a1::36) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f561e928-8c25-4919-e31d-08d590f74992 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM5PR1501MB2006; X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2006;3:v/ULeLueUPDtdSdVlYZw0gYvBr6WY6dRSupKJP4wLD+/KgcbXB62TOegwQ5UuOOIp7HGbRFmf/YK9MwY3ClbJCSsJGCsBnQsXtzu/QAvWWkPZL0KzfVqQveKfJCD6njbtWI12i6RHioXRd6hl7+NEYKJi+QSGRZuKGrhmeLJJLLCdQso/enM9wCRITtSB5jd2LDs6qBCTF8HgfB31SRbhZe35K4jCp+dQETYnA7UrWUKnm4yEEkjMNgWqtaYkFoS;25:Mp3urMPjRlyRcakc6PuNYhN161KiMlAvE4agxbJrxqvA2AEHlTeGYLfurkkulhFANMd+WPY06b61muCF3jHUhuzv+l6Rpcpo7KG+47Uhi4dNe93qwqpAzLzu+BvARvQF0CYRfwQX8ELdnIr4CYQuhM6suY14g9X3/4lbU48MNpV5ZiDTlq+blIW1fcweBAA7KYLpZvLP6fJqCvsFJ7XVZXRyFuKhzV5iITLFr6ANfZwlGaV3Ouiazcv5CkMi25hHUHlCNUtoRQfyyPPRA9ajEzhiQ80EK8kqPbU3wGTKk5j2SU8E10Q2OmQSRwacDkiLNtzqMqBpg9H39P1U7s9zPA==;31:U78XF+M3LrY9xYKHXIaohuACPSG9N42OyBBFewFaOr7THWh5h9VGoF9tWHnnTYWZ0Z32h8EaSalV6MJ5JmQh9OEH+jpR9T73pEMONB50at9shS+5p6lSGGFEuvORgYRRHaKctpeWT2kNI/YImZOc+/liJSO0vvCDqYGOuvsCUk7yjEivG6najiLq658+O6Z2WrzHvkXDcUjpmvGVMArGMwhRodAnUlxAXw584c6J7Ko= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2006: X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2006;20:SxBuoiNLUUAhqDENtR+r9R7BlnMr5CUoya3x+IPKy27Kh6kt35W6oXs8YJ40Nh0CrfUAvcqo+0a8mRxgMLYZzy7m+ftgQMcpSwBXpnXW3AZacZQ2zJ56dCy2q+pS4HaBmZr0PsRqeIn2W5AJh74wGKQKM9I8QKuPc3i7RRunEEkp9sfpjZ0akVPJ8t2MEVH5mIv/oQUKDdWse1iMKwLDARhDfc4f1Q6MWmcusx2LLa5ClDW670XObo6Mdm4eZt2ruku5aM+z5qAeJBuWx58QrrxXgzTjTeYh2FdRzZB/FP0FwH1QnePXn3iRpg4v6+5ENNCiPBB0yBeTx2gB9guVIxGNaSei0pyrNqvE7bnwaJ3YhrhKmSf9vprkKONVvZ0LCDvG9+r+2Qs1J8Nwmq47fRHYn+st4nAPsGFVjzxZkLGwAIsYWqhm/HwAKc/Uqb1feXOdPxmY4XUCuW1NKdf2OSi70xYCBq+iO5aNyjDQRmKv1IbyImeLisugwYGdtoqh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(180628864354917)(22074186197030)(788757137089)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231221)(944501327)(52105095)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR1501MB2006;BCL:0;PCL:0;RULEID:;SRVR:DM5PR1501MB2006; X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2006;4:er6DrG0MgfmXHu++jQsCn/y1AkFp5mw+UzOG+la37XPJhsbtqnK1EGoL9xYGxwGxe3IgBp7xXJjkXwHzq/e8rte2SiIQK8UE69FRG5st09flps9ZswtdGsWDtj0Jl+UMGQzw3Zi+cb+uNBVYkJLVbI+XPeHyyjDwN7VFvi7mKrsvNZbjPfAelW59UfMDyfMMqhuyqe3FKaJfT6BEijSvMOn6pRBxOrSoPeIij1TmPD4HM1ubMs2Za5wPYvfTRbO7TwtVNqrdElwlgWfZ98w9XQ8VzcYoPYaJP5r/A09sLppnsHDTd+RO5sZBHrZmcnRppkPpabzI9i/rKQ/4pBGzlR56M4BWITAugWSrAnlbaQKwfyF7Lz5zFxgl3QnYsTwwY3tl8cUFzQVoezLvWK717ErdDDfxldyvCD3qlqYSuE1M6Ii0XaNeirh+6ej01gx9 X-Forefront-PRVS: 0620CADDF3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(346002)(376002)(39860400002)(396003)(366004)(39380400002)(189003)(199004)(377424004)(76176011)(6116002)(16526019)(3846002)(59450400001)(26005)(446003)(58126008)(186003)(316002)(68736007)(16576012)(49976009)(2486003)(52146003)(52116002)(11346002)(23676004)(2906002)(50466002)(53546011)(31686004)(386003)(478600001)(966005)(106356001)(4326008)(53936002)(230700001)(6306002)(25786009)(6246003)(86362001)(65826007)(8676002)(64126003)(5660300001)(305945005)(6666003)(31696002)(7736002)(36756003)(6486002)(105586002)(81166006)(8936002)(81156014)(65956001)(66066001)(65806001)(229853002)(47776003)(97736004)(956004)(2616005)(78286006)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR1501MB2006;H:[142.133.49.63];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1MDFNQjIwMDY7MjM6VHd5T2RZY2FGLzZEdzYzVnVKME1ZM2dH?= =?utf-8?B?SSs4TFBDWFJLVUprUUhDcU1TWkdzN25XcXB4Y1kzajRQRko1TnI5bGJuSWhI?= =?utf-8?B?ZWRWNjRFVmVzdXJlbWhzaTl6Z3JNSU9STXdNZWtob1pUTzViWWp4dXJZWTBE?= =?utf-8?B?QUg4T2RkZHJEL1VBMnA2NDY3TnRtVE9JUE1MN1NuaU5SYThCQk9SVFZFblN5?= =?utf-8?B?bDZGK0ZneW1hWFpraUZ1TUt2TDRtb2phb21vZWZuTzdPaTV3d2hZOXZZLzVY?= =?utf-8?B?cUwvQnhrODdVVDllOUdzbUFMSlNhUXdpZ0lFd3Y4WGxnbUpPVVZ1UFp1T2lN?= =?utf-8?B?dXFnL1pSTXRZd2N0V1pqNnlqaUpMMWpSbU9ZZ3h3aCtqL1JjVkNyRVVlWWZv?= =?utf-8?B?VXI1aUM3cWUwY1FYV2F2aHVSTXdnOE1SZnJwNTZqWStsbzQ5RVR0Y3l1OVFF?= =?utf-8?B?Yzlyd0hpcWZvYVQ3QXdyTnpGaVM0SlBWdzRwbFIyZVpTVmxSNFJMZFNiQTdp?= =?utf-8?B?dnRtMnZUcnRtQmRoU2tRRjhnR1pzTytRb1VtWFMySjAwZWZ0aFJjNVdVbEpL?= =?utf-8?B?eEJXd0xBdDBvQmZ0TGlkeHJmREJ1SnFqT3pxQ2YzSlhaTGJyZUpTMDZkYnNR?= =?utf-8?B?dk8weHNOUkVEV0lBM2hvbWdHMVBqd2lSU0I5QXU1NEVDR295OEowc0ZzVmJr?= =?utf-8?B?ZjczWUtvb3NQREJnTzZ0OXVMVm9YbXUxVXQ1Q2l1d1RIZnNZc1lyOFA3aHJQ?= =?utf-8?B?bXViS1ZiNVcxaEVtOFBLYlNXNVk4MXp5ZE1jc0duWHpkclZlUG11ZkxiT2tt?= =?utf-8?B?dFFDTHM4RXdKU1UzTmV0SmhDMGUvbVdOTk1UOGVNWlFKaFlRc2c2RDd6ak55?= =?utf-8?B?azFiU0phR2QxRCtMeW1XTmNWazBvZHBWaW9VNFltdVJucm5iL0YzT0dRb0hW?= =?utf-8?B?c3loTU5DSzU0SXRjbUs5QmJ1cS92aE9KS0R1bkNWdngyQllzMzhaSVJYRnNh?= =?utf-8?B?bEIwT2VnMFUwclI5SHpITHBHb09rNEY3a2kzNVFiY3JFaDdVaU1TUU41V0VJ?= =?utf-8?B?RCtyU3pCS0pZOHpRVVJjdkVobWVzUElFZE1VSjcvK2J3UWJFQUxuTTVHZkQ3?= =?utf-8?B?Z243TEEwclZJT3RsMlpiU2taSEpDY1JxUEwvTm1wYnpUZ2NScXRQc25rOHNK?= =?utf-8?B?UjFYMTdmQ2p3d1c5VkVzQ2wrZjFaWUZMdHBEdWRrc2tOQlFIUlM1c0N1b3VU?= =?utf-8?B?NjU2ajlRSlRnZ3ZkZ3hVVndyL016RVpqaGZSUVRuaEdsNHBnTUpPNWQxUzI2?= =?utf-8?B?Yi9acFRMR1hrc0QrVWFCY1NRMS9nRG5ZeDNPOVl5UnNkMk9LMndIbHVxQTQ3?= =?utf-8?B?YUNheVFwajRWVitQZ0VMcWRaYXB5Y2NWTWxtbjhuVlgvQlBKS05mc2VKTmJJ?= =?utf-8?B?c21uQkVjVURFTDIrdEU5VllJYkZYOUhkeklTOWxSZFB3STQ5dW1tUFYxS2Zm?= =?utf-8?B?T01pb1FwMDc3UXNYekx6LzE5OVVocURhakJiTzVtOHFrdS9hL3U3UmVvL3E4?= =?utf-8?B?S0xDdHNyNCtTSzJ5L1FCdG03anpoTjNaWXlqZFQrcm1ORHcwN2J3aytpNWFM?= =?utf-8?B?aUo4S0hhcHBxazU5ODZrbEs5NmlpVXNSMW9HUU9GeG04dWNHMFB3elNUZ2J6?= =?utf-8?B?djIySzAzaEpWQmtZaER4QTVxYnZ1OURpdGc3U1N1T2RVMTFkZ3Q5VlFkVGdJ?= =?utf-8?B?cVN2Q1VwcW9vRzhPZlRGV1ZQbW0wN2ZUcTg3R2s5UDVQTkJlODViTGtpNjhB?= =?utf-8?B?YVZaQTI4UUM4dWdYLzBiNUtOOHZqQ0FyYkJXVFlXcTRlM2Q0R3daQytvU0E0?= =?utf-8?B?NDNIQUZOTE1oWFJQUUF2RnM5bE5KeDJ3K2JoZUpyaWlkSFhyVTZwQ3NUN1Av?= =?utf-8?B?MDFpUHRMb1lEZktFZ2xtaGJOR3hicFdwcnBrWWRKSjhEdjFwUHpleFZTclBG?= =?utf-8?B?UGJDZGd0UEFZcUVWUUlubkswWFN6eFUxTzBnWkhBPT0=?= X-Microsoft-Antispam-Message-Info: hrmvKjqnKkFJ7sh9XmQKsxWM5iq106ifXqbPQlV4ToOYbbETdh8TwGxMgLRzu1rUhx+fXgp/f2GFSET0HEy9Ckf8wvrmB5hqTJMa8mJ2YgSeEtE+RopP4vUlNTjI9e51SoP25TcrtvTJ4O84vHbDwJl5K1CrDMQW5T39GCFcytuYODGMpo+LDse03FfZRepy X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2006;6:UXQsWeip6cilt4n9HdTSTPVk/VOfBOzZ+7n2MTpNvaTRkHAkSuLlwsNMUZQ/FOWeUCsEF6FQ8Yk5HCMLUMbcXtwdu5u7lk5+CyEspb4UV59tGWIRzygIdfhhvCmcSgORC2bhWzR9XX8RG2ldbe2Uo6b4WAqWf9+VE7rATVv7mJXBtU582QQnTYQgGs0IYaredvJatTe5Zi24+fu6Wq95V9OVLjmrDuNdlyxunvausb1l8y1TJ4jIZzGFRU6dmlgZPO/0Q4LmSNTHhOvwdJnL/ii5M7roQh9x9egeFOda9LNbytvG3PhtuSIWcAzdtw8tJlUERnirhyhf6aOK3EgYhcMp7IBPoFfdaosFx89YVmw=;5:nnq3GWOoORXopJSuJMPKRku3hHjRlb5DXpHG4Mrw6SNFDir46P1tQZKkQfYr4sGFEO3UXcKNoOJWy2UpS8I8jc/FbxCWmOqVkgBiBWsr9oaQSpXYPg3HSIPXZfrAy9RAEZ6+KanwUgtCD11/ebBu4wbKMSIv4uiZYPcOKaL0RLI=;24:dJHSOi2plLaN7gRmIms9GDgB+2Uu6KmfAYsy0pspqx8or0/9Lopg0Ao//93t5vgnQ6fnGaoqK3Anm/XtTYiHw91HQjQuRq/MdqSbqb16XC4=;7:RM2CXeHbvbFhFQn5GXVfTa7iq/aBF6TGyX2JYuevG3sdCxksLDteyOFQ8kmSiw/tSqFB670bY55K0QPmEwbUhZfseZmNGXMr6CkR8KfgFNz6uoWpEnqAebc8ClYHK4WOuv+Mx77vjLUD9IRD8R6fpnJFqExzNq+Cw+wXJRjVtp+wdVlPkd4xtDT72+AJD9wuFTv3PobQ7GDHWOc40hyVTIzE+crmhKZk2Ixk9cZJQS3mS9ydG4a7Tz9gZZR29Dah SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2018 19:50:10.5196 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f561e928-8c25-4919-e31d-08d590f74992 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2006 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00452.txt.bz2 On 2018-03-22 04:44 AM, alan.hayward@arm.com wrote: > From: Alan Hayward > > This patch commonises tdesc_reg and makes use of it in gdbserver tdesc. > > gdbserver tdesc_create_reg is changed to create a tdesc_reg instead of > a reg_defs entry. The vector of tdesc_reg is held inside tdesc_feature. > > However, other modules in gdbserver directly access the reg_defs structure. > To work around this, init_target_desc fills in reg_defs by parsing the > tdesc_reg vector. > The long term goal is to remove reg_defs, replacing with accessor funcs. > > I wanted to make tdesc_create_reg common, but I cannot do that until > the next patch. > > I also had to commonise tdesc_element_visitor and tdesc_element. > > This patch only differs from the V3 version in init_target_desc(), > where I now use reg_def references as introduced in the previous patch. Hi Alan, I have just a few superficial comments because I don't have the big picture yet, I'll continue with the next patches and might come back. > 2018-03-21 Alan Hayward > > gdb/ > * Makefile.in: Add arch/tdesc.c > * common/tdesc.c: New file. > * common/tdesc.h (tdesc_element_visitor): Move to here. > (tdesc_element): Likewise. > (tdesc_reg): Likewise. > (tdesc_reg_up): Likewise. > * target-descriptions.c: (tdesc_element_visitor): Move from here. Spurious colon after the filename. > (tdesc_element): Likewise. > (tdesc_reg): Likewise. > (tdesc_reg_up): Likewise. > > gdbserver/ > * Makefile.in: Add common/tdesc.c > * tdesc.c (init_target_desc): init all reg_defs from register vector. > (tdesc_create_reg): Create tdesc_reg. > * tdesc.h (tdesc_feature): Add register vector. > --- > gdb/Makefile.in | 2 + > gdb/common/tdesc.c | 40 ++++++++++++++++ > gdb/common/tdesc.h | 111 ++++++++++++++++++++++++++++++++++++++++++++ > gdb/gdbserver/Makefile.in | 3 ++ > gdb/gdbserver/tdesc.c | 53 ++++++++++++--------- > gdb/gdbserver/tdesc.h | 5 +- > gdb/target-descriptions.c | 116 ---------------------------------------------- > 7 files changed, 191 insertions(+), 139 deletions(-) > create mode 100644 gdb/common/tdesc.c > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 44db1937b6..f1d2f0193a 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -966,6 +966,7 @@ COMMON_SFILES = \ > common/run-time-clock.c \ > common/signals.c \ > common/signals-state-save-restore.c \ > + common/tdesc.c \ > common/vec.c \ > common/xml-utils.c \ > complaints.c \ > @@ -1443,6 +1444,7 @@ HFILES_NO_SRCDIR = \ > common/run-time-clock.h \ > common/signals-state-save-restore.h \ > common/symbol.h \ > + common/tdesc.h \ > common/vec.h \ > common/version.h \ > common/x86-xstate.h \ > diff --git a/gdb/common/tdesc.c b/gdb/common/tdesc.c > new file mode 100644 > index 0000000000..a5f2de4b5b > --- /dev/null > +++ b/gdb/common/tdesc.c > @@ -0,0 +1,40 @@ > +/* Target description support for GDB. > + > + Copyright (C) 2017 Free Software Foundation, Inc. 2018 > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#ifdef GDBSERVER > +#include "server.h" > +#else > +#include "defs.h" > +#endif We are aiming to remove all uses of #ifdef GDBSERVER in the code base, so we shouldn't add any. You might want to read this if you haven't seen it already: https://sourceware.org/gdb/wiki/Common Replace this with #include "common-defs.h". You can also remove the same snippet in common/tdesc.h. Header files assume that defs.h/server.h/common-defs.h has been included already, so they don't need to do it. > @@ -236,26 +261,10 @@ tdesc_create_reg (struct tdesc_feature *feature, const char *name, > int regnum, int save_restore, const char *group, > int bitsize, const char *type) > { > - struct target_desc *tdesc = (struct target_desc *) feature; > - int current_size = tdesc->reg_defs.size (); > - > - tdesc->reg_defs.resize (regnum != 0 ? regnum + 1 : current_size + 1); > - > - while (current_size < regnum) > - { > - struct reg *reg = &tdesc->reg_defs[current_size]; > - reg->name = ""; > - reg->size = 0; > - current_size++; > - } > - > - gdb_assert (regnum == 0 > - || regnum + 1 == tdesc->reg_defs.size ()); > - > - struct reg *reg = &tdesc->reg_defs.back (); > + tdesc_reg *reg = new tdesc_reg (feature, name, regnum, save_restore, > + group, bitsize, type); > > - reg->name = name; > - reg->size = bitsize; > + tdesc->registers.emplace_back (reg); This doesn't build, I guess it should be feature->... Simon