From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B98FE3858D33 for ; Wed, 1 Mar 2023 18:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B98FE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 618401E0D3; Wed, 1 Mar 2023 13:45:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1677696340; bh=+azfDvC2v8e5eMqlg5q+CjjURhWuGPGHkGPmqdc9YFg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=KeVwN5SqG1dN/8meyj0QXq5FW1NK0vokhjjOMjNTzWYaKp7YW9SfhjBX/NzaEHv80 qdZsuU9xJE1yU+Q/lzrMXuAi4DM5AVpgozBYnWk7jeYtI3IJL8o36J22OjHXTk2iLh pnNk2BYvOnY36dxRsW9MVUlLZUjsDF2pqpKxgudE= Message-ID: Date: Wed, 1 Mar 2023 13:45:39 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/2] Two minor dynamic property fixes Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20230301-submit-baton-stuff-v1-0-567d536a8245@adacore.com> From: Simon Marchi In-Reply-To: <20230301-submit-baton-stuff-v1-0-567d536a8245@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/1/23 10:18, Tom Tromey via Gdb-patches wrote: > I noticed that dynamic properties were not type-safe or const-correct. > These two patches fix this. Tested by rebuilding. > > Tom > > --- > Tom Tromey (2): > Make gdb property batons type-safe > Use const for dwarf2_property_baton > > gdb/dwarf2/loc.c | 14 +++++--------- > gdb/dwarf2/loc.h | 2 +- > gdb/gdbtypes.h | 11 ++++++----- > 3 files changed, 12 insertions(+), 15 deletions(-) > --- > base-commit: 2c29b1ed19711fa2a16558015e5a6b46a09aefeb > change-id: 20230301-submit-baton-stuff-70d3db0cd50b > > Best regards, > -- > Tom Tromey > I sent a general design question on patch 1, but otherwise: Approved-By: Simon Marchi Simon