From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5DB063858C83 for ; Sun, 27 Mar 2022 01:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DB063858C83 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22R1tcGb027729 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 26 Mar 2022 21:55:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22R1tcGb027729 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9AF851F3B5; Sat, 26 Mar 2022 21:55:38 -0400 (EDT) Message-ID: Date: Sat, 26 Mar 2022 21:55:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: GDB 12.0.90 available for testing Content-Language: en-US To: Eli Zaretskii , Joel Brobecker Cc: gdb-patches@sourceware.org References: <20220320055815.2A90FA4D6C@takamaka.home> <83sfr4a93r.fsf@gnu.org> From: Simon Marchi In-Reply-To: <83sfr4a93r.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 27 Mar 2022 01:55:38 +0000 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2022 01:56:12 -0000 > I've built this pretest with MinGW on MS-Windows. It generally builds > cleanly, but I found 2 issues. > > First, there's this compilation warning when compiling infrun.c: > > CXX infrun.o > In file included from btrace.h:30, > from gdbthread.h:29, > from infrun.h:21, > from infrun.c:23: > target/waitstatus.h: In function 'void stop_all_threads()': > target/waitstatus.h:175:13: warning: 'ws.target_waitstatus::m_value' may be used uninitialized in this function [-Wmaybe-uninitialized] > 175 | m_value = other.m_value; > | ~~~~~~~~^~~~~~~~~~~~~~~ > > Is this a real problem? I think this one is not really a problem. It complains about this code: target_waitstatus ws; ws.set_no_resumed (); return {NULL, minus_one_ptid, std::move (ws)}; When settnig `ws` using `set_no_resumed`, the union field ws::m_value is left untouched, meaning it contains random bytes. When we move `ws`, we copy random bytes. But that doesn't matter, because the destination target_waitstatus is of kind TARGET_WAITKIND_NO_RESUMED, so doesn't care about m_value. Simon