From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E10FC3858404 for ; Mon, 23 Aug 2021 16:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E10FC3858404 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17NGQPnh002174 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 12:26:30 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17NGQPnh002174 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 065641E813; Mon, 23 Aug 2021 12:26:24 -0400 (EDT) Subject: Re: [PATCH] Replace deprecated_target_wait_hook by an observer To: Patrick Monnerat , gdb-patches@sourceware.org References: <20210822164256.144875-1-patrick@monnerat.net> From: Simon Marchi Message-ID: Date: Mon, 23 Aug 2021 12:26:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210822164256.144875-1-patrick@monnerat.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 23 Aug 2021 16:26:25 +0000 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2021 16:26:50 -0000 On 2021-08-22 12:42 p.m., Patrick Monnerat via Gdb-patches wrote: > Commit b60cea7 (Make target_wait options use enum flags) broke > deprecated_target_wait_hook usage: there's a commit comment telling > this hook has not been converted. > > Rather than trying to mend it, this patch replaces the hook by a > target_wait observer: > > waiting_for_target (bool entering, ptid_t ptid) > > Upon target_wait entry, it is notified with entering=TRUE and ptid passed > to target_wait. Upon exit, it is notified again with entering=FALSE and > ptid = event ptid returned by target_wait. > > This change benefits to Insight (out-of-tree): there's no real use of the > late hook in gdb itself. Hi, If that works for Insight (I presume it does, since you are sending this patch), then this is a welcome change. Can you show to the corresponding change in Insight? I'm curious to see how Insight uses this. But otherwise, the change in gdb looks good to me. Simon