From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 222723858C2D for ; Fri, 1 Sep 2023 17:34:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 222723858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693589648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KLFzaYHNODQ7ciL1wvb2OHNTNuOZUh0s1JHwjUs3pEM=; b=IggF8O9FljGQ2tqhF0sz1h9K4WtacB/H2B3+51NNLRFJWdQdWa11f2rUIzlWQCxEOj8bY4 ntUr1h+xPe11kSwnTXwTgUk4SfDbGhYcOIEo3c0OnDbbdxpmt4/JawI5raNTbAqWx+LcQg 2DTX0hK18D64cEXXt5OsJwN2WRciGiQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-314-W5KuOT09NhCzKyM8Zzk8eQ-1; Fri, 01 Sep 2023 13:34:05 -0400 X-MC-Unique: W5KuOT09NhCzKyM8Zzk8eQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 577A292FD01; Fri, 1 Sep 2023 17:34:05 +0000 (UTC) Received: from [10.22.32.236] (unknown [10.22.32.236]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A8F321D4F3D; Fri, 1 Sep 2023 17:34:05 +0000 (UTC) Message-ID: Date: Fri, 1 Sep 2023 10:34:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Fix two varobj bugs To: Tom Tromey , gdb-patches@sourceware.org References: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com> From: Keith Seitz In-Reply-To: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/1/23 07:47, Tom Tromey via Gdb-patches wrote: > This series fixes a couple of small varobj bugs, and includes a couple > small cleanups as well. > > Regression tested on x86-64 Fedora 36. I've looked over this series, and I don't see any issues. Reviewed-by: Keith Seitz Keith > --- > Tom Tromey (4): > Allow pretty-printer 'children' method to return strings > Remove dead code from varobj_set_display_format > Remove variable_default_display > Fix bug in -var-evaluate-expression > > gdb/testsuite/gdb.python/py-varobj.c | 28 ++++++++++++++++ > gdb/testsuite/gdb.python/py-varobj.exp | 61 ++++++++++++++++++++++++++++++++++ > gdb/testsuite/gdb.python/py-varobj.py | 37 +++++++++++++++++++++ > gdb/varobj.c | 39 ++++++++-------------- > 4 files changed, 140 insertions(+), 25 deletions(-) > --- > base-commit: b47a4f92de5c12ac8bdac57b0413e3e05d411832 > change-id: 20230901-varobj-fixes-9926a7876ec6 > > Best regards,