From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by sourceware.org (Postfix) with ESMTPS id 430693858432 for ; Fri, 5 Nov 2021 13:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 430693858432 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f51.google.com with SMTP id d3so13697537wrh.8 for ; Fri, 05 Nov 2021 06:20:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XgfqwwnxcINgXxmmBCS6Oaih6bJLrO77yjvv0lAVcHg=; b=ZG+ch8U8BJ+T/UwKl37tkbMEsLg9jDoJdJVgX8o/29OxdXHB43l9bdRE/sM6CR+2Qj Tt1yV+ZzQkDUtY7msJWOoE1b3HlQkwf+KDivYZj2+cG54gz7BGRDkhZZzbQzGger19bg HT7TfbZhg0145j4NjlgOPW3CjkcxYpZCE0J8xsMj61HpOFte28r+JPIIBPvs8cudQytV LTLEVSp2GVTLHomwn780rLxhx0929uP19Z3ajCNU0VuoayJoSq5bx6IzVGOalo117BEx 8DP9VSansMOoKWPP3B2m1DSYaMp9uIIUm+jbVPkrRmMS/9CXcYywWc4XjOsc5GR2AttH Cw6Q== X-Gm-Message-State: AOAM530HzfSdg1NFuMPxctQJ+WMzfASnhcPZbJxZfoFTe20SfRC0lBcw 9mIU1SYXcqReh4gj9FB/tVj1P83BQc4vNQ== X-Google-Smtp-Source: ABdhPJyE8bbBFjjGTyW2a9+tqqPGcnBlpf0ZPxv77ZeIw5un8O2pNt0Cx05dLLXDvAwJesCZs3eAJg== X-Received: by 2002:a5d:59a2:: with SMTP id p2mr23603092wrr.252.1636118447248; Fri, 05 Nov 2021 06:20:47 -0700 (PDT) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id n184sm9211834wme.2.2021.11.05.06.20.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 06:20:46 -0700 (PDT) Message-ID: Date: Fri, 5 Nov 2021 13:20:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.arch/i386-avx.exp with clang Content-Language: en-US To: Tom de Vries , Andrew Burgess Cc: gdb-patches@sourceware.org References: <20211104135559.5875-1-tdevries@suse.de> <20211105093300.GG918204@redhat.com> <20211105115404.GA1816063@redhat.com> <8074d4d8-fe21-bccf-3fb6-f4be2ea67f7b@palves.net> <1f6ed2db-5d31-9338-226e-3e1a5a7c225b@suse.de> From: Pedro Alves In-Reply-To: <1f6ed2db-5d31-9338-226e-3e1a5a7c225b@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 13:20:50 -0000 On 2021-11-05 13:15, Tom de Vries wrote: > On 11/5/21 1:55 PM, Pedro Alves wrote: >> On 2021-11-05 12:23, Tom de Vries via Gdb-patches wrote: >> >>>> No, but in gdb/testsuite/lib/attribute.h we do setup a compatibility >>>> macro for 'noclone', so there's definitely precedent for using >>>> attributes that might not be supported everywhere. >>>> >>> >>> Right, I'm aware of this, but that's a typical case where we have no >>> portable alternative. >> >> We actually do -- _Alignas is standard C11. This fixes the test as well: >> >> _Alignas(32) v8sf_t data[] = >> > > I was referring to the noclone, but ok, I was not aware of the _Alignas, > good to know, thanks. > > Anyway, in the latest version this is not relevant anymore, since the > precise alignment implementation has an extra benefit, as explained in > the post. > OOC, is that benefit important here?