From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 89BD03858D28 for ; Wed, 18 Jan 2023 10:55:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89BD03858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 680D320A0D; Wed, 18 Jan 2023 10:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674039334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHdppcefyyHSMbyJrcWeeNfalOuliLcVlsHCqZhIV8o=; b=pSpIUPHkrd0albwFmh+KqhWugPnyHNIzF8TOw8dRlWX6yVlPC5oImbz+EgjyeIRMviEP2/ UIJK3O0dfzMg2LFzqkYyShAcRrD77kEdPI8NEEVsbUQ7C8Crb8/1yiEws5FfWNE16xb+su AItK/7UqZfx2VRhei4PbhTeW0AJSOuE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674039334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHdppcefyyHSMbyJrcWeeNfalOuliLcVlsHCqZhIV8o=; b=qE3EWlg2KWRM+mjxXCHn4nkU9BkDdZ+kaYuK+oHarlJlY+j/+s9t8e4NMtgSpNX3OqOWRN TZC1uc/DDi2OsMDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 442E5138FE; Wed, 18 Jan 2023 10:55:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id g+R3DybQx2PQZgAAMHmgww (envelope-from ); Wed, 18 Jan 2023 10:55:34 +0000 Message-ID: Date: Wed, 18 Jan 2023 11:55:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2 version 2] fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp To: Carl Love , Bruno Larsen , Ulrich Weigand , "will_schmidt@vnet.ibm.com" , gdb-patches@sourceware.org References: <89331c26795e3f7743e1e068dce43b3c2dd53008.camel@us.ibm.com> <071f24ecf9b3a2bbbe8fee7db77492eb55c5f3ff.camel@us.ibm.com> <1d9b21914354bef6a290ac30673741e722e11757.camel@de.ibm.com> <3e3c9c40f07ab01c79fe10915e76ffa187c42ad9.camel@us.ibm.com> <122f5d2d3db9ef1979b0f8da927d005f32bba82c.camel@us.ibm.com> <011768e8-2b76-f8ed-1174-fbaa020b15e7@redhat.com> <78b464a1-e32e-c3da-85e4-7bfc322cc29f@redhat.com> <7848e9858b54e33e399b871774ffc0b5058c1736.camel@us.ibm.com> <65d44121-65f7-a212-79ec-07ce53c15ecb@suse.de> <9fe94c0979cb40979b0dea7693a901c2d9f66164.camel@us.ibm.com> <59417813-eb4a-baf8-4e5d-e225d6732f71@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/17/23 20:31, Carl Love wrote: > Tom: > > On Tue, 2023-01-17 at 18:14 +0100, Tom de Vries wrote: >> On 1/17/23 18:03, Carl Love wrote: >>> Tom: >>> >>> On Tue, 2023-01-17 at 17:55 +0100, Tom de Vries wrote: >>>> AFAICT, this has been committed just now. >>>> >>>> I'm having difficulty finding an approval, did it happen maybe >>>> offlist? >>>> >>>> Thanks, >>>> - Tom >>> >>> I just committed it based on Bruno's reply. >>> >>> > The patch has been tested on X86 and PowerPC with no >>> regressions. >>> >>> I will reiterate that I don't know much about PPC, so the best >>> I can do >>> is check for style and tests, but apart from a few minor nits >>> inlined, >>> it looks ok >>> >>> Tested-By: Bruno Larsen >>> >>> I thought that was an approval to commit. Is it not? >> >> Hi Carl, >> >> sorry, AFAIU it's not. Bruno has been helpfully reviewing your >> patch, >> but AFAIK he cannot approve it. >> >> This is an easy mistake to make though, given the used formulation, >> it's >> not the first time it happened, and it's one of the reasons we're >> trying >> to move towards replying with the Approved-By tag to make approval >> more >> formal, explicit and unambiguous. >> >> FYI, I'm working my way toward reviewing these patches, and have >> regained access to my usual powerpc machine, so I'll try to >> reproduce >> the issue you're seeing. > > OK, thanks for the clarification on the process. In the past, I have > had people explicitly state in their reply that they could not approve > a patch but were just reviewing and commenting on it. > > I will be sure to look for the "Approved-By tag" in the future. Sorry > for the mistake. > > Please let me know if you need me to revert the patch, make some fixes, > or? I've run into regressions due to the first patch: ... FAIL: gdb.btrace/rn-dl-bind.exp: test: reverse-next FAIL: gdb.btrace/tailcall.exp: reverse-next.1 FAIL: gdb.btrace/tailcall.exp: step.1 ... So, please revert both. Thanks, - Tom