From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 577023858D37 for ; Sat, 11 Nov 2023 20:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 577023858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 577023858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699733813; cv=pass; b=ix6jlj7Zn2MgF6akOY36LBLCSxBDj2ypsMwAbNGZ7J5QcJ17gOHlRUaNpxhzJj29TfIWWsxltOq9k/18bUXFP/z71/I/MeOzeCBECrAqK3gZXjHqi4A1MeZ3RITWOOEilUOLMwfO+KV+SRGc5s1NMlDtinGyWoMKY8/vAkU1DAg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699733813; c=relaxed/simple; bh=dAqfo9XFWxUzZwTA4++JWfIIZ/bsEOYi222sIiY1WMw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=thuRDCYOSmk6uQE0572heJDwOWG2Bhg62q97EquIo0YhsmhnRxmkLbGugusSvAoVKWoeo8xgDkKVHIkt61HP93Vtmfnk70GDeX8RJR1j3ntYQHwLK4ImA1bK6YlYGS/0qpgSA0AKqTPuXgGw7BovQUtyk+mZtdo0uZTdtBahGRU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4SSRmh1Fpqz3Byt; Sat, 11 Nov 2023 20:16:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SSRmh0WHRz3PJr; Sat, 11 Nov 2023 20:16:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699733812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iv69MBEphWpZ3VijpYWueHhoVbkhgENnCBPLkytscFo=; b=hJ2jpCUs3Kwlboouf3RQzJDChit0Nh4xXLXqpSt9BJViSbnW1Nf4aWkGTsnSxd/f2qbCfj ZezKLCs6NSkhWdeMiYFNvo0kTxmNsAme/GczzbRJOolJOQUDI3X6T6tbRLIaA2rt8t1o0c pKOZ9CtHQz0F+Fa+w31mUQSSfVhc/CCNReQmE3gu+xCQdfanuKFJCHIkWIqc8ypv6Q6Hjq oZ6H66706jfPt5YSUpxcFUCLyhbYO76BNOa+2ibF3jkdUb+liwjxt3BUikBUnn42JIt3QJ nNHj9gO0j6mKfvD1Y/GMTPAFvOcrTv2iOvkh1vAWNiOgmVtK2eYdZTmj9UTkGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699733812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iv69MBEphWpZ3VijpYWueHhoVbkhgENnCBPLkytscFo=; b=pWeyJzEqwKufjGwJO1XObxk/VnfLK+Jq7pn+P3YVx/J5t3StHL8G0D+NJeQpl93nyvrdBt Eam07pKKcFKLwfYueUpZfIF3W0/QIhteV5xkiiqIWpvxzJJ4H4r84+bTSKLSA4JyqpKyqx Btrc2xzeFWyZbhAs8RyBm+sQFtQsdt44LXnRbzaY6jB4Jku2OHZGApXmqf8vnKthqiPmva ma20nED4ZCWARuNLCKR87LHD/nufsvUsr05sxoVkhLOVWVY/tjqfATHArIeUTGgs8/xTBn aka2cFQ5B7ep0ijaHyWa+cmiCsCLxcKTKI5AHzNgZpHTKnRlodUJlDg06Z9JRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699733812; a=rsa-sha256; cv=none; b=Weu0Rgu+3pzzAuqKXFZlr0SugF+JGFk082aX9STezfw6WLtNt1kQTDCsVXnDYY+EQjdPrM GiZH41A4K5YWTaDh3z9nuup/cDQc5QPmROAWP8eDpVw1DvJUiKjKNAO5Y8n54vsoGIphpA Dw9BRC1tG+VjtbxrLIkPPnxjbtFCs5QydiB90yD+utVJ0Rc1j3NVSmQptnsChhv52qbp26 Uc8r0eh1GgZYv0AtsFcgEftVTQ90muOoRQql01hBZTGVd8WN1IrTTTp2tEtW31YqGmv8fr b8RieSN4JT0K+kRzFb74YYFfhWG/Asak5tBqJm4Yh1judZVH8BJDi9SzSCXxFQ== Received: from [IPV6:2601:648:8384:fd00:8dc8:68:d931:e24b] (unknown [IPv6:2601:648:8384:fd00:8dc8:68:d931:e24b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SSRmg4FMnzkS0; Sat, 11 Nov 2023 20:16:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Sat, 11 Nov 2023 12:16:50 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/24] gdb: migrate i386 and amd64 to the new gdbarch_pseudo_register_write Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi References: <20231108051222.1275306-1-simon.marchi@polymtl.ca> <20231108051222.1275306-19-simon.marchi@polymtl.ca> From: John Baldwin In-Reply-To: <20231108051222.1275306-19-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/7/23 9:01 PM, Simon Marchi wrote: > From: Simon Marchi > > Make i386 and amd64 use the new gdbarch_pseudo_register_write. This > fixes writing to pseudo registers in non-current frames for those > architectures. > > Change-Id: I4977e8fe12d2cef116f8834c34cdf6fec618554f > --- > gdb/amd64-tdep.c | 39 +++---------- > gdb/i386-tdep.c | 146 +++++++++++++++++------------------------------ > gdb/i386-tdep.h | 6 +- > gdb/value.c | 3 +- > gdb/value.h | 6 +- > 5 files changed, 66 insertions(+), 134 deletions(-) > > diff --git a/gdb/value.c b/gdb/value.c > index 51dca972a587..5c18bb17a781 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -4062,7 +4062,8 @@ pseudo_to_raw_part (frame_info_ptr next_frame, > gdb::array_view pseudo_buf, > int raw_reg_num, int raw_offset) > { > - int raw_reg_size = register_size (get_frame_arch (next_frame), raw_reg_num); > + int raw_reg_size > + = register_size (frame_unwind_arch (next_frame), raw_reg_num); > > /* When overflowing a register, put_frame_register_bytes writes to the > subsequent registers. We don't want that behavior here, so make sure > diff --git a/gdb/value.h b/gdb/value.h > index 6a74d4e2c2ee..3b3cb9c00982 100644 > --- a/gdb/value.h > +++ b/gdb/value.h > @@ -1664,7 +1664,7 @@ value *pseudo_from_raw_part (frame_info_ptr next_frame, int pseudo_reg_num, > /* Write PSEUDO_BUF, the contents of a pseudo register, to part of raw register > RAW_REG_NUM starting at RAW_OFFSET. */ > > -void pseudo_to_raw_part (frame_info_ptr this_frame, > +void pseudo_to_raw_part (frame_info_ptr next_frame, > gdb::array_view pseudo_buf, > int raw_reg_num, int raw_offset); > > @@ -1680,7 +1680,7 @@ value *pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num, > /* Write PSEUDO_BUF, the contents of a pseudo register, to the two raw registers > RAW_REG_1_NUM and RAW_REG_2_NUM. */ > > -void pseudo_to_concat_raw (frame_info_ptr this_frame, > +void pseudo_to_concat_raw (frame_info_ptr next_frame, > gdb::array_view pseudo_buf, > int raw_reg_1_num, int raw_reg_2_num); > > @@ -1693,7 +1693,7 @@ value *pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num, > /* Write PSEUDO_BUF, the contents of a pseudo register, to the tthreewo raw > registers RAW_REG_1_NUM, RAW_REG_2_NUM and RAW_REG_3_NUM. */ > > -void pseudo_to_concat_raw (frame_info_ptr this_frame, > +void pseudo_to_concat_raw (frame_info_ptr next_frame, > gdb::array_view pseudo_buf, > int raw_reg_1_num, int raw_reg_2_num, > int raw_reg_3_num); Should these value.[ch] changes be part of the previous patch (17) instead? Otherwise, the amd64/i386 parts look good to me. -- John Baldwin