From: Simon Marchi <simon.marchi@ericsson.com>
To: <alan.hayward@arm.com>, <gdb-patches@sourceware.org>
Cc: <nd@arm.com>
Subject: Re: [PATCH v4 01/10] Move tdesc header funcs to c file
Date: Thu, 22 Mar 2018 20:43:00 -0000 [thread overview]
Message-ID: <a738c039-a049-11ca-f088-d75d6dd34465@ericsson.com> (raw)
In-Reply-To: <20180322084429.26250-2-alan.hayward@arm.com>
On 2018-03-22 04:44 AM, alan.hayward@arm.com wrote:
> From: Alan Hayward <alan.hayward@arm.com>
>
> Move the destructor and equals operator for gdbserver tdesc from the .h
> to the .c file. Both functions are too long to be inlined and make the
> header look messy. Patch does not change any functionality.
> Patch identical to V3 version.
>
> 2018-03-21 Alan Hayward <alan.hayward@arm.com>
>
> gdbserver/
> * tdesc.c (target_desc::~target_desc): Move to here.
> (target_desc::operator==): Likewise.
> * tdesc.h (target_desc::~target_desc): Move from here.
> (target_desc::operator==): Likewise.
This patch LGTM, feel free to push it by itself, it will be one
less patch to worry about.
Simon
next prev parent reply other threads:[~2018-03-22 20:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 8:44 [PATCH v4 00/10] Remove gdbserver dependency on xml files alan.hayward
2018-03-22 8:45 ` [PATCH v4 06/10] Add tdesc osabi and architecture functions alan.hayward
2018-03-22 8:45 ` [PATCH v4 08/10] Create xml from target descriptions alan.hayward
2018-03-23 21:24 ` Simon Marchi
2018-03-26 10:52 ` Alan Hayward
2018-03-22 8:45 ` [PATCH v4 03/10] Commonise tdesc_reg alan.hayward
2018-03-23 19:50 ` Simon Marchi
2018-03-26 10:50 ` Alan Hayward
2018-03-22 8:45 ` [PATCH v4 07/10] Add feature reference in .dat files alan.hayward
2018-03-22 8:45 ` [PATCH v4 01/10] Move tdesc header funcs to c file alan.hayward
2018-03-22 20:43 ` Simon Marchi [this message]
2018-03-22 8:45 ` [PATCH v4 04/10] Commonise tdesc_feature alan.hayward
2018-03-22 8:45 ` [PATCH v4 02/10] Make gdbserver reg_defs a vector of objects alan.hayward
2018-03-22 21:33 ` Simon Marchi
2018-03-23 14:54 ` Alan Hayward
2018-03-23 15:36 ` Simon Marchi
2018-03-23 16:52 ` Alan Hayward
2018-03-23 17:04 ` Simon Marchi
2018-03-26 10:50 ` Alan Hayward
2018-03-22 8:45 ` [PATCH v4 05/10] Commonise tdesc types alan.hayward
2018-03-23 20:12 ` Simon Marchi
2018-03-22 8:46 ` [PATCH v4 10/10] Remove xml files from gdbserver alan.hayward
2018-03-22 8:46 ` [PATCH v4 09/10] Remove xml file references from target descriptions alan.hayward
2018-03-24 2:06 ` [PATCH v4 00/10] Remove gdbserver dependency on xml files Simon Marchi
2018-03-26 10:55 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a738c039-a049-11ca-f088-d75d6dd34465@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).